mirror of
https://github.com/zulip/zulip.git
synced 2025-11-08 07:52:19 +00:00
Currently when admin add/remove/update custom fields, changes are not reflected in user settings page, if settings tab is already open. This might be rare case, but it looks like an error when admin go to user settings page just after updating custom fields in org settings. Fix this by re-rendering custom fields in user settings on custom_profile_fields event.
212 lines
6.9 KiB
JavaScript
212 lines
6.9 KiB
JavaScript
var settings_profile_fields = (function () {
|
|
|
|
var exports = {};
|
|
|
|
var meta = {
|
|
loaded: false,
|
|
};
|
|
|
|
function field_type_id_to_string(type_id) {
|
|
var name = _.find(page_params.custom_profile_field_types, function (type) {
|
|
return type[0] === type_id;
|
|
})[1];
|
|
return name;
|
|
}
|
|
|
|
function delete_profile_field(e) {
|
|
e.preventDefault();
|
|
e.stopPropagation();
|
|
|
|
settings_ui.do_settings_change(
|
|
channel.del,
|
|
"/json/realm/profile_fields/" + encodeURIComponent($(this).attr('data-profile-field-id')),
|
|
{}, $('#admin-profile-field-status').expectOne());
|
|
}
|
|
|
|
function read_field_data_from_form(selector) {
|
|
var field_data = {};
|
|
selector.each(function (ind, row) {
|
|
var value = row.children[0].value;
|
|
var text = row.children[1].value;
|
|
var order = row.children[2].value;
|
|
field_data[value] = {text: text, order: order};
|
|
});
|
|
return field_data;
|
|
}
|
|
|
|
function create_profile_field(e) {
|
|
e.preventDefault();
|
|
e.stopPropagation();
|
|
|
|
var selector = $('.admin-profile-field-form div.choice-row');
|
|
var field_data = {};
|
|
if ($('#profile_field_type').val() === '3') {
|
|
// Only read choice data if we are creating a choice field.
|
|
field_data = read_field_data_from_form(selector);
|
|
}
|
|
$('#profile_field_data').val(JSON.stringify(field_data));
|
|
|
|
settings_ui.do_settings_change(channel.post, "/json/realm/profile_fields", $(this).serialize(),
|
|
$('#admin-profile-field-status').expectOne());
|
|
}
|
|
|
|
function create_choice_row(container, add_delete_button) {
|
|
var context = {};
|
|
context.add_delete_button = add_delete_button;
|
|
var row = templates.render("profile-field-choice", context);
|
|
$(container).append(row);
|
|
}
|
|
|
|
function add_choice_row(e) {
|
|
var choices_div = e.delegateTarget;
|
|
create_choice_row(choices_div, true);
|
|
}
|
|
|
|
function delete_choice_row(e) {
|
|
var row = $(e.target).parent();
|
|
row.remove();
|
|
}
|
|
|
|
function get_profile_field_info(id) {
|
|
var info = {};
|
|
info.row = $("tr.profile-field-row[data-profile-field-id='" + id + "']");
|
|
info.form = $("tr.profile-field-form[data-profile-field-id='" + id + "']");
|
|
return info;
|
|
}
|
|
|
|
function open_edit_form(e) {
|
|
var field_id = $(e.currentTarget).attr("data-profile-field-id");
|
|
var profile_field = get_profile_field_info(field_id);
|
|
|
|
profile_field.row.hide();
|
|
profile_field.form.show();
|
|
|
|
profile_field.form.find('.reset').on("click", function () {
|
|
profile_field.form.hide();
|
|
profile_field.row.show();
|
|
});
|
|
|
|
profile_field.form.find('.submit').on("click", function () {
|
|
e.preventDefault();
|
|
e.stopPropagation();
|
|
|
|
var profile_field_status = $('#admin-profile-field-status').expectOne();
|
|
|
|
// For some reason jQuery's serialize() is not working with
|
|
// channel.patch even though it is supported by $.ajax.
|
|
var data = {};
|
|
data.name = profile_field.form.find('input[name=name]').val();
|
|
data.hint = profile_field.form.find('input[name=hint]').val();
|
|
var selector = profile_field.form.find('div.choice-row');
|
|
data.field_data = JSON.stringify(read_field_data_from_form(selector));
|
|
|
|
settings_ui.do_settings_change(channel.patch, "/json/realm/profile_fields/" + field_id,
|
|
data, profile_field_status);
|
|
});
|
|
|
|
profile_field.form.find(".profile-field-choices").on("click", "button.add-choice", add_choice_row);
|
|
profile_field.form.find(".profile-field-choices").on("click", "button.delete-choice", delete_choice_row);
|
|
}
|
|
|
|
exports.reset = function () {
|
|
meta.loaded = false;
|
|
};
|
|
|
|
exports.populate_profile_fields = function (profile_fields_data) {
|
|
$("#account-settings .custom-profile-fields-form").html("");
|
|
settings_account.add_custom_profile_fields_to_settings();
|
|
|
|
if (!meta.loaded) {
|
|
return;
|
|
}
|
|
|
|
var profile_fields_table = $("#admin_profile_fields_table").expectOne();
|
|
profile_fields_table.find("tr.profile-field-row").remove(); // Clear all rows.
|
|
profile_fields_table.find("tr.profile-field-form").remove(); // Clear all rows.
|
|
_.each(profile_fields_data, function (profile_field) {
|
|
var field_data = {};
|
|
if (profile_field.field_data !== "") {
|
|
field_data = JSON.parse(profile_field.field_data);
|
|
}
|
|
var choices = [];
|
|
_.each(field_data, function (choice, value) {
|
|
choices.push({
|
|
value: value,
|
|
text: choice.text,
|
|
order: choice.order,
|
|
add_delete_button: true,
|
|
});
|
|
});
|
|
if (choices.length > 0) {
|
|
// Remove delete button from the first choice. This makes sure that
|
|
// the user cannot delete all choices of a choice field. To delete
|
|
// all choices, just delete the field.
|
|
choices[0].add_delete_button = false;
|
|
}
|
|
|
|
var is_choice_field = false;
|
|
if (profile_field.type === 3) {
|
|
is_choice_field = true;
|
|
}
|
|
|
|
profile_fields_table.append(
|
|
templates.render(
|
|
"admin_profile_field_list", {
|
|
profile_field: {
|
|
id: profile_field.id,
|
|
name: profile_field.name,
|
|
hint: profile_field.hint,
|
|
type: field_type_id_to_string(profile_field.type),
|
|
choices: choices,
|
|
is_choice_field: is_choice_field,
|
|
},
|
|
can_modify: page_params.is_admin,
|
|
}
|
|
)
|
|
);
|
|
});
|
|
loading.destroy_indicator($('#admin_page_profile_fields_loading_indicator'));
|
|
};
|
|
|
|
function set_up_choices_field() {
|
|
create_choice_row('#profile_field_choices', false);
|
|
|
|
if ($('#profile_field_type').val() !== '3') {
|
|
// If 'Choice' type is already selected, show choice row.
|
|
$("#profile_field_choices_row").hide();
|
|
}
|
|
|
|
$('#profile_field_type').on('change', function (e) {
|
|
if ($(e.target).val() === '3') {
|
|
$("#profile_field_choices_row").show();
|
|
} else {
|
|
$("#profile_field_choices_row").hide();
|
|
}
|
|
});
|
|
|
|
$("#profile_field_choices").on("click", "button.add-choice", add_choice_row);
|
|
$("#profile_field_choices").on("click", "button.delete-choice", delete_choice_row);
|
|
}
|
|
|
|
exports.set_up = function () {
|
|
meta.loaded = true;
|
|
|
|
// create loading indicators
|
|
loading.make_indicator($('#admin_page_profile_fields_loading_indicator'));
|
|
// Populate profile_fields table
|
|
exports.populate_profile_fields(page_params.custom_profile_fields);
|
|
|
|
$('#admin_profile_fields_table').on('click', '.delete', delete_profile_field);
|
|
$(".organization").on("submit", "form.admin-profile-field-form", create_profile_field);
|
|
$("#admin_profile_fields_table").on("click", ".open-edit-form", open_edit_form);
|
|
|
|
set_up_choices_field();
|
|
};
|
|
|
|
return exports;
|
|
}());
|
|
|
|
if (typeof module !== 'undefined') {
|
|
module.exports = settings_profile_fields;
|
|
}
|