mirror of
https://github.com/zulip/zulip.git
synced 2025-11-03 13:33:24 +00:00
For spectators, the chunk of page_params that originates from do_events_register isn’t assigned until ui_init.js. That means the TypeScript type of page_params is mostly a lie during module load time: reading a parameter too early silently results in undefined rather than the declared type, with unpredictable results later on. We want to make such an early read into an immediate runtime error, for both users and spectators consistently, and pave the way for runtime validation of the page_params type. As a second step, split out the subset of fields that pertain to the entire realm. Signed-off-by: Anders Kaseorg <anders@zulip.com>
273 lines
8.9 KiB
JavaScript
273 lines
8.9 KiB
JavaScript
"use strict";
|
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
const events = require("./lib/events");
|
|
const {mock_esm, set_global, with_overrides, zrequire} = require("./lib/namespace");
|
|
const {run_test, noop} = require("./lib/test");
|
|
const $ = require("./lib/zjquery");
|
|
const {current_user, page_params, realm} = require("./lib/zpage_params");
|
|
|
|
const channel = mock_esm("../src/channel");
|
|
const compose_closed_ui = mock_esm("../src/compose_closed_ui");
|
|
const compose_ui = mock_esm("../src/compose_ui");
|
|
const upload = mock_esm("../src/upload");
|
|
mock_esm("../src/resize", {
|
|
watch_manual_resize() {},
|
|
});
|
|
set_global("document", {
|
|
querySelector() {},
|
|
});
|
|
set_global("navigator", {});
|
|
set_global(
|
|
"ResizeObserver",
|
|
class ResizeObserver {
|
|
observe() {}
|
|
},
|
|
);
|
|
|
|
const server_events_dispatch = zrequire("server_events_dispatch");
|
|
const compose_setup = zrequire("compose_setup");
|
|
|
|
function stub_out_video_calls() {
|
|
const $elem = $(".compose-control-buttons-container .video_link");
|
|
$elem.toggle = (show) => {
|
|
/* istanbul ignore if */
|
|
if (show) {
|
|
$elem.show();
|
|
} else {
|
|
$elem.hide();
|
|
}
|
|
};
|
|
}
|
|
|
|
const realm_available_video_chat_providers = {
|
|
disabled: {
|
|
id: 0,
|
|
name: "disabled",
|
|
},
|
|
jitsi_meet: {
|
|
id: 1,
|
|
name: "Jitsi Meet",
|
|
},
|
|
zoom: {
|
|
id: 3,
|
|
name: "Zoom",
|
|
},
|
|
big_blue_button: {
|
|
id: 4,
|
|
name: "BigBlueButton",
|
|
},
|
|
};
|
|
|
|
function test(label, f) {
|
|
run_test(label, (helpers) => {
|
|
realm.realm_available_video_chat_providers = realm_available_video_chat_providers;
|
|
f(helpers);
|
|
});
|
|
}
|
|
|
|
test("videos", ({override}) => {
|
|
realm.realm_video_chat_provider = realm_available_video_chat_providers.disabled.id;
|
|
|
|
override(upload, "feature_check", noop);
|
|
|
|
stub_out_video_calls();
|
|
|
|
compose_setup.initialize();
|
|
|
|
(function test_no_provider_video_link_compose_clicked() {
|
|
const $textarea = $.create("target-stub");
|
|
$textarea.set_parents_result(".message_edit_form", []);
|
|
|
|
const ev = {
|
|
preventDefault() {},
|
|
stopPropagation() {},
|
|
};
|
|
|
|
const handler = $("body").get_on_handler("click", ".video_link");
|
|
$("textarea#compose-textarea").val("");
|
|
|
|
with_overrides(({disallow}) => {
|
|
disallow(compose_ui, "insert_syntax_and_focus");
|
|
handler(ev);
|
|
});
|
|
})();
|
|
|
|
(function test_jitsi_video_link_compose_clicked() {
|
|
let syntax_to_insert;
|
|
let called = false;
|
|
|
|
const $textarea = $.create("jitsi-target-stub");
|
|
$textarea.set_parents_result(".message_edit_form", []);
|
|
|
|
const ev = {
|
|
preventDefault() {},
|
|
stopPropagation() {},
|
|
target: {
|
|
to_$: () => $textarea,
|
|
},
|
|
};
|
|
|
|
override(compose_ui, "insert_syntax_and_focus", (syntax) => {
|
|
syntax_to_insert = syntax;
|
|
called = true;
|
|
});
|
|
|
|
const handler = $("body").get_on_handler("click", ".video_link");
|
|
$("textarea#compose-textarea").val("");
|
|
|
|
realm.realm_video_chat_provider = realm_available_video_chat_providers.jitsi_meet.id;
|
|
|
|
realm.realm_jitsi_server_url = null;
|
|
realm.server_jitsi_server_url = null;
|
|
handler(ev);
|
|
assert.ok(!called);
|
|
|
|
realm.realm_jitsi_server_url = null;
|
|
realm.server_jitsi_server_url = "https://server.example.com";
|
|
handler(ev);
|
|
// video link ids consist of 15 random digits
|
|
let video_link_regex =
|
|
/\[translated: Join video call\.]\(https:\/\/server.example.com\/\d{15}#config.startWithVideoMuted=false\)/;
|
|
assert.ok(called);
|
|
assert.match(syntax_to_insert, video_link_regex);
|
|
|
|
realm.realm_jitsi_server_url = "https://realm.example.com";
|
|
realm.server_jitsi_server_url = null;
|
|
handler(ev);
|
|
video_link_regex =
|
|
/\[translated: Join video call\.]\(https:\/\/realm.example.com\/\d{15}#config.startWithVideoMuted=false\)/;
|
|
assert.ok(called);
|
|
assert.match(syntax_to_insert, video_link_regex);
|
|
|
|
realm.realm_jitsi_server_url = "https://realm.example.com";
|
|
realm.server_jitsi_server_url = "https://server.example.com";
|
|
handler(ev);
|
|
video_link_regex =
|
|
/\[translated: Join video call\.]\(https:\/\/realm.example.com\/\d{15}#config.startWithVideoMuted=false\)/;
|
|
assert.ok(called);
|
|
assert.match(syntax_to_insert, video_link_regex);
|
|
})();
|
|
|
|
(function test_zoom_video_and_audio_links_compose_clicked() {
|
|
let syntax_to_insert;
|
|
let called = false;
|
|
|
|
const $textarea = $.create("zoom-target-stub");
|
|
$textarea.set_parents_result(".message_edit_form", []);
|
|
|
|
const ev = {
|
|
preventDefault() {},
|
|
stopPropagation() {},
|
|
target: {
|
|
to_$: () => $textarea,
|
|
},
|
|
};
|
|
|
|
override(compose_ui, "insert_syntax_and_focus", (syntax) => {
|
|
syntax_to_insert = syntax;
|
|
called = true;
|
|
});
|
|
|
|
realm.realm_video_chat_provider = realm_available_video_chat_providers.zoom.id;
|
|
current_user.has_zoom_token = false;
|
|
|
|
window.open = (url) => {
|
|
assert.ok(url.endsWith("/calls/zoom/register"));
|
|
|
|
// The event here has value=true. We keep it in events.js to
|
|
// allow our tooling to verify its schema.
|
|
server_events_dispatch.dispatch_normal_event(events.fixtures.has_zoom_token);
|
|
};
|
|
|
|
channel.post = (payload) => {
|
|
assert.equal(payload.url, "/json/calls/zoom/create");
|
|
payload.success({url: "example.zoom.com"});
|
|
return {abort() {}};
|
|
};
|
|
|
|
$("textarea#compose-textarea").val("");
|
|
const video_handler = $("body").get_on_handler("click", ".video_link");
|
|
video_handler(ev);
|
|
const video_link_regex = /\[translated: Join video call\.]\(example\.zoom\.com\)/;
|
|
assert.ok(called);
|
|
assert.match(syntax_to_insert, video_link_regex);
|
|
|
|
$("textarea#compose-textarea").val("");
|
|
const audio_handler = $("body").get_on_handler("click", ".audio_link");
|
|
audio_handler(ev);
|
|
const audio_link_regex = /\[translated: Join voice call\.]\(example\.zoom\.com\)/;
|
|
assert.ok(called);
|
|
assert.match(syntax_to_insert, audio_link_regex);
|
|
})();
|
|
|
|
(function test_bbb_video_link_compose_clicked() {
|
|
let syntax_to_insert;
|
|
let called = false;
|
|
|
|
const $textarea = $.create("bbb-target-stub");
|
|
$textarea.set_parents_result(".message_edit_form", []);
|
|
|
|
const ev = {
|
|
preventDefault() {},
|
|
stopPropagation() {},
|
|
target: {
|
|
to_$: () => $textarea,
|
|
},
|
|
};
|
|
|
|
override(compose_ui, "insert_syntax_and_focus", (syntax) => {
|
|
syntax_to_insert = syntax;
|
|
called = true;
|
|
});
|
|
|
|
const handler = $("body").get_on_handler("click", ".video_link");
|
|
$("textarea#compose-textarea").val("");
|
|
|
|
realm.realm_video_chat_provider = realm_available_video_chat_providers.big_blue_button.id;
|
|
|
|
override(compose_closed_ui, "get_recipient_label", () => "a");
|
|
|
|
channel.get = (options) => {
|
|
assert.equal(options.url, "/json/calls/bigbluebutton/create");
|
|
assert.equal(options.data.meeting_name, "a meeting");
|
|
options.success({
|
|
url: "/calls/bigbluebutton/join?meeting_id=%22zulip-1%22&password=%22AAAAAAAAAA%22&checksum=%2232702220bff2a22a44aee72e96cfdb4c4091752e%22",
|
|
});
|
|
};
|
|
|
|
handler(ev);
|
|
const video_link_regex =
|
|
/\[translated: Join video call\.]\(\/calls\/bigbluebutton\/join\?meeting_id=%22zulip-1%22&password=%22AAAAAAAAAA%22&checksum=%2232702220bff2a22a44aee72e96cfdb4c4091752e%22\)/;
|
|
assert.ok(called);
|
|
assert.match(syntax_to_insert, video_link_regex);
|
|
})();
|
|
});
|
|
|
|
test("test_video_chat_button_toggle disabled", ({override}) => {
|
|
override(upload, "feature_check", noop);
|
|
|
|
realm.realm_video_chat_provider = realm_available_video_chat_providers.disabled.id;
|
|
compose_setup.initialize();
|
|
assert.equal($(".compose-control-buttons-container .video_link").visible(), false);
|
|
});
|
|
|
|
test("test_video_chat_button_toggle no url", ({override}) => {
|
|
override(upload, "feature_check", noop);
|
|
|
|
realm.realm_video_chat_provider = realm_available_video_chat_providers.jitsi_meet.id;
|
|
page_params.jitsi_server_url = null;
|
|
compose_setup.initialize();
|
|
assert.equal($(".compose-control-buttons-container .video_link").visible(), false);
|
|
});
|
|
|
|
test("test_video_chat_button_toggle enabled", ({override}) => {
|
|
override(upload, "feature_check", noop);
|
|
|
|
realm.realm_video_chat_provider = realm_available_video_chat_providers.jitsi_meet.id;
|
|
realm.realm_jitsi_server_url = "https://meet.jit.si";
|
|
compose_setup.initialize();
|
|
assert.equal($(".compose-control-buttons-container .video_link").visible(), true);
|
|
});
|