mirror of
https://github.com/zulip/zulip.git
synced 2025-11-07 23:43:43 +00:00
b0e3191434
The `tidy` parameter is buggy, and ignores all ordering metaparameters. This is fixed in Puppet 7[^1], but it's helpful to resolve it now. Specifically, this fixes bugs with tidy running too early, and deleting the old version of a package before its new version is installed or symlinked, leaving a race condition if anything tries to run the binary in this window. This is mostly not a problem for Supervisor-managed processes, since the binary is already running, and can continue to run if it is tidied out from under the running process. For stand-alone tools like wal-g, which are run frequently by PostgreSQL, this may cause issues if PostgreSQL tries to call them during a puppet run. Remove all complicated uses of tidy, and replace them with an `exec` which does the equivalent. We also generate `file` resources for binaries, making them easier (and clearer) to specify as dependencies. [^1]: https://puppet.atlassian.net/browse/PUP-10688
34 lines
1.1 KiB
Puppet
34 lines
1.1 KiB
Puppet
# @summary Prometheus monitoring of redis servers
|
|
#
|
|
class kandra::prometheus::redis {
|
|
include kandra::prometheus::base
|
|
include zulip::supervisor
|
|
|
|
$version = $zulip::common::versions['redis_exporter']['version']
|
|
$dir = "/srv/zulip-redis_exporter-${version}"
|
|
$bin = "${dir}/redis_exporter"
|
|
|
|
zulip::external_dep { 'redis_exporter':
|
|
version => $version,
|
|
url => "https://github.com/oliver006/redis_exporter/releases/download/v${version}/redis_exporter-v${version}.linux-${zulip::common::goarch}.tar.gz",
|
|
tarball_prefix => "redis_exporter-v${version}.linux-${zulip::common::goarch}",
|
|
bin => [$bin],
|
|
cleanup_after => [Service[supervisor]],
|
|
}
|
|
|
|
kandra::firewall_allow { 'redis_exporter': port => '9121' }
|
|
file { "${zulip::common::supervisor_conf_dir}/prometheus_redis_exporter.conf":
|
|
ensure => file,
|
|
require => [
|
|
User[zulip],
|
|
Package[supervisor],
|
|
File[$bin],
|
|
],
|
|
owner => 'root',
|
|
group => 'root',
|
|
mode => '0644',
|
|
content => template('kandra/supervisor/conf.d/prometheus_redis_exporter.conf.template.erb'),
|
|
notify => Service[supervisor],
|
|
}
|
|
}
|