mirror of
https://github.com/zulip/zulip.git
synced 2025-11-04 22:13:26 +00:00
40475a41b0
This commit changes the would_receive_message to use user_id instead of emails. This change is done because user_ids are immutable and using user_ids is the correct way of uniquely identifying user. The change in 'would_receive_message' also leads to change in util.is_pm_recipient to use a string of user_ids instead of emails. We also know that user_ids passed to 'would_receive_message' are active user_ids, since we get them from buddy_list. So we don't need to check whether the user is active, which was previously being checked by get_active_user_for_email.
75 lines
1.7 KiB
JavaScript
75 lines
1.7 KiB
JavaScript
zrequire('stream_data');
|
|
zrequire('people');
|
|
zrequire('compose_fade');
|
|
|
|
const me = {
|
|
email: 'me@example.com',
|
|
user_id: 30,
|
|
full_name: 'Me Myself',
|
|
};
|
|
|
|
const alice = {
|
|
email: 'alice@example.com',
|
|
user_id: 31,
|
|
full_name: 'Alice',
|
|
};
|
|
|
|
const bob = {
|
|
email: 'bob@example.com',
|
|
user_id: 32,
|
|
full_name: 'Bob',
|
|
};
|
|
|
|
people.add_active_user(me);
|
|
people.initialize_current_user(me.user_id);
|
|
|
|
people.add_active_user(alice);
|
|
people.add_active_user(bob);
|
|
|
|
run_test('set_focused_recipient', () => {
|
|
const sub = {
|
|
stream_id: 101,
|
|
name: 'social',
|
|
subscribed: true,
|
|
can_access_subscribers: true,
|
|
};
|
|
stream_data.add_sub(sub);
|
|
stream_data.set_subscribers(sub, [me.user_id, alice.user_id]);
|
|
|
|
global.$ = function (selector) {
|
|
switch (selector) {
|
|
case '#stream_message_recipient_stream':
|
|
return {
|
|
val: function () {
|
|
return 'social';
|
|
},
|
|
};
|
|
case '#stream_message_recipient_topic':
|
|
return {
|
|
val: function () {
|
|
return 'lunch';
|
|
},
|
|
};
|
|
}
|
|
};
|
|
|
|
compose_fade.set_focused_recipient('stream');
|
|
|
|
assert.equal(compose_fade.would_receive_message(me.user_id), true);
|
|
assert.equal(compose_fade.would_receive_message(alice.user_id), true);
|
|
assert.equal(compose_fade.would_receive_message(bob.user_id), false);
|
|
|
|
const good_msg = {
|
|
type: 'stream',
|
|
stream_id: 101,
|
|
topic: 'lunch',
|
|
};
|
|
const bad_msg = {
|
|
type: 'stream',
|
|
stream_id: 999,
|
|
topic: 'lunch',
|
|
};
|
|
assert(!compose_fade.should_fade_message(good_msg));
|
|
assert(compose_fade.should_fade_message(bad_msg));
|
|
});
|