mirror of
https://github.com/zulip/zulip.git
synced 2025-11-03 13:33:24 +00:00
69a2775e9b
Earlier, we were using 'send_event' in 'do_set_zoom_token' which can lead to a situation, if any db operation is added after the 'send_event' in future, where we enqueue events but the action function fails at a later stage. Events should not be sent until we know we're not rolling back. Fixes part of #30489.
16 lines
456 B
Python
16 lines
456 B
Python
from django.db import transaction
|
|
|
|
from zerver.models import UserProfile
|
|
from zerver.tornado.django_api import send_event_on_commit
|
|
|
|
|
|
@transaction.atomic(durable=True)
|
|
def do_set_zoom_token(user: UserProfile, token: dict[str, object] | None) -> None:
|
|
user.zoom_token = token
|
|
user.save(update_fields=["zoom_token"])
|
|
send_event_on_commit(
|
|
user.realm,
|
|
dict(type="has_zoom_token", value=token is not None),
|
|
[user.id],
|
|
)
|