mirror of
https://github.com/zulip/zulip.git
synced 2025-11-01 20:44:04 +00:00
b9e62c7af8
For spectators, the chunk of page_params that originates from do_events_register isn’t assigned until ui_init.js. That means the TypeScript type of page_params is mostly a lie during module load time: reading a parameter too early silently results in undefined rather than the declared type, with unpredictable results later on. We want to make such an early read into an immediate runtime error, for both users and spectators consistently, and pave the way for runtime validation of the page_params type. As a second step, split out the subset of fields that pertain to the entire realm. Signed-off-by: Anders Kaseorg <anders@zulip.com>
68 lines
3.0 KiB
JavaScript
68 lines
3.0 KiB
JavaScript
"use strict";
|
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
const {zrequire} = require("./lib/namespace");
|
|
const {run_test} = require("./lib/test");
|
|
const {realm} = require("./lib/zpage_params");
|
|
|
|
const gear_menu_util = zrequire("gear_menu_util");
|
|
|
|
run_test("version_display_string", () => {
|
|
let expected_version_display_string;
|
|
|
|
// An official release
|
|
realm.zulip_version = "5.6";
|
|
realm.zulip_merge_base = "5.6";
|
|
expected_version_display_string = "translated: Zulip Server 5.6";
|
|
assert.equal(gear_menu_util.version_display_string(), expected_version_display_string);
|
|
|
|
// An official beta
|
|
realm.zulip_version = "6.0-beta1";
|
|
realm.zulip_merge_base = "6.0-beta1";
|
|
expected_version_display_string = "translated: Zulip Server 6.0-beta1";
|
|
assert.equal(gear_menu_util.version_display_string(), expected_version_display_string);
|
|
|
|
// An official release candidate
|
|
realm.zulip_version = "6.0-rc1";
|
|
realm.zulip_merge_base = "6.0-rc1";
|
|
expected_version_display_string = "translated: Zulip Server 6.0-rc1";
|
|
assert.equal(gear_menu_util.version_display_string(), expected_version_display_string);
|
|
|
|
// The Zulip development environment
|
|
realm.zulip_version = "6.0-dev+git";
|
|
realm.zulip_merge_base = "6.0-dev+git";
|
|
expected_version_display_string = "translated: Zulip Server dev environment";
|
|
assert.equal(gear_menu_util.version_display_string(), expected_version_display_string);
|
|
|
|
// A commit on Zulip's main branch.
|
|
realm.zulip_version = "6.0-dev-1976-g4bb381fc80";
|
|
realm.zulip_merge_base = "6.0-dev-1976-g4bb381fc80";
|
|
expected_version_display_string = "translated: Zulip Server 6.0-dev";
|
|
assert.equal(gear_menu_util.version_display_string(), expected_version_display_string);
|
|
|
|
// A fork with 18 commits beyond Zulip's main branch.
|
|
realm.zulip_version = "6.0-dev-1994-g93730766b0";
|
|
realm.zulip_merge_base = "6.0-dev-1976-g4bb381fc80";
|
|
expected_version_display_string = "translated: Zulip Server 6.0-dev (modified)";
|
|
assert.equal(gear_menu_util.version_display_string(), expected_version_display_string);
|
|
|
|
// A commit from the Zulip 5.x branch
|
|
realm.zulip_version = "5.6+git-4-g385a408be5";
|
|
realm.zulip_merge_base = "5.6+git-4-g385a408be5";
|
|
expected_version_display_string = "translated: Zulip Server 5.6 (patched)";
|
|
assert.equal(gear_menu_util.version_display_string(), expected_version_display_string);
|
|
|
|
// A fork with 3 commits beyond the Zulip 5.x branch.
|
|
realm.zulip_version = "5.6+git-4-g385a408be5";
|
|
realm.zulip_merge_base = "5.6+git-7-abcda4235c2";
|
|
expected_version_display_string = "translated: Zulip Server 5.6 (modified)";
|
|
assert.equal(gear_menu_util.version_display_string(), expected_version_display_string);
|
|
|
|
// A fork of a Zulip release commit, not on 5.x branch.
|
|
realm.zulip_version = "5.3-1-g7ed896c0db";
|
|
realm.zulip_merge_base = "5.3";
|
|
expected_version_display_string = "translated: Zulip Server 5.3 (modified)";
|
|
assert.equal(gear_menu_util.version_display_string(), expected_version_display_string);
|
|
});
|