mirror of
https://github.com/zulip/zulip.git
synced 2025-11-06 15:03:34 +00:00
ac7b09d57e
And convert the corresponding function expressions to arrow style
while we’re here.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
recast.visit(ast, {
visitCallExpression(path) {
const { callee, arguments: args } = path.node;
if (
n.MemberExpression.check(callee) &&
!callee.computed &&
n.Identifier.check(callee.object) &&
callee.object.name === "_" &&
n.Identifier.check(callee.property) &&
callee.property.name === "map" &&
args.length === 2 &&
checkExpression(args[0]) &&
checkExpression(args[1])
) {
const [arr, fn] = args;
path.replace(
b.callExpression(b.memberExpression(arr, b.identifier("map")), [
n.FunctionExpression.check(fn) ||
n.ArrowFunctionExpression.check(fn)
? b.arrowFunctionExpression(
fn.params,
n.BlockStatement.check(fn.body) &&
fn.body.body.length === 1 &&
n.ReturnStatement.check(fn.body.body[0])
? fn.body.body[0].argument || b.identifier("undefined")
: fn.body
)
: fn,
])
);
changed = true;
}
this.traverse(path);
},
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
80 lines
2.1 KiB
JavaScript
80 lines
2.1 KiB
JavaScript
// Make it explicit that our toggler is undefined until
|
|
// set_up_toggler is called.
|
|
exports.toggler = undefined;
|
|
|
|
exports.set_up_toggler = function () {
|
|
const opts = {
|
|
selected: 0,
|
|
child_wants_focus: true,
|
|
values: [
|
|
{ label: i18n.t("Keyboard shortcuts"), key: "keyboard-shortcuts" },
|
|
{ label: i18n.t("Message formatting"), key: "message-formatting" },
|
|
{ label: i18n.t("Search operators"), key: "search-operators" },
|
|
],
|
|
callback: function (name, key) {
|
|
$(".overlay-modal").hide();
|
|
$("#" + key).show();
|
|
$("#" + key).find(".modal-body").focus();
|
|
},
|
|
};
|
|
|
|
exports.toggler = components.toggle(opts);
|
|
const elem = exports.toggler.get();
|
|
elem.addClass('large allow-overflow');
|
|
|
|
const modals = opts.values.map(item => {
|
|
const key = item.key; // e.g. message-formatting
|
|
const modal = $('#' + key).find('.modal-body');
|
|
return modal;
|
|
});
|
|
|
|
for (const modal of modals) {
|
|
keydown_util.handle({
|
|
elem: modal,
|
|
handlers: {
|
|
left_arrow: exports.toggler.maybe_go_left,
|
|
right_arrow: exports.toggler.maybe_go_right,
|
|
},
|
|
});
|
|
}
|
|
|
|
$(".informational-overlays .overlay-tabs").append(elem);
|
|
|
|
common.adjust_mac_shortcuts(".hotkeys_table .hotkey kbd");
|
|
common.adjust_mac_shortcuts("#markdown-instructions kbd");
|
|
};
|
|
|
|
exports.show = function (target) {
|
|
if (!exports.toggler) {
|
|
exports.set_up_toggler();
|
|
}
|
|
|
|
const overlay = $(".informational-overlays");
|
|
|
|
if (!overlay.hasClass("show")) {
|
|
overlays.open_overlay({
|
|
name: 'informationalOverlays',
|
|
overlay: overlay,
|
|
on_close: function () {
|
|
hashchange.changehash("");
|
|
},
|
|
});
|
|
}
|
|
|
|
if (target) {
|
|
exports.toggler.goto(target);
|
|
}
|
|
};
|
|
|
|
exports.maybe_show_keyboard_shortcuts = function () {
|
|
if (overlays.is_active()) {
|
|
return;
|
|
}
|
|
if (popovers.any_active()) {
|
|
return;
|
|
}
|
|
exports.show("keyboard-shortcuts");
|
|
};
|
|
|
|
window.info_overlay = exports;
|