mirror of
https://github.com/zulip/zulip.git
synced 2025-11-05 14:35:27 +00:00
We now call topic_data.add_message() and topic_data.remove_message() when we get info about incoming messages. The old way of passing in a boolean made the calling code hard to read and added unncessary conditional logic to the codepath. We also have vague plans to change how we handle removing topics, since increment/decrement logic is now kind of fragile, so making the "remove" path more explicit prepares us to something smarter in the future, like just figure out when the last topic has been removed by calling a filter function or something outside of topic_data.js. Another thing to note here is that the code changed here in echo.js is dead code, since we've disabled message editing for locally edited messages. I considered removing this code in a preparatory commit, but there's other PR activity related to local echo that I don't want to conflict with. One nice aspect of removing process_message() is that the new topic_data.js module does not refer to the legacy field "subject" any more, nor do its node tests.
212 lines
6.5 KiB
JavaScript
212 lines
6.5 KiB
JavaScript
var message_store = (function () {
|
|
|
|
var exports = {};
|
|
var stored_messages = {};
|
|
|
|
exports.recent_private_messages = [];
|
|
|
|
exports.get = function get(message_id) {
|
|
return stored_messages[message_id];
|
|
};
|
|
|
|
exports.get_pm_emails = function (message) {
|
|
|
|
function email(user_id) {
|
|
var person = people.get_person_from_user_id(user_id);
|
|
if (!person) {
|
|
blueslip.error('Unknown user id ' + user_id);
|
|
return '?';
|
|
}
|
|
return person.email;
|
|
}
|
|
|
|
var user_ids = people.pm_with_user_ids(message);
|
|
var emails = _.map(user_ids, email).sort();
|
|
|
|
return emails.join(', ');
|
|
};
|
|
|
|
exports.get_pm_full_names = function (message) {
|
|
|
|
function name(user_id) {
|
|
var person = people.get_person_from_user_id(user_id);
|
|
if (!person) {
|
|
blueslip.error('Unknown user id ' + user_id);
|
|
return '?';
|
|
}
|
|
return person.full_name;
|
|
}
|
|
|
|
var user_ids = people.pm_with_user_ids(message);
|
|
var names = _.map(user_ids, name).sort();
|
|
|
|
return names.join(', ');
|
|
};
|
|
|
|
exports.process_message_for_recent_private_messages = function (message) {
|
|
var user_ids = people.pm_with_user_ids(message);
|
|
if (!user_ids) {
|
|
return;
|
|
}
|
|
|
|
_.each(user_ids, function (user_id) {
|
|
pm_conversations.set_partner(user_id);
|
|
});
|
|
|
|
var user_ids_string = user_ids.join(',');
|
|
|
|
if (!user_ids_string) {
|
|
blueslip.warn('Unknown reply_to in message: ' + user_ids_string);
|
|
return;
|
|
}
|
|
exports.insert_recent_private_message(user_ids_string, message.timestamp);
|
|
};
|
|
|
|
exports.insert_recent_private_message = (function () {
|
|
var recent_timestamps = new Dict({fold_case: true}); // key is user_ids_string
|
|
|
|
return function (user_ids_string, timestamp) {
|
|
var conversation = recent_timestamps.get(user_ids_string);
|
|
|
|
if (conversation === undefined) {
|
|
// This is a new user, so create a new object.
|
|
conversation = {
|
|
user_ids_string: user_ids_string,
|
|
timestamp: timestamp,
|
|
};
|
|
recent_timestamps.set(user_ids_string, conversation);
|
|
|
|
// Optimistically insert the new message at the front, since that
|
|
// is usually where it belongs, but we'll re-sort.
|
|
exports.recent_private_messages.unshift(conversation);
|
|
} else {
|
|
if (conversation.timestamp >= timestamp) {
|
|
return; // don't backdate our conversation
|
|
}
|
|
|
|
// update our timestamp
|
|
conversation.timestamp = timestamp;
|
|
}
|
|
|
|
exports.recent_private_messages.sort(function (a, b) {
|
|
return b.timestamp - a.timestamp;
|
|
});
|
|
};
|
|
}());
|
|
|
|
exports.set_topic_edit_properties = function (message) {
|
|
message.always_visible_topic_edit = false;
|
|
message.on_hover_topic_edit = false;
|
|
if (!page_params.realm_allow_message_editing) {
|
|
return;
|
|
}
|
|
|
|
// Messages with no topics should always have an edit icon visible
|
|
// to encourage updating them. Admins can also edit any topic.
|
|
if (message.subject === compose.empty_topic_placeholder()) {
|
|
message.always_visible_topic_edit = true;
|
|
} else if (page_params.is_admin) {
|
|
message.on_hover_topic_edit = true;
|
|
}
|
|
};
|
|
|
|
exports.add_message_metadata = function (message) {
|
|
var cached_msg = stored_messages[message.id];
|
|
if (cached_msg !== undefined) {
|
|
// Copy the match subject and content over if they exist on
|
|
// the new message
|
|
if (message.match_subject !== undefined) {
|
|
cached_msg.match_subject = message.match_subject;
|
|
cached_msg.match_content = message.match_content;
|
|
}
|
|
return cached_msg;
|
|
}
|
|
|
|
message.sent_by_me = people.is_current_user(message.sender_email);
|
|
|
|
message.flags = message.flags || [];
|
|
message.historical = (message.flags !== undefined &&
|
|
message.flags.indexOf('historical') !== -1);
|
|
message.starred = message.flags.indexOf("starred") !== -1;
|
|
message.mentioned = message.flags.indexOf("mentioned") !== -1 ||
|
|
message.flags.indexOf("wildcard_mentioned") !== -1;
|
|
message.mentioned_me_directly = message.flags.indexOf("mentioned") !== -1;
|
|
message.collapsed = message.flags.indexOf("collapsed") !== -1;
|
|
message.alerted = message.flags.indexOf("has_alert_word") !== -1;
|
|
message.is_me_message = message.flags.indexOf("is_me_message") !== -1;
|
|
|
|
people.extract_people_from_message(message);
|
|
|
|
var sender = people.get_person_from_user_id(message.sender_id);
|
|
if (sender) {
|
|
message.sender_full_name = sender.full_name;
|
|
message.sender_email = sender.email;
|
|
}
|
|
|
|
switch (message.type) {
|
|
case 'stream':
|
|
message.is_stream = true;
|
|
message.stream = message.display_recipient;
|
|
composebox_typeahead.add_topic(message.stream, message.subject);
|
|
message.reply_to = message.sender_email;
|
|
|
|
topic_data.add_message({
|
|
stream_id: message.stream_id,
|
|
topic_name: message.subject,
|
|
message_id: message.id,
|
|
});
|
|
|
|
exports.set_topic_edit_properties(message);
|
|
|
|
recent_senders.process_message_for_senders(message);
|
|
break;
|
|
|
|
case 'private':
|
|
message.is_private = true;
|
|
message.reply_to = util.normalize_recipients(
|
|
exports.get_pm_emails(message));
|
|
message.display_reply_to = exports.get_pm_full_names(message);
|
|
message.pm_with_url = people.pm_with_url(message);
|
|
message.to_user_ids = people.pm_reply_user_string(message);
|
|
|
|
exports.process_message_for_recent_private_messages(message);
|
|
break;
|
|
}
|
|
|
|
alert_words.process_message(message);
|
|
if (!message.reactions) {
|
|
message.reactions = [];
|
|
}
|
|
stored_messages[message.id] = message;
|
|
return message;
|
|
};
|
|
|
|
exports.reify_message_id = function (opts) {
|
|
var old_id = opts.old_id;
|
|
var new_id = opts.new_id;
|
|
if (pointer.furthest_read === old_id) {
|
|
pointer.furthest_read = new_id;
|
|
}
|
|
if (stored_messages[old_id]) {
|
|
stored_messages[new_id] = stored_messages[old_id];
|
|
delete stored_messages[old_id];
|
|
}
|
|
|
|
_.each([message_list.all, home_msg_list, message_list.narrowed], function (msg_list) {
|
|
if (msg_list !== undefined) {
|
|
msg_list.change_message_id(old_id, new_id);
|
|
|
|
if (msg_list.view !== undefined) {
|
|
msg_list.view.change_message_id(old_id, new_id);
|
|
}
|
|
}
|
|
});
|
|
};
|
|
|
|
return exports;
|
|
|
|
}());
|
|
if (typeof module !== 'undefined') {
|
|
module.exports = message_store;
|
|
}
|