mirror of
				https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git
				synced 2025-11-04 05:53:26 +00:00 
			
		
		
		
	GPRS: don't allow VTY configuration of GPRS parameters if GPRS inactive
This commit is contained in:
		@@ -1633,6 +1633,11 @@ DEFUN(cfg_bts_prs_bvci, cfg_bts_gprs_bvci_cmd,
 | 
			
		||||
{
 | 
			
		||||
	struct gsm_bts *bts = vty->index;
 | 
			
		||||
 | 
			
		||||
	if (!bts->gprs.enabled) {
 | 
			
		||||
		vty_out(vty, "%% GPRS not enabled on this BTS%s", VTY_NEWLINE);
 | 
			
		||||
		return CMD_WARNING;
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	bts->gprs.cell.bvci = atoi(argv[0]);
 | 
			
		||||
 | 
			
		||||
	return CMD_SUCCESS;
 | 
			
		||||
@@ -1645,6 +1650,11 @@ DEFUN(cfg_bts_gprs_nsvci, cfg_bts_gprs_nsvci_cmd,
 | 
			
		||||
	struct gsm_bts *bts = vty->index;
 | 
			
		||||
	int idx = atoi(argv[0]);
 | 
			
		||||
 | 
			
		||||
	if (!bts->gprs.enabled) {
 | 
			
		||||
		vty_out(vty, "%% GPRS not enabled on this BTS%s", VTY_NEWLINE);
 | 
			
		||||
		return CMD_WARNING;
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	bts->gprs.nsvc[idx].nsvci = atoi(argv[1]);
 | 
			
		||||
 | 
			
		||||
	return CMD_SUCCESS;
 | 
			
		||||
@@ -1657,6 +1667,11 @@ DEFUN(cfg_bts_gprs_nsvc_lport, cfg_bts_gprs_nsvc_lport_cmd,
 | 
			
		||||
	struct gsm_bts *bts = vty->index;
 | 
			
		||||
	int idx = atoi(argv[0]);
 | 
			
		||||
 | 
			
		||||
	if (!bts->gprs.enabled) {
 | 
			
		||||
		vty_out(vty, "%% GPRS not enabled on this BTS%s", VTY_NEWLINE);
 | 
			
		||||
		return CMD_WARNING;
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	bts->gprs.nsvc[idx].local_port = atoi(argv[1]);
 | 
			
		||||
 | 
			
		||||
	return CMD_SUCCESS;
 | 
			
		||||
@@ -1669,6 +1684,11 @@ DEFUN(cfg_bts_gprs_nsvc_rport, cfg_bts_gprs_nsvc_rport_cmd,
 | 
			
		||||
	struct gsm_bts *bts = vty->index;
 | 
			
		||||
	int idx = atoi(argv[0]);
 | 
			
		||||
 | 
			
		||||
	if (!bts->gprs.enabled) {
 | 
			
		||||
		vty_out(vty, "%% GPRS not enabled on this BTS%s", VTY_NEWLINE);
 | 
			
		||||
		return CMD_WARNING;
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	bts->gprs.nsvc[idx].remote_port = atoi(argv[1]);
 | 
			
		||||
 | 
			
		||||
	return CMD_SUCCESS;
 | 
			
		||||
@@ -1682,6 +1702,11 @@ DEFUN(cfg_bts_gprs_nsvc_rip, cfg_bts_gprs_nsvc_rip_cmd,
 | 
			
		||||
	int idx = atoi(argv[0]);
 | 
			
		||||
	struct in_addr ia;
 | 
			
		||||
 | 
			
		||||
	if (!bts->gprs.enabled) {
 | 
			
		||||
		vty_out(vty, "%% GPRS not enabled on this BTS%s", VTY_NEWLINE);
 | 
			
		||||
		return CMD_WARNING;
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	inet_aton(argv[1], &ia);
 | 
			
		||||
	bts->gprs.nsvc[idx].remote_ip = ntohl(ia.s_addr);
 | 
			
		||||
 | 
			
		||||
@@ -1694,6 +1719,11 @@ DEFUN(cfg_bts_gprs_rac, cfg_bts_gprs_rac_cmd,
 | 
			
		||||
{
 | 
			
		||||
	struct gsm_bts *bts = vty->index;
 | 
			
		||||
 | 
			
		||||
	if (!bts->gprs.enabled) {
 | 
			
		||||
		vty_out(vty, "%% GPRS not enabled on this BTS%s", VTY_NEWLINE);
 | 
			
		||||
		return CMD_WARNING;
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	bts->gprs.rac = atoi(argv[0]);
 | 
			
		||||
 | 
			
		||||
	return CMD_SUCCESS;
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user