paulmataruso/osmo-mgw
1
0
Fork 0
mirror of https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw.git synced 2025-10-23 08:12:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

sgsn/test: Don't rely on the actual PRNG sequence

Browse Source 
Currently the expected P-TMSI generated by the SGSN is hard-coded
into the test. This adds a dependency on the implementation of rand()
and thus the libc used. This breaks the test e.g. on FreeBSD.

This patch modifies test_gmm_attach() to srand(1) first, generate the
P-TMSI, and finally srand(1) again before starting the test.

Sponsored-by: On-Waves ehf
This commit is contained in:
Jacob Erlbeck
2014-11-24 14:40:28 +01:00
committed by Holger Hans Peter Freyther
parent 59ac49dc1f
commit aec03a1f13
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
openbsc/tests/sgsn/sgsn_test.c
View File

@@ -297,6 +297,7 @@ static void test_gmm_attach(void)
struct gprs_ra_id raid = { 0, };
struct sgsn_mm_ctx *ctx = NULL;
struct sgsn_mm_ctx *ictx;
uint32_t ptmsi1;
uint32_t foreign_tlli;
uint32_t local_tlli = 0;
struct gprs_llc_lle *lle;
@@ -340,6 +341,13 @@ static void test_gmm_attach(void)
/* reset the PRNG used by sgsn_alloc_ptmsi */
srand(1);
ptmsi1 = sgsn_alloc_ptmsi();
OSMO_ASSERT(ptmsi1 != GSM_RESERVED_TMSI);
/* reset the PRNG, so that the same P-TMSI sequence will be generated
* again */
srand(1);
sgsn_acl_add("123456789012345", &sgsn->cfg);
foreign_tlli = gprs_tmsi2tlli(0xc0000023, TLLI_FOREIGN);
@@ -381,7 +389,7 @@ static void test_gmm_attach(void)
OSMO_ASSERT(sgsn_tx_counter == 1);
/* this has been randomly assigned by the SGSN */
local_tlli = gprs_tmsi2tlli(0xeb8b4567, TLLI_LOCAL);
local_tlli = gprs_tmsi2tlli(ptmsi1, TLLI_LOCAL);
/* inject the attach complete */
send_0408_message(ctx->llme, local_tlli,