Update patch set 2

Patch Set 2: (2 comments) Patch-set: 2 Attention: {"person_ident":"Gerrit User 1000276 \u003c1000276@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000276\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000276\u003e replied on the change"}
Create patch set 2
2025-10-23 00:11:59 +00:00 · 2025-10-22 20:38:14 +00:00 · 2025-10-22 20:33:53 +00:00 · 2025-10-22 18:27:47 +00:00 · 2025-10-22 16:22:33 +00:00
1 changed files with 89 additions and 0 deletions
--- a/89
+++ b/89
@@ -1,5 +1,40 @@
 {
  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "a4df052b_0edaea13",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 1
+      },
+      "lineNbr": 9,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2025-10-22T18:27:47Z",
+      "side": 1,
+      "message": "Please adjust the commit message formatting to avoid very long lines: wrap it to about 72 characters or so.",
+      "revId": "063d939744dd201c309059d5d4be13ac0f8c3ce7",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "1b761054_739198b3",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 1
+      },
+      "lineNbr": 9,
+      "author": {
+        "id": 1000276
+      },
+      "writtenOn": "2025-10-22T20:38:14Z",
+      "side": 1,
+      "message": "got it, new commit message in patchset 2",
+      "parentUuid": "a4df052b_0edaea13",
+      "revId": "063d939744dd201c309059d5d4be13ac0f8c3ce7",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
    {
      "unresolved": false,
      "key": {
@@ -33,6 +68,60 @@
      "message": "would someone be as kind as to address the linter complaints, this way we can get a V+1 for this patch, whose absence (V-1) is currently blocking the merge of this patch",
      "revId": "063d939744dd201c309059d5d4be13ac0f8c3ce7",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "6b5d71aa_7e55d8e7",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 1
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000276
+      },
+      "writtenOn": "2025-10-22T16:22:33Z",
+      "side": 1,
+      "message": "should I fix it as the linter is suggesting? The multi-line function call format it\u0027s complaining about is used a couple lines down (Line 126, https://gerrit.osmocom.org/c/osmo-trx/+/41231/1/Transceiver52M/device/usrp1/USRPDevice.cpp#126) so I don\u0027t know if there\u0027s an issue with consistency",
+      "parentUuid": "47282408_079bd539",
+      "revId": "063d939744dd201c309059d5d4be13ac0f8c3ce7",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "5c97b1cc_7aecafe6",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 1
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2025-10-22T18:27:47Z",
+      "side": 1,
+      "message": "You\u0027re changing the existing code, which is not properly formatted in the first place.\nSo I believe we can bypass the linter here. I can do that when the commit message is fixed.",
+      "parentUuid": "6b5d71aa_7e55d8e7",
+      "revId": "063d939744dd201c309059d5d4be13ac0f8c3ce7",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "65472603_94340dfd",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 1
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000276
+      },
+      "writtenOn": "2025-10-22T20:38:14Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "5c97b1cc_7aecafe6",
+      "revId": "063d939744dd201c309059d5d4be13ac0f8c3ce7",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
 }
Author	SHA1	Message	Date
Gerrit User 1000276	fed39a2c7b	Update patch set 2 Patch Set 2: (2 comments) Patch-set: 2 Attention: {"person_ident":"Gerrit User 1000276 \u003c1000276@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000276\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000276\u003e replied on the change"}	2025-10-22 20:38:14 +00:00
Gerrit User 1000276	fad53f3b74	Create patch set 2 Uploaded patch set 2: Commit message was updated. Copied Votes: * Verified-1 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE") Outdated Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN") Patch-set: 2 Subject: trx: Fix tx/rx-sps 4 for USRP1 devices Commit: `33445944de` Tag: autogenerated:gerrit:newPatchSet Groups: `33445944de` Copied-Label: Verified=-1, 918ae691c35dd883520c93e201ac0c78042cf1ec Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>:"jenkins" Attention: {"person_ident":"Gerrit User 1000161 \u003c1000161@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"} Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"}	2025-10-22 20:33:53 +00:00
Gerrit User 1000010	b83815a78e	Update patch set 1 Patch Set 1: (2 comments) Patch-set: 1 CC: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326> Attention: {"person_ident":"Gerrit User 1000276 \u003c1000276@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}	2025-10-22 18:27:47 +00:00
Gerrit User 1000276	a4d2513b41	Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1000276 \u003c1000276@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000276\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000276\u003e replied on the change"}	2025-10-22 16:22:33 +00:00