paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-03 05:23:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

typescript: Implement some TODOs.

Browse Source
This commit is contained in:
Manav Mehta
2020-02-29 14:49:32 +05:30
committed by Anders Kaseorg
parent 340797ca10
commit 20c6f487c4
5 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/renderer/js/components/handle-external-link.ts
View File

@@ -3,13 +3,13 @@ import { ipcRenderer, remote } from 'electron';
import LinkUtil = require('../utils/link-util');
import DomainUtil = require('../utils/domain-util');
import ConfigUtil = require('../utils/config-util');
import type WebView from './webview';
const { shell, app } = remote;
const dingSound = new Audio('../resources/sounds/ding.ogg');
// TODO: TypeScript - Figure out a way to pass correct type here.
function handleExternalLink(this: any, event: any): void {
function handleExternalLink(this: WebView, event: Electron.NewWindowEvent): void {
const { url } = event;
const domainPrefix = DomainUtil.getDomain(this.props.index).url;
const downloadPath = ConfigUtil.getConfigItem('downloadsPath', `${app.getPath('downloads')}`);

4
app/renderer/js/notification/helpers.ts
View File

@@ -80,9 +80,7 @@ const webContentsId = webContents.id;
// this function will focus the server that sent
// the notification. Main function implemented in main.js
export function focusCurrentServer(): void {
// TODO: TypeScript: currentWindow of type BrowserWindow doesn't
// have a .send() property per typescript.
(currentWindow as any).send('focus-webview-with-id', webContentsId);
currentWindow.webContents.send('focus-webview-with-id', webContentsId);
}
// this function parses the reply from to notification
// making it easier to reply from notification eg

4
app/renderer/js/pages/preference/general-section.ts
View File

@@ -290,9 +290,7 @@ class GeneralSection extends BaseSection {
const newValue = !ConfigUtil.getConfigItem('silent', true);
ConfigUtil.setConfigItem('silent', newValue);
this.updateSilentOption();
// TODO: TypeScript: currentWindow of type BrowserWindow doesn't
// have a .send() property per typescript.
(currentBrowserWindow as any).send('toggle-silent', newValue);
currentBrowserWindow.webContents.send('toggle-silent', newValue);
}
});
}

2
app/renderer/js/utils/proxy-util.ts
View File

@@ -4,7 +4,7 @@ import url = require('url');
import ConfigUtil = require('./config-util');
interface ProxyRule {
export interface ProxyRule {
hostname?: string;
port?: number;
}

4
app/renderer/js/utils/request-util.ts
View File

@@ -15,11 +15,9 @@ const logger = new Logger({
timestamp: true
});
// TODO: TypeScript - Use ProxyRule for the proxy property
// we can do this now since we use export = ProxyUtil syntax
interface RequestUtilResponse {
ca: string;
proxy: string | void | object;
proxy: string | void | ProxyUtil.ProxyRule;
ecdhCurve: 'auto';
headers: { 'User-Agent': string };
rejectUnauthorized: boolean;