paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-05 14:35:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

main: Turn electron-connect off by default.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2020-05-05 11:50:31 -07:00
committed by Anders Kaseorg
parent e03de26137
commit 22d7ef5615
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/renderer/js/main.ts
View File

@@ -1069,10 +1069,8 @@ class ServerManagerView {
window.addEventListener('load', async () => { window.addEventListener('load', async () => {
// Only start electron-connect (auto reload on change) when its ran // Only start electron-connect (auto reload on change) when its ran
// from `npm run dev` or `gulp dev` and not from `npm start` when // from `npm run dev` or `gulp dev` and not from `npm start`
// app is started `npm start` main process's proces.argv will have if (isDev && remote.getGlobal('process').argv.includes('--electron-connect')) {
// `--no-electron-connect`
if (isDev && !remote.getGlobal('process').argv.includes('--no-electron-connect')) {
require('electron-connect').client.create(); require('electron-connect').client.create();
} }

4
gulpfile.js
View File

@@ -29,7 +29,7 @@ gulp.task('compile', () => {
gulp.task('dev', () => { gulp.task('dev', () => {
// Start browser process // Start browser process
electron.start(); electron.start(['--electron-connect']);
// Restart browser process // Restart browser process
gulp.watch('app/main/*.ts', gulp.series('compile', 'restart:browser')); gulp.watch('app/main/*.ts', gulp.series('compile', 'restart:browser'));
// Reload renderer process // Reload renderer process
@@ -40,7 +40,7 @@ gulp.task('dev', () => {
gulp.task('restart:browser', done => { gulp.task('restart:browser', done => {
electron.stop(); electron.stop();
electron.restart(); electron.restart(['--electron-connect']);
done(); done();
}); });