xo: Fix @typescript-eslint/no-confusing-void-expression.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

app/main/request.ts

@@ -13,7 +13,9 @@ import * as Messages from '../resources/messages';
 export async function fetchResponse(request: ClientRequest): Promise<IncomingMessage> {
 	return new Promise((resolve, reject) => {
 		request.on('response', resolve);
-		request.on('abort', () => reject(new Error('Request aborted')));
+		request.on('abort', () => {
+			reject(new Error('Request aborted'));
+		});
 		request.on('error', reject);
 		request.end();
 	});

app/renderer/js/components/webview.ts

@@ -73,7 +73,9 @@ export default class WebView extends BaseComponent {
 	init(): void {
 		this.$el = this.generateNodeFromHTML(this.templateHTML()) as Electron.WebviewTag;
 		this.domReady = new Promise(resolve => {
-			this.$el.addEventListener('dom-ready', () => resolve(), true);
+			this.$el.addEventListener('dom-ready', () => {
+				resolve();
+			}, true);
 		});
 		this.props.$root.append(this.$el);
 

app/renderer/js/main.ts

@@ -378,7 +378,9 @@ class ServerManagerView {
 
 					this.showLoading(this.loading.has(this.tabs[this.activeTabIndex].webview.props.url));
 				},
-				onNetworkError: (index: number) => this.openNetworkTroubleshooting(index),
+				onNetworkError: (index: number) => {
+					this.openNetworkTroubleshooting(index);
+				},
 				onTitleChange: this.updateBadge.bind(this),
 				nodeIntegration: false,
 				preload: true
@@ -543,7 +545,9 @@ class ServerManagerView {
 
 					this.showLoading(this.loading.has(this.tabs[this.activeTabIndex].webview.props.url));
 				},
-				onNetworkError: (index: number) => this.openNetworkTroubleshooting(index),
+				onNetworkError: (index: number) => {
+					this.openNetworkTroubleshooting(index);
+				},
 				onTitleChange: this.updateBadge.bind(this),
 				nodeIntegration: true,
 				preload: false
@@ -790,16 +794,36 @@ class ServerManagerView {
 
 	registerIpcs(): void {
 		const webviewListeners: Array<[string, (webview: WebView) => void]> = [
-			['webview-reload', webview => webview.reload()],
-			['back', webview => webview.back()],
-			['focus', webview => webview.focus()],
-			['forward', webview => webview.forward()],
-			['zoomIn', webview => webview.zoomIn()],
-			['zoomOut', webview => webview.zoomOut()],
-			['zoomActualSize', webview => webview.zoomActualSize()],
-			['log-out', webview => webview.logOut()],
-			['show-keyboard-shortcuts', webview => webview.showKeyboardShortcuts()],
-			['tab-devtools', webview => webview.openDevTools()]
+			['webview-reload', webview => {
+				webview.reload();
+			}],
+			['back', webview => {
+				webview.back();
+			}],
+			['focus', webview => {
+				webview.focus();
+			}],
+			['forward', webview => {
+				webview.forward();
+			}],
+			['zoomIn', webview => {
+				webview.zoomIn();
+			}],
+			['zoomOut', webview => {
+				webview.zoomOut();
+			}],
+			['zoomActualSize', webview => {
+				webview.zoomActualSize();
+			}],
+			['log-out', webview => {
+				webview.logOut();
+			}],
+			['show-keyboard-shortcuts', webview => {
+				webview.showKeyboardShortcuts();
+			}],
+			['tab-devtools', webview => {
+				webview.openDevTools();
+			}]
 		];
 
 		for (const [channel, listener] of webviewListeners) {

app/renderer/js/notification/index.ts

@@ -43,7 +43,9 @@ export function newNotification(
 	}
 
 	return {
-		close: () => notification.close(),
+		close: () => {
+			notification.close();
+		},
 		title: notification.title,
 		dir: notification.dir,
 		lang: notification.lang,

app/renderer/js/pages/preference/general-section.ts

@@ -495,7 +495,9 @@ export default class GeneralSection extends BaseSection {
 		});
 		if (response === 0) {
 			await fs.promises.rmdir(getAppPath, {recursive: true});
-			setTimeout(() => ipcRenderer.send('clear-app-settings'), 1000);
+			setTimeout(() => {
+				ipcRenderer.send('clear-app-settings');
+			}, 1000);
 		}
 	}
 

app/renderer/js/pages/preference/new-server-form.ts

@@ -95,7 +95,9 @@ export default class NewServerForm extends BaseComponent {
 
 	networkSettingsLink(): void {
 		const networkSettingsId = document.querySelectorAll('.server-network-option')[0];
-		networkSettingsId.addEventListener('click', () => ipcRenderer.send('forward-message', 'open-network-settings'));
+		networkSettingsId.addEventListener('click', () => {
+			ipcRenderer.send('forward-message', 'open-network-settings');
+		});
 	}
 
 	initActions(): void {

app/renderer/js/utils/logger-util.ts

@@ -116,7 +116,9 @@ export default class Logger {
 	}
 
 	setupConsoleMethod(type: Level): void {
-		this[type] = (...args: unknown[]) => this._log(type, ...args);
+		this[type] = (...args: unknown[]) => {
+			this._log(type, ...args);
+		};
 	}
 
 	getTimestamp(): string {