Logger: Remove unused options.

All of our loggers have timestamp: true.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-03-31 15:37:22 -07:00
parent 9b550d6e4f
commit cc844e6905
9 changed files with 4 additions and 44 deletions

View File

@@ -12,7 +12,6 @@ const {app, dialog} = process.type === "renderer" ? electron.remote : electron;
const logger = new Logger({
file: "config-util.log",
timestamp: true,
});
let db: JsonDB;

View File

@@ -5,7 +5,6 @@ import Logger from "./logger-util";
const logger = new Logger({
file: "enterprise-util.log",
timestamp: true,
});
// TODO: replace enterpriseSettings type with an interface once settings are final

View File

@@ -9,10 +9,7 @@ import {sentryInit, captureException} from "./sentry-util";
const {app} = process.type === "renderer" ? electron.remote : electron;
interface LoggerOptions {
timestamp?: true | (() => string);
file?: string;
level?: boolean;
logInDevMode?: boolean;
}
initSetUp();
@@ -41,22 +38,11 @@ type Level = "log" | "debug" | "info" | "warn" | "error";
export default class Logger {
nodeConsole: Console;
timestamp?: () => string;
level: boolean;
logInDevMode: boolean;
constructor(options: LoggerOptions = {}) {
let {
timestamp = true,
file = "console.log",
level = true,
logInDevMode = false,
} = options;
let {file = "console.log"} = options;
file = `${logDir}/${file}`;
if (timestamp === true) {
timestamp = this.getTimestamp;
}
// Trim log according to type of process
if (process.type === "renderer") {
@@ -69,30 +55,12 @@ export default class Logger {
const nodeConsole = new Console(fileStream);
this.nodeConsole = nodeConsole;
this.timestamp = timestamp;
this.level = level;
this.logInDevMode = logInDevMode;
}
_log(type: Level, ...args: unknown[]): void {
const {nodeConsole, timestamp, level, logInDevMode} = this;
switch (true) {
case typeof timestamp === "function":
args.unshift(timestamp() + " |\t");
// Fall through
case level:
args.unshift(type.toUpperCase() + " |");
// Fall through
case !app.isPackaged || logInDevMode:
nodeConsole[type](...args);
break;
default:
}
args.unshift(this.getTimestamp() + " |\t");
args.unshift(type.toUpperCase() + " |");
this.nodeConsole[type](...args);
console[type](...args);
}

View File

@@ -8,7 +8,6 @@ import Logger from "../common/logger-util";
const logger = new Logger({
file: "linux-update-util.log",
timestamp: true,
});
let db: JsonDB;

View File

@@ -11,7 +11,6 @@ import {fetchResponse} from "./request";
const logger = new Logger({
file: "linux-update-util.log",
timestamp: true,
});
export async function linuxUpdateNotification(

View File

@@ -32,7 +32,6 @@ const defaultIconUrl = "../renderer/img/icon.png";
const logger = new Logger({
file: "domain-util.log",
timestamp: true,
});
const generateFilePath = (url: string): string => {

View File

@@ -54,7 +54,6 @@ interface SettingsOptions extends DNDSettings {
const logger = new Logger({
file: "errors.log",
timestamp: true,
});
const rendererDirectory = path.resolve(__dirname, "..");

View File

@@ -13,7 +13,6 @@ const {app, dialog} = remote;
const logger = new Logger({
file: "domain-util.log",
timestamp: true,
});
const defaultIconUrl = "../renderer/img/icon.png";

View File

@@ -8,7 +8,6 @@ import type WebView from "../components/webview";
const logger = new Logger({
file: "domain-util.log",
timestamp: true,
});
export default class ReconnectUtil {