paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-06 23:13:24 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,866 Commits 27 Branches 70 Tags
6676f1c6ac882e67efca827a4d3bd1979726a75d
Commit Graph

62 Commits

Author SHA1 Message Date
Anders Kaseorg
6676f1c6ac WebView: Switch templateHTML to a static method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
fd6cb548f8 WebView: Remove nodeIntegration parameter. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
743b2d6054 WebView: Make preload a string. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
fb5c6b365e css: Simplify webview CSS. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
f092e99f42 css: Remove the melodramatic fade-in animation on load. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
751eb6ef98 Switch electron.remote to @electron/remote. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
84849d2c84 Move functional tab pages out of separate webviews. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:42:04 -08:00
Anders Kaseorg
7fb0cfd176 WebView: Remove redundant name property. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:05:25 -08:00
Anders Kaseorg
5c83952ba1 webview: Remove forceLoad method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:04:29 -08:00
Anders Kaseorg
377f08ad5d Fix unread count parsing from page title. 
Fixes #1157

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-10-27 16:42:46 -07:00
Anders Kaseorg
b35d45955b WebView: Move initialization from dom-ready event to did-attach event. 
This fixes the bug where the context menu would disappear immediately
if the page had been loaded an even number of times.

Fixes #662, fixes #991, fixes #1010.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-10-08 18:10:43 -07:00
Anders Kaseorg
2ecb970da0 Revert "webview: fix focus after soft reload." 
This reverts commit 6b98a49245 (#698).

The bug it worked around was fixed upstream in Electron 9.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-10-08 16:32:10 -07:00
Anders Kaseorg
adcacd7d45 Tighten tab role type. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-07-21 15:46:40 -07:00
Anders Kaseorg
e48c9067a3 Upgrade Prettier to 2.3.2. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-07-05 16:55:47 -07:00
Anders Kaseorg
892f7c8e47 Strongly type config options. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-28 20:29:40 -07:00
Anders Kaseorg
79f9362736 Strongly type IPC messages. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-25 20:44:05 -07:00
Anders Kaseorg
20295ddc50 webview: Use send method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-25 19:57:38 -07:00
Anders Kaseorg
994c412bd2 renderer: Use ipcRenderer.sendTo to communicate with other WebContents. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-25 19:57:38 -07:00
Anders Kaseorg
9a81ade1c8 typescript: Enable strictNullChecks. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-02 15:19:42 -07:00
Anders Kaseorg
07ffb09391 Explode BaseComponent class to a function. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-02 13:10:15 -07:00
Anders Kaseorg
67228d295d Reformat all code with Prettier. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 20:04:00 -07:00
Anders Kaseorg
ce9a680333 Add a tagged template function for HTML supporting HTML interpolation. 
This allows better Prettier integration: Prettier recognizes and
reformats tagged template literals with a tag named ‘html’.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 20:00:49 -07:00
Anders Kaseorg
851bb7904f Move modules shared between main and renderer processes to app/common. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-29 18:01:52 -07:00
Anders Kaseorg
a9f479d60d Enable worldSafeExecuteJavaScript. 
This has no effect on our use of executeJavaScript, and will become
the default in Electron 12, but for now it silences a warning in
development mode.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-08 23:14:00 -08:00
Anders Kaseorg
855d99dfa0 xo: Fix unicorn/prevent-abbreviations. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
cc2424e0bf xo: Fix @typescript-eslint/no-confusing-void-expression. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
79808e8ee9 preload: Provide hooks for server to robustly replace logout et al. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 18:11:45 -08:00
Anders Kaseorg
047bf0ca45 webview: Pass webPreferences values as explicit booleans 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-11-30 12:39:35 -08:00
Anders Kaseorg
a9d59b3dcd CVE-2020-24582: Escape all strings interpolated into HTML. 
Also fix various variable names to consistently indicate which strings
contain HTML.

Some of these changes close cross-site scripting vulnerabilities, and
others are for consistency.  It’s important to be meticulously
consistent about escaping so that changes that would introduce
vulnerabilities stand out as obviously wrong.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-04 22:52:38 -07:00
Anders Kaseorg
8d66f05924 xo: Sort imports with import/order. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-23 23:06:41 -07:00
Manav Mehta
e97ab2e6dd Replace deprecated getWebContents API 2020-06-30 20:33:41 -07:00
Manav Mehta
0fff6336c7 spellchecker: Use Electron 8 built-in spellchecker. 
* Using electron built-in spellchecker
* Added the custom context menu

Co-authored-by: Anders Kaseorg <anders@zulipchat.com>

Fixes: #504
 2020-06-18 18:14:23 +05:30
Anders Kaseorg
d661895545 Remove the insecure ignoreCerts option. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-13 04:06:50 -07:00
Anders Kaseorg
983254c310 CVE-2020-12637: Do not ignore certificate errors without ignoreCerts. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-05 12:54:35 -07:00
Anders Kaseorg
34e2b3a3d0 typescript: Eradicate most any annotations. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-04 01:08:05 -07:00
Anders Kaseorg
6b7cce0366 ServerManagerView: Convert loading from object to Set. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-03 19:16:05 -07:00
Anders Kaseorg
73fec72e6d registerIpcs: Convert webviewListeners to array with functions. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-03 19:09:22 -07:00
Anders Kaseorg
ba191c3699 xo: Enable object-curly-spacing. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
e49a880ed6 xo: Enable capitalized-comments. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
39c6fa4ace xo: Enable @typescript-eslint/member-ordering. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
5ae2a717fa xo: Enable padding-line-between-statements. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
bb88a7b7a8 xo: Handle floating promises. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
2154b191c8 typescript: Annotate url in WebviewProps. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Manav Mehta
16f0af8853 Remove storing of User-Agent on disk. 
Fixes: #921.

Co-authored-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-26 13:30:39 -07:00
am2505
bb6d90671f typescript: Complete most TypeScript todos. 2020-04-25 15:49:10 -07:00
Anders Kaseorg
92fb176f67 Revert "auth: Move social login process to browser." 
This reverts commit 49b29bfed6 (#863).

The design of this feature is still under discussion; we expect it to
return after the security release.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
9d4093b3d8 CVE-2020-10856: Enable context isolation. 
This fixes a vulnerability reported by Matt Austin.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
20a6c5d128 preload: Use IPC for logout, shortcut, showNotificationSettings. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Tim Abbott
5c164bfa7d webview: Disable insecure content. 
Zulip servers in production are designed to only serve content over
HTTPS.  And a development environment's root page will be served over
HTTP.

So there is no purpose in enabling allowInsecureContent, even
conditionally for use against Zulip development environments; we should
just remove the setting.
 2020-03-30 19:32:23 -07:00
Anders Kaseorg
611932c66d xo: Unabbreviate variable names. 
To satisfy unicorn/prevent-abbreviations in xo 0.28.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-23 16:53:12 -07:00