paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-18 12:43:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,748 Commits 27 Branches 70 Tags
7b3d40ca1eddf8768bac9c42c3adb256aaf409c4
Commit Graph

227 Commits

Author SHA1 Message Date
Anders Kaseorg
7b3d40ca1e Explode FindAccounts class to a function. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-02 14:25:41 -07:00
Anders Kaseorg
ea2d84e810 Explode BaseSection class to functions. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-02 14:14:48 -07:00
Anders Kaseorg
07ffb09391 Explode BaseComponent class to a function. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-02 13:10:15 -07:00
Anders Kaseorg
54f02c9616 PreferenceView: Lift init() calls into switch. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-01 18:45:55 -07:00
Anders Kaseorg
eeade47eb6 nav: Add NavItem literal type. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-01 18:45:55 -07:00
Anders Kaseorg
b07995c3ed Simplify querySelectorAll(…)[0] to querySelector(…). 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-01 14:06:43 -07:00
Anders Kaseorg
67228d295d Reformat all code with Prettier. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 20:04:00 -07:00
Anders Kaseorg
ce9a680333 Add a tagged template function for HTML supporting HTML interpolation. 
This allows better Prettier integration: Prettier recognizes and
reformats tagged template literals with a tag named ‘html’.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 20:00:49 -07:00
Anders Kaseorg
851bb7904f Move modules shared between main and renderer processes to app/common. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-29 18:01:52 -07:00
Anders Kaseorg
76d321fa79 xo: Enable @typescript-eslint/consistent-type-imports. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-29 17:48:54 -07:00
Anders Kaseorg
75da0a16c1 xo: Fix unicorn/no-array-for-each. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-08 23:13:36 -08:00
tarun8718
07ae127cc8 shortcuts-section: Deduplicate templateMacHTML and templateWinLinHTML. 
Signed-off-by: tarun8718 <tarunkumar8718@gmail.com>
 2021-02-02 10:49:35 -08:00
Anders Kaseorg
7d6c6bc10a xo: Fix unicorn/prefer-number-properties. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
cc2424e0bf xo: Fix @typescript-eslint/no-confusing-void-expression. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
2e90e24552 Remove fs-extra dependency. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-17 17:20:32 -08:00
aryanshridhar
cd77fc6448 new-server-form: Strip whitespace from added organization URL. 
Fixes #1037.
 2020-11-15 19:56:53 -08:00
Anders Kaseorg
da91dc5595 xo: Fix @typescript-eslint/consistent-indexed-object-style. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
d5a9063378 typescript: Fix implicit any in catch clauses. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-24 15:47:13 -07:00
Anders Kaseorg
23e86abb5b Remove support for custom certificate exceptions. 
Version 5.4.0 and later uses electron.net for all network
requests (#993), so custom certificates can now be configured in the
same system certificate store that Chrome uses.

https://zulip.com/help/custom-certificates#desktop

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-11 22:25:28 -07:00
Anders Kaseorg
97f8fe71af Escape all strings inserted into CSS selectors. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-04 22:52:42 -07:00
Anders Kaseorg
a9d59b3dcd CVE-2020-24582: Escape all strings interpolated into HTML. 
Also fix various variable names to consistently indicate which strings
contain HTML.

Some of these changes close cross-site scripting vulnerabilities, and
others are for consistency.  It’s important to be meticulously
consistent about escaping so that changes that would introduce
vulnerabilities stand out as obviously wrong.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-04 22:52:38 -07:00
Anders Kaseorg
c302ebe282 general-section: Convert .filter(…)[0] to .find(…). 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-08-25 15:40:40 -07:00
Anders Kaseorg
69141b5395 Remove spurious 'use-strict' [sic] directives. 
The directive is 'use strict'.  It’s not necessary in TypeScript.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-23 23:09:12 -07:00
Anders Kaseorg
8d66f05924 xo: Sort imports with import/order. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-23 23:06:41 -07:00
Manav Mehta
0fff6336c7 spellchecker: Use Electron 8 built-in spellchecker. 
* Using electron built-in spellchecker
* Added the custom context menu

Co-authored-by: Anders Kaseorg <anders@zulipchat.com>

Fixes: #504
 2020-06-18 18:14:23 +05:30
Anders Kaseorg
5d775405d9 Update zulipchat.com links to zulip.com. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-08 14:01:40 -07:00
Manav Mehta
a5ceffc856 transifex: Setup Transifex for better translation process. 2020-05-20 22:11:13 +05:30
Manav Mehta
f55570f2f5 Handle Reset options gracefully. 
Fixes: #903.
 2020-05-20 21:54:36 +05:30
Manav Mehta
109a9bbd10 document: Remove inessential comment inherited from #902 and #909 
The comment was created to document a piece of code in #902 but #909 addressed code quality
The comment is no longer essential and hence ought to be removed
 2020-05-06 17:01:47 -07:00
Anders Kaseorg
cafff9a008 new-server-form: Add missing string conversion for error message. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-05 12:54:35 -07:00
Anders Kaseorg
34e2b3a3d0 typescript: Eradicate most any annotations. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-05-04 01:08:05 -07:00
Anders Kaseorg
ba191c3699 xo: Enable object-curly-spacing. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
e49a880ed6 xo: Enable capitalized-comments. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
4bfa7c9265 xo: Enable no-else-return. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
849df4adaf xo: Enable @typescript-eslint/restrict-template-expressions. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
fc6ff83485 xo: Enable no-alert. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
5ae2a717fa xo: Enable padding-line-between-statements. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
cfdc08a038 xo: Enable unicorn/catch-error-name. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
Anders Kaseorg
bb88a7b7a8 xo: Handle floating promises. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-30 13:48:18 -07:00
am2505
bb6d90671f typescript: Complete most TypeScript todos. 2020-04-25 15:49:10 -07:00
Anders Kaseorg
ae689ad6bb general-section: Import supported-locales.json as a JSON module. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-22 13:06:00 -07:00
Anders Kaseorg
7ffddded5d Configure language by value, not by index. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-22 13:05:59 -07:00
Anders Kaseorg
714cd926ae generateSelectTemplate: Add missing HTML escaping. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-04-22 13:05:15 -07:00
Manav Mehta
b2f4af0f49 Add feature to set application language. 
User can now select application language without changing the language in the operating system.

Fixes: #855.
 2020-04-22 18:08:49 +05:30
Anders Kaseorg
92fb176f67 Revert "auth: Move social login process to browser." 
This reverts commit 49b29bfed6 (#863).

The design of this feature is still under discussion; we expect it to
return after the security release.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
a03f569af9 CVE-2020-10857: Whitelist safe URL protocols for shell.openExternal. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
4390966a62 Always show downloaded files in file manager. 
shell.openItem is unsafe.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-30 19:33:24 -07:00
Anders Kaseorg
611932c66d xo: Unabbreviate variable names. 
To satisfy unicorn/prevent-abbreviations in xo 0.28.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-23 16:53:12 -07:00
Anders Kaseorg
9d2739f050 js: Declare 'use strict' on all scripts and no modules. 
And enable the import/unambiguous ESLint rule as a check on our
partition between scripts and modules.  After this commit, if you add
a new file and get this error:

  ✖  1:1  This module could be parsed as a valid script.  import/unambiguous

* For a module, add an `import` or `export` declaration to make the
  file unambiguously a module (the empty `export {};` declaration
  suffices).
* For a script, add the file to the xo overrides section of
  package.json that marks it "sourceType": "script", and add a 'use
  strict' declaration.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-09 20:04:43 -07:00
Anders Kaseorg
ca5de73155 xo: Reenable several easy rules. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-03-04 20:15:01 -08:00