paulmataruso/zulip-desktop
1
0
Fork 0
mirror of https://github.com/zulip/zulip-desktop.git synced 2025-11-10 08:55:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,906 Commits 27 Branches 70 Tags
e39d2a9b95e5c57b0731202da6e09eb2f6e508bd
Commit Graph

82 Commits

Author SHA1 Message Date
Anders Kaseorg
e39d2a9b95 xo: Fix unicorn/prefer-node-protocol. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-31 21:52:32 -07:00
Anders Kaseorg
3b04b61662 Upgrade dependencies, including Electron 18.0.1. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-31 21:21:21 -07:00
Anders Kaseorg
5edffbdf21 Move handleExternalLink to main process. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-31 21:10:13 -07:00
Anders Kaseorg
5acc45cba4 Use process-specific electron/{main,renderer,common} imports. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-14 21:38:18 -07:00
Anders Kaseorg
0c784b12fa WebView: Enable allowpopups. 
This is required for Electron ≥ 15 to continue invoking our new window
handler (handleExternalLink), following the nativeWindowOpen
migration.

https://github.com/electron/electron/issues/30886

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-11 18:23:39 -08:00
Anders Kaseorg
4151e020f6 Revert "xo: Fix import/extensions." 
This reverts commit 5623ab3866.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 21:58:40 -08:00
Anders Kaseorg
bc59714192 xo: Fix @typescript-eslint/naming-convention. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 21:24:49 -08:00
Anders Kaseorg
5623ab3866 xo: Fix import/extensions. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 21:15:32 -08:00
Anders Kaseorg
1ea7fa813a Remove redundant webPreferences defaults. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 21:15:22 -08:00
Anders Kaseorg
4ed4328bf8 Toggle spell checker in the session rather than the webPreferences. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-08 16:05:54 -08:00
Anders Kaseorg
06eb169c65 WebView: Restrict $el type to HTMLElement. 
The extra methods on WebviewTag are not available from the
context-isolated preload script.
https://github.com/electron/electron/issues/26904

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
2f7529cd71 WebView: Get event parameters via WebContents rather than WebviewTag. 
Works around https://github.com/electron/electron/issues/31924.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
3a8541f601 WebView: Call getWebContentsId in main world. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
76a879e4fd WebView: Convert WebviewTag methods to WebContents methods. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
7026e43575 WebView: Add getWebContents method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
869361bac3 WebView: Type $el as required. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
832ea3c04e WebView: Remove async from send method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
68232f966e WebView: Wait for did-navigate before constructing WebView. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
86b7da45ef WebView: Use a better focus() workaround. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
b853856317 WebView: Add factory function. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
6676f1c6ac WebView: Switch templateHTML to a static method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
fd6cb548f8 WebView: Remove nodeIntegration parameter. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
743b2d6054 WebView: Make preload a string. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
fb5c6b365e css: Simplify webview CSS. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
f092e99f42 css: Remove the melodramatic fade-in animation on load. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
751eb6ef98 Switch electron.remote to @electron/remote. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-03-04 16:56:44 -08:00
Anders Kaseorg
84849d2c84 Move functional tab pages out of separate webviews. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:42:04 -08:00
Anders Kaseorg
7fb0cfd176 WebView: Remove redundant name property. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:05:25 -08:00
Anders Kaseorg
5c83952ba1 webview: Remove forceLoad method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-28 16:04:29 -08:00
Anders Kaseorg
377f08ad5d Fix unread count parsing from page title. 
Fixes #1157

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-10-27 16:42:46 -07:00
Anders Kaseorg
b35d45955b WebView: Move initialization from dom-ready event to did-attach event. 
This fixes the bug where the context menu would disappear immediately
if the page had been loaded an even number of times.

Fixes #662, fixes #991, fixes #1010.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-10-08 18:10:43 -07:00
Anders Kaseorg
2ecb970da0 Revert "webview: fix focus after soft reload." 
This reverts commit 6b98a49245 (#698).

The bug it worked around was fixed upstream in Electron 9.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-10-08 16:32:10 -07:00
Anders Kaseorg
adcacd7d45 Tighten tab role type. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-07-21 15:46:40 -07:00
Anders Kaseorg
e48c9067a3 Upgrade Prettier to 2.3.2. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-07-05 16:55:47 -07:00
Anders Kaseorg
892f7c8e47 Strongly type config options. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-28 20:29:40 -07:00
Anders Kaseorg
79f9362736 Strongly type IPC messages. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-25 20:44:05 -07:00
Anders Kaseorg
20295ddc50 webview: Use send method. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-25 19:57:38 -07:00
Anders Kaseorg
994c412bd2 renderer: Use ipcRenderer.sendTo to communicate with other WebContents. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-25 19:57:38 -07:00
Anders Kaseorg
9a81ade1c8 typescript: Enable strictNullChecks. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-02 15:19:42 -07:00
Anders Kaseorg
07ffb09391 Explode BaseComponent class to a function. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-04-02 13:10:15 -07:00
Anders Kaseorg
67228d295d Reformat all code with Prettier. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 20:04:00 -07:00
Anders Kaseorg
ce9a680333 Add a tagged template function for HTML supporting HTML interpolation. 
This allows better Prettier integration: Prettier recognizes and
reformats tagged template literals with a tag named ‘html’.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-31 20:00:49 -07:00
Anders Kaseorg
851bb7904f Move modules shared between main and renderer processes to app/common. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-29 18:01:52 -07:00
Anders Kaseorg
a9f479d60d Enable worldSafeExecuteJavaScript. 
This has no effect on our use of executeJavaScript, and will become
the default in Electron 12, but for now it silences a warning in
development mode.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-08 23:14:00 -08:00
Anders Kaseorg
855d99dfa0 xo: Fix unicorn/prevent-abbreviations. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
cc2424e0bf xo: Fix @typescript-eslint/no-confusing-void-expression. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 11:23:48 -08:00
Anders Kaseorg
79808e8ee9 preload: Provide hooks for server to robustly replace logout et al. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 18:11:45 -08:00
Anders Kaseorg
047bf0ca45 webview: Pass webPreferences values as explicit booleans 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-11-30 12:39:35 -08:00
Anders Kaseorg
a9d59b3dcd CVE-2020-24582: Escape all strings interpolated into HTML. 
Also fix various variable names to consistently indicate which strings
contain HTML.

Some of these changes close cross-site scripting vulnerabilities, and
others are for consistency.  It’s important to be meticulously
consistent about escaping so that changes that would introduce
vulnerabilities stand out as obviously wrong.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-04 22:52:38 -07:00
Anders Kaseorg
8d66f05924 xo: Sort imports with import/order. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-23 23:06:41 -07:00