Anders Kaseorg
077f3e6e78
eslint: Enable sort-imports for member sorting.
...
This sorts the members imported within each individual declaration; we
use import/order for sorting multiple declarations.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-03 15:07:40 -07:00
Anders Kaseorg
80fe51702b
typescript: Use DefinitelyTyped declarations for @yaireo/tagify.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 18:20:21 -07:00
Anders Kaseorg
9a81ade1c8
typescript: Enable strictNullChecks.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 15:19:42 -07:00
Anders Kaseorg
385ec00640
PreferenceNav: inline init method.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 15:08:40 -07:00
Anders Kaseorg
ae4b3a4778
Explode PreferenceView class to a function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 14:28:52 -07:00
Anders Kaseorg
66bc43674b
Explode ShortcutsSection class to a function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 14:28:11 -07:00
Anders Kaseorg
8f0f82f98e
Explode NetworkSection class to a function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 14:28:09 -07:00
Anders Kaseorg
43f0b4c902
Explode ConnectedOrgSection class to a function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 14:27:47 -07:00
Anders Kaseorg
867bb61e0d
Explode GeneralSection class to a function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 14:26:53 -07:00
Anders Kaseorg
10912fe270
Explode ServersSection class to a function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 14:26:47 -07:00
Anders Kaseorg
76d9c36426
Explode NewServerForm class to a function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 14:26:20 -07:00
Anders Kaseorg
6ca4d77b8f
Explode ServerInfoForm class to a function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 14:25:59 -07:00
Anders Kaseorg
7b3d40ca1e
Explode FindAccounts class to a function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 14:25:41 -07:00
Anders Kaseorg
ea2d84e810
Explode BaseSection class to functions.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 14:14:48 -07:00
Anders Kaseorg
07ffb09391
Explode BaseComponent class to a function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-02 13:10:15 -07:00
Anders Kaseorg
54f02c9616
PreferenceView: Lift init() calls into switch.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-01 18:45:55 -07:00
Anders Kaseorg
eeade47eb6
nav: Add NavItem literal type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-01 18:45:55 -07:00
Anders Kaseorg
b07995c3ed
Simplify querySelectorAll(…)[0] to querySelector(…).
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-04-01 14:06:43 -07:00
Anders Kaseorg
67228d295d
Reformat all code with Prettier.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-31 20:04:00 -07:00
Anders Kaseorg
ce9a680333
Add a tagged template function for HTML supporting HTML interpolation.
...
This allows better Prettier integration: Prettier recognizes and
reformats tagged template literals with a tag named ‘html’.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-31 20:00:49 -07:00
Anders Kaseorg
851bb7904f
Move modules shared between main and renderer processes to app/common.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-29 18:01:52 -07:00
Anders Kaseorg
76d321fa79
xo: Enable @typescript-eslint/consistent-type-imports.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-29 17:48:54 -07:00
Anders Kaseorg
75da0a16c1
xo: Fix unicorn/no-array-for-each.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-03-08 23:13:36 -08:00
tarun8718
07ae127cc8
shortcuts-section: Deduplicate templateMacHTML and templateWinLinHTML.
...
Signed-off-by: tarun8718 <tarunkumar8718@gmail.com >
2021-02-02 10:49:35 -08:00
Anders Kaseorg
7d6c6bc10a
xo: Fix unicorn/prefer-number-properties.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-01-25 11:23:48 -08:00
Anders Kaseorg
cc2424e0bf
xo: Fix @typescript-eslint/no-confusing-void-expression.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2021-01-25 11:23:48 -08:00
Anders Kaseorg
2e90e24552
Remove fs-extra dependency.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-12-17 17:20:32 -08:00
aryanshridhar
cd77fc6448
new-server-form: Strip whitespace from added organization URL.
...
Fixes #1037 .
2020-11-15 19:56:53 -08:00
Anders Kaseorg
da91dc5595
xo: Fix @typescript-eslint/consistent-indexed-object-style.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-10-24 15:47:13 -07:00
Anders Kaseorg
d5a9063378
typescript: Fix implicit any in catch clauses.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-10-24 15:47:13 -07:00
Anders Kaseorg
23e86abb5b
Remove support for custom certificate exceptions.
...
Version 5.4.0 and later uses electron.net for all network
requests (#993 ), so custom certificates can now be configured in the
same system certificate store that Chrome uses.
https://zulip.com/help/custom-certificates#desktop
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-09-11 22:25:28 -07:00
Anders Kaseorg
97f8fe71af
Escape all strings inserted into CSS selectors.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-09-04 22:52:42 -07:00
Anders Kaseorg
a9d59b3dcd
CVE-2020-24582: Escape all strings interpolated into HTML.
...
Also fix various variable names to consistently indicate which strings
contain HTML.
Some of these changes close cross-site scripting vulnerabilities, and
others are for consistency. It’s important to be meticulously
consistent about escaping so that changes that would introduce
vulnerabilities stand out as obviously wrong.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-09-04 22:52:38 -07:00
Anders Kaseorg
c302ebe282
general-section: Convert .filter(…)[0] to .find(…).
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-08-25 15:40:40 -07:00
Anders Kaseorg
69141b5395
Remove spurious 'use-strict' [sic] directives.
...
The directive is 'use strict'. It’s not necessary in TypeScript.
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-07-23 23:09:12 -07:00
Anders Kaseorg
8d66f05924
xo: Sort imports with import/order.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-07-23 23:06:41 -07:00
Manav Mehta
0fff6336c7
spellchecker: Use Electron 8 built-in spellchecker.
...
* Using electron built-in spellchecker
* Added the custom context menu
Co-authored-by: Anders Kaseorg <anders@zulipchat.com >
Fixes : #504
2020-06-18 18:14:23 +05:30
Anders Kaseorg
5d775405d9
Update zulipchat.com links to zulip.com.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-06-08 14:01:40 -07:00
Manav Mehta
a5ceffc856
transifex: Setup Transifex for better translation process.
2020-05-20 22:11:13 +05:30
Manav Mehta
f55570f2f5
Handle Reset options gracefully.
...
Fixes : #903 .
2020-05-20 21:54:36 +05:30
Manav Mehta
109a9bbd10
document: Remove inessential comment inherited from #902 and #909
...
The comment was created to document a piece of code in #902 but #909 addressed code quality
The comment is no longer essential and hence ought to be removed
2020-05-06 17:01:47 -07:00
Anders Kaseorg
cafff9a008
new-server-form: Add missing string conversion for error message.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-05-05 12:54:35 -07:00
Anders Kaseorg
34e2b3a3d0
typescript: Eradicate most any annotations.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com >
2020-05-04 01:08:05 -07:00
Anders Kaseorg
ba191c3699
xo: Enable object-curly-spacing.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-04-30 13:48:18 -07:00
Anders Kaseorg
e49a880ed6
xo: Enable capitalized-comments.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-04-30 13:48:18 -07:00
Anders Kaseorg
4bfa7c9265
xo: Enable no-else-return.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-04-30 13:48:18 -07:00
Anders Kaseorg
849df4adaf
xo: Enable @typescript-eslint/restrict-template-expressions.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-04-30 13:48:18 -07:00
Anders Kaseorg
fc6ff83485
xo: Enable no-alert.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-04-30 13:48:18 -07:00
Anders Kaseorg
5ae2a717fa
xo: Enable padding-line-between-statements.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-04-30 13:48:18 -07:00
Anders Kaseorg
cfdc08a038
xo: Enable unicorn/catch-error-name.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com >
2020-04-30 13:48:18 -07:00