server-name: Unescape server name in window menu item.

Escaping is necessary to avoid any security risk but we need to unescape those strings in order to show them in the frontend otherwise it will have ugly special characters. We already escape server name in the db and unesacoe it in the left-sidebar. This PR adds the decodeString function in order to unescape strings in the menu items. Fixes: #554.
readme: Add tray/dock integration to features.
2025-11-20 14:38:26 +00:00 · 2018-09-03 15:20:02 +05:30 · 2018-09-01 23:15:39 +05:30 · 2018-08-30 21:32:31 +05:30 · 2018-08-30 17:40:42 +05:30 · 2018-08-30 17:38:07 +05:30
4 changed files with 40 additions and 15 deletions
--- a/README.md
+++ b/README.md
@@ -2,31 +2,26 @@
 [![Build Status](https://travis-ci.org/zulip/zulip-electron.svg?branch=master)](https://travis-ci.org/zulip/zulip-electron)
 [![Windows Build Status](https://ci.appveyor.com/api/projects/status/github/zulip/zulip-electron?branch=master&svg=true)](https://ci.appveyor.com/project/akashnimare/zulip-electron/branch/master)
 [![XO code style](https://img.shields.io/badge/code_style-XO-5ed9c7.svg)](https://github.com/sindresorhus/xo)
+[![project chat](https://img.shields.io/badge/zulip-join_chat-brightgreen.svg)](https://chat.zulip.org)

-Desktop client for Zulip. Available for Mac, Linux and Windows.
+Desktop client for Zulip. Available for Mac, Linux, and Windows.

 <img src="http://i.imgur.com/ChzTq4F.png"/>

 # Download
-Please see [installation guide](https://zulipchat.com/help/desktop-app-install-guide).
+Please see the [installation guide](https://zulipchat.com/help/desktop-app-install-guide).

 # Features
 * Sign in to multiple teams
-* Desktop Notifications with inline reply support
-* Multilanguage SpellChecker
-* OSX/Win/Linux installers
-* Automatic Updates (macOS/Windows/Linux)
-* Keyboard shortcuts
-
-# Development
-Please see our [development guide](./development.md) to get started and run app locally.
+* Desktop notifications with inline reply
+* Tray/dock integration
+* Multi-language spell checker
+* Automatic updates

 # Contribute

-If you want to contribute please make sure to read [our documentation about contributing](./CONTRIBUTING.md) first.
-
-* [Issue Tracker](https://github.com/zulip/zulip-electron/issues)
-* [Source Code](https://github.com/zulip/zulip-electron/)
+First, join us on the [Zulip community server](https://zulip.readthedocs.io/en/latest/contributing/chat-zulip-org.html)! 
+Also see our [contribution guidelines](./CONTRIBUTING.md) and our [development guide](./development.md).

 # License
 Released under the [Apache-2.0](./LICENSE) license.
--- a/app/main/index.js
+++ b/app/main/index.js
@@ -217,6 +217,9 @@ app.on('ready', () => {
 			}
 		});
 		pdfWindow.loadURL(url);
+
+		// We don't want to have the menu bar in pdf window
+		pdfWindow.setMenu(null);
 	});

 	// Reload full app not just webview, useful in debugging
--- a/app/renderer/js/main.js
+++ b/app/renderer/js/main.js
@@ -14,6 +14,8 @@ const ConfigUtil = require(__dirname + '/js/utils/config-util.js');
 const DNDUtil = require(__dirname + '/js/utils/dnd-util.js');
 const ReconnectUtil = require(__dirname + '/js/utils/reconnect-util.js');
 const Logger = require(__dirname + '/js/utils/logger-util.js');
+const CommonUtil = require(__dirname + '/js/utils/common-util.js');
+
 const { feedbackHolder } = require(__dirname + '/js/feedback.js');

 const logger = new Logger({
@@ -177,7 +179,7 @@ class ServerManagerView {
 				index,
 				tabIndex,
 				url: server.url,
-				name: server.alias,
+				name: CommonUtil.decodeString(server.alias),
 				isActive: () => {
 					return index === this.activeTabIndex;
 				},
--- a/app/renderer/js/utils/common-util.js
+++ b/app/renderer/js/utils/common-util.js
@@ -0,0 +1,25 @@
+'use strict';
+
+let instance = null;
+
+class CommonUtil {
+	constructor() {
+		if (instance) {
+			return instance;
+		} else {
+			instance = this;
+		}
+		return instance;
+	}
+
+	// unescape already encoded/escaped strings
+	decodeString(string) {
+		const parser = new DOMParser();
+		const dom = parser.parseFromString(
+			'<!doctype html><body>' + string,
+			'text/html');
+		return dom.body.textContent;
+	}
+}
+
+module.exports = new CommonUtil();
Author	SHA1	Message	Date
Akash Nimare	50647e330b	server-name: Unescape server name in window menu item. Escaping is necessary to avoid any security risk but we need to unescape those strings in order to show them in the frontend otherwise it will have ugly special characters. We already escape server name in the db and unesacoe it in the left-sidebar. This PR adds the decodeString function in order to unescape strings in the menu items. Fixes: #554.	2018-09-03 15:20:02 +05:30
Rishi Gupta	73dc3db436	readme: Add tray/dock integration to features.	2018-09-01 23:15:39 +05:30
Akash Nimare	09cf21bf49	pdf-viewer: Hide menubar in pdf window. We don't want to show the menubar in a pdf window so setting it to null.	2018-08-30 21:32:31 +05:30
Akash Nimare	c30d0cc77b	Add Zulip chat badge.	2018-08-30 17:40:42 +05:30
Rishi Gupta	872ad4d3e7	Update README.md.	2018-08-30 17:38:07 +05:30
Akash Nimare	6fd9e1be8b	pdf-viewer: Add a feature to show the pdf files. This adds a feature of showing the pdf attachments in a new window so that a user can quickly view the same. Fixes: #547.	2018-08-29 23:19:38 +05:30