pdf-viewer: Persist webview session.

This passes the partition parameter to the pdf window so that a user don't need to login in order to view the pdf.
pdf-viewer: Show pdf files in a new window.
2025-10-26 01:23:32 +00:00 · 2018-08-29 23:07:36 +05:30 · 2018-08-29 18:28:30 +05:30
4 changed files with 15 additions and 40 deletions
--- a/README.md
+++ b/README.md
@@ -2,26 +2,31 @@
 [![Build Status](https://travis-ci.org/zulip/zulip-electron.svg?branch=master)](https://travis-ci.org/zulip/zulip-electron)
 [![Windows Build Status](https://ci.appveyor.com/api/projects/status/github/zulip/zulip-electron?branch=master&svg=true)](https://ci.appveyor.com/project/akashnimare/zulip-electron/branch/master)
 [![XO code style](https://img.shields.io/badge/code_style-XO-5ed9c7.svg)](https://github.com/sindresorhus/xo)
-[![project chat](https://img.shields.io/badge/zulip-join_chat-brightgreen.svg)](https://chat.zulip.org)

-Desktop client for Zulip. Available for Mac, Linux, and Windows.
+Desktop client for Zulip. Available for Mac, Linux and Windows.

 <img src="http://i.imgur.com/ChzTq4F.png"/>

 # Download
-Please see the [installation guide](https://zulipchat.com/help/desktop-app-install-guide).
+Please see [installation guide](https://zulipchat.com/help/desktop-app-install-guide).

 # Features
 * Sign in to multiple teams
-* Desktop notifications with inline reply
-* Tray/dock integration
-* Multi-language spell checker
-* Automatic updates
+* Desktop Notifications with inline reply support
+* Multilanguage SpellChecker
+* OSX/Win/Linux installers
+* Automatic Updates (macOS/Windows/Linux)
+* Keyboard shortcuts
+
+# Development
+Please see our [development guide](./development.md) to get started and run app locally.

 # Contribute

-First, join us on the [Zulip community server](https://zulip.readthedocs.io/en/latest/contributing/chat-zulip-org.html)! 
-Also see our [contribution guidelines](./CONTRIBUTING.md) and our [development guide](./development.md).
+If you want to contribute please make sure to read [our documentation about contributing](./CONTRIBUTING.md) first.
+
+* [Issue Tracker](https://github.com/zulip/zulip-electron/issues)
+* [Source Code](https://github.com/zulip/zulip-electron/)

 # License
 Released under the [Apache-2.0](./LICENSE) license.
--- a/app/main/index.js
+++ b/app/main/index.js
@@ -217,9 +217,6 @@ app.on('ready', () => {
 			}
 		});
 		pdfWindow.loadURL(url);
-
-		// We don't want to have the menu bar in pdf window
-		pdfWindow.setMenu(null);
 	});

 	// Reload full app not just webview, useful in debugging
--- a/app/renderer/js/main.js
+++ b/app/renderer/js/main.js
@@ -14,8 +14,6 @@ const ConfigUtil = require(__dirname + '/js/utils/config-util.js');
 const DNDUtil = require(__dirname + '/js/utils/dnd-util.js');
 const ReconnectUtil = require(__dirname + '/js/utils/reconnect-util.js');
 const Logger = require(__dirname + '/js/utils/logger-util.js');
-const CommonUtil = require(__dirname + '/js/utils/common-util.js');
-
 const { feedbackHolder } = require(__dirname + '/js/feedback.js');

 const logger = new Logger({
@@ -179,7 +177,7 @@ class ServerManagerView {
 				index,
 				tabIndex,
 				url: server.url,
-				name: CommonUtil.decodeString(server.alias),
+				name: server.alias,
 				isActive: () => {
 					return index === this.activeTabIndex;
 				},
--- a/app/renderer/js/utils/common-util.js
+++ b/app/renderer/js/utils/common-util.js
@@ -1,25 +0,0 @@
-'use strict';
-
-let instance = null;
-
-class CommonUtil {
-	constructor() {
-		if (instance) {
-			return instance;
-		} else {
-			instance = this;
-		}
-		return instance;
-	}
-
-	// unescape already encoded/escaped strings
-	decodeString(string) {
-		const parser = new DOMParser();
-		const dom = parser.parseFromString(
-			'<!doctype html><body>' + string,
-			'text/html');
-		return dom.body.textContent;
-	}
-}
-
-module.exports = new CommonUtil();