mirror of
https://github.com/zulip/zulip-desktop.git
synced 2025-10-23 03:31:56 +00:00
Compare commits
83 Commits
server-pag
...
v2.3.3
Author | SHA1 | Date | |
---|---|---|---|
|
c52bfd6a45 | ||
|
428087110a | ||
|
781883a898 | ||
|
7299cd51e6 | ||
|
a45254cff0 | ||
|
4095c121ba | ||
|
6787b8d557 | ||
|
306e0f3b5e | ||
|
f030d5d56b | ||
|
acf7c5a238 | ||
|
da22f75300 | ||
|
df35ffc3b0 | ||
|
eeb0b4a666 | ||
|
0a893c97c7 | ||
|
99a1711bb0 | ||
|
a27cf9e0e7 | ||
|
22d6c6a2f3 | ||
|
c742591471 | ||
|
339a415d60 | ||
|
f7696cc04d | ||
|
1eabf5c5a2 | ||
|
4d020c639b | ||
|
85a6cf6890 | ||
|
ef1ad820aa | ||
|
10f6d80e5f | ||
|
50ef02c324 | ||
|
deed18d75f | ||
|
0e3c6bceeb | ||
|
c2e138c16a | ||
|
8d1b027b0e | ||
|
7bb8d78973 | ||
|
a7c7791bf8 | ||
|
5d120b4416 | ||
|
ceaf13dee2 | ||
|
f81381dfec | ||
|
dbe89cdd09 | ||
|
14c59bdae1 | ||
|
0ac3e3f6d3 | ||
|
d69c1339e6 | ||
|
fe56a20334 | ||
|
cfc97c9b73 | ||
|
2e70b515da | ||
|
51e414a508 | ||
|
8e7a9bf230 | ||
|
6493ddb8ec | ||
|
31edbe0d67 | ||
|
9980fee785 | ||
|
ff9986ec6b | ||
|
f3423d394c | ||
|
a1da199627 | ||
|
537fbe8f9e | ||
|
3fccb33fca | ||
|
5638590c8b | ||
|
29ed00981d | ||
|
d7638c0b95 | ||
|
7fadbe877b | ||
|
32a21889fb | ||
|
c4a961f9da | ||
|
ceaa898570 | ||
|
73fe17041d | ||
|
9f756cad3e | ||
|
6db6b7c482 | ||
|
09c45e75e8 | ||
|
120b80cf65 | ||
|
22f705960d | ||
|
ca8ce1deaa | ||
|
f70432f4e3 | ||
|
60d693700e | ||
|
6e7333eab6 | ||
|
0d8dd1cd90 | ||
|
0ee3757774 | ||
|
811df9f381 | ||
|
8bd02cc7e4 | ||
|
9d5d221371 | ||
|
6006f1a3f8 | ||
|
4f96df4a34 | ||
|
a13558fa16 | ||
|
a1d19a385c | ||
|
c98667236e | ||
|
b80c3d007b | ||
|
70fb198a0b | ||
|
7276bfeaa7 | ||
|
abd71330ba |
7
.gitignore
vendored
7
.gitignore
vendored
@@ -7,6 +7,13 @@ node_modules/
|
||||
# Compiled binary build directory
|
||||
dist/
|
||||
|
||||
#snap generated files
|
||||
snap/parts
|
||||
snap/prime
|
||||
snap/snap
|
||||
snap/stage
|
||||
snap/*.snap
|
||||
|
||||
# Logs
|
||||
logs
|
||||
*.log
|
||||
|
@@ -15,7 +15,7 @@ addons:
|
||||
|
||||
language: node_js
|
||||
node_js:
|
||||
- '6'
|
||||
- '8'
|
||||
|
||||
before_install:
|
||||
- ./scripts/travis-xvfb.sh
|
||||
|
@@ -12,7 +12,7 @@ Zulip-Desktop app is built on top of [Electron](http://electron.atom.io/). If yo
|
||||
|
||||
* The whole Zulip documentation, such as setting up a development environment, setting up with the Zulip webapp project, and testing, can be read [here](https://zulip.readthedocs.io).
|
||||
|
||||
* If you have any questions regarding zulip-electron, open an [issue](https://github.com/zulip/zulip-electron/issues/new/) or ask it on [chat.zulip.org](https://chat.zulip.org/#narrow/stream/electron).
|
||||
* If you have any questions regarding zulip-electron, open an [issue](https://github.com/zulip/zulip-electron/issues/new/) or ask it on [chat.zulip.org](https://chat.zulip.org/#narrow/stream/16-desktop).
|
||||
|
||||
## Issue
|
||||
Ensure the bug was not already reported by searching on GitHub under [issues](https://github.com/zulip/zulip-electron/issues). If you're unable to find an open issue addressing the bug, open a [new issue](https://github.com/zulip/zulip-electron/issues/new).
|
||||
|
@@ -1,11 +1,11 @@
|
||||
'use strict';
|
||||
const { app, dialog } = require('electron');
|
||||
const { app, dialog, shell } = require('electron');
|
||||
const { autoUpdater } = require('electron-updater');
|
||||
const isDev = require('electron-is-dev');
|
||||
|
||||
const ConfigUtil = require('./../renderer/js/utils/config-util.js');
|
||||
|
||||
function appUpdater() {
|
||||
function appUpdater(updateFromMenu = false) {
|
||||
// Don't initiate auto-updates in development
|
||||
if (isDev) {
|
||||
return;
|
||||
@@ -17,6 +17,8 @@ function appUpdater() {
|
||||
return;
|
||||
}
|
||||
|
||||
let updateAvailable = false;
|
||||
|
||||
// Create Logs directory
|
||||
const LogsDir = `${app.getPath('userData')}/Logs`;
|
||||
|
||||
@@ -28,7 +30,58 @@ function appUpdater() {
|
||||
autoUpdater.logger = log;
|
||||
|
||||
// Handle auto updates for beta/pre releases
|
||||
autoUpdater.allowPrerelease = ConfigUtil.getConfigItem('betaUpdate') || false;
|
||||
const isBetaUpdate = ConfigUtil.getConfigItem('betaUpdate');
|
||||
|
||||
autoUpdater.allowPrerelease = isBetaUpdate || false;
|
||||
|
||||
const eventsListenerRemove = ['update-available', 'update-not-available'];
|
||||
autoUpdater.on('update-available', info => {
|
||||
if (updateFromMenu) {
|
||||
dialog.showMessageBox({
|
||||
message: `A new version ${info.version}, of Zulip Desktop is available`,
|
||||
detail: 'The update will be downloaded in the background. You will be notified when it is ready to be installed.'
|
||||
});
|
||||
|
||||
updateAvailable = true;
|
||||
|
||||
// This is to prevent removal of 'update-downloaded' and 'error' event listener.
|
||||
eventsListenerRemove.forEach(event => {
|
||||
autoUpdater.removeAllListeners(event);
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
autoUpdater.on('update-not-available', () => {
|
||||
if (updateFromMenu) {
|
||||
dialog.showMessageBox({
|
||||
message: 'No updates available',
|
||||
detail: `You are running the latest version of Zulip Desktop.\nVersion: ${app.getVersion()}`
|
||||
});
|
||||
// Remove all autoUpdator listeners so that next time autoUpdator is manually called these
|
||||
// listeners don't trigger multiple times.
|
||||
autoUpdater.removeAllListeners();
|
||||
}
|
||||
});
|
||||
|
||||
autoUpdater.on('error', error => {
|
||||
if (updateFromMenu) {
|
||||
const messageText = (updateAvailable) ? ('Unable to download the updates') : ('Unable to check for updates');
|
||||
dialog.showMessageBox({
|
||||
type: 'error',
|
||||
buttons: ['Manual Download', 'Cancel'],
|
||||
message: messageText,
|
||||
detail: (error).toString() + `\n\nThe latest version of Zulip Desktop is available at -\nhttps://zulipchat.com/apps/.\n
|
||||
Current Version: ${app.getVersion()}`
|
||||
}, response => {
|
||||
if (response === 0) {
|
||||
shell.openExternal('https://zulipchat.com/apps/');
|
||||
}
|
||||
});
|
||||
// Remove all autoUpdator listeners so that next time autoUpdator is manually called these
|
||||
// listeners don't trigger multiple times.
|
||||
autoUpdater.removeAllListeners();
|
||||
}
|
||||
});
|
||||
|
||||
// Ask the user if update is available
|
||||
// eslint-disable-next-line no-unused-vars
|
||||
|
@@ -1,16 +0,0 @@
|
||||
'use strict';
|
||||
|
||||
const { crashReporter } = require('electron');
|
||||
|
||||
const crashHandler = () => {
|
||||
crashReporter.start({
|
||||
productName: 'zulip-electron',
|
||||
companyName: 'Kandra Labs, Inc.',
|
||||
submitURL: 'https://zulip-sentry.herokuapp.com/crashreport',
|
||||
autoSubmit: true
|
||||
});
|
||||
};
|
||||
|
||||
module.exports = {
|
||||
crashHandler
|
||||
};
|
@@ -5,7 +5,6 @@ const windowStateKeeper = require('electron-window-state');
|
||||
const isDev = require('electron-is-dev');
|
||||
const appMenu = require('./menu');
|
||||
const { appUpdater } = require('./autoupdater');
|
||||
const { crashHandler } = require('./crash-reporter');
|
||||
|
||||
const { setAutoLaunch } = require('./startup');
|
||||
|
||||
@@ -13,6 +12,8 @@ const { app, ipcMain } = electron;
|
||||
|
||||
const BadgeSettings = require('./../renderer/js/pages/preference/badge-settings.js');
|
||||
const ConfigUtil = require('./../renderer/js/utils/config-util.js');
|
||||
const ProxyUtil = require('./../renderer/js/utils/proxy-util.js');
|
||||
const { sentryInit } = require('./../renderer/js/utils/sentry-util.js');
|
||||
|
||||
// Adds debug features like hotkeys for triggering dev tools and reload
|
||||
// in development mode
|
||||
@@ -53,7 +54,8 @@ function createMainWindow() {
|
||||
// Load the previous state with fallback to defaults
|
||||
const mainWindowState = windowStateKeeper({
|
||||
defaultWidth: 1100,
|
||||
defaultHeight: 720
|
||||
defaultHeight: 720,
|
||||
path: `${app.getPath('userData')}/config`
|
||||
});
|
||||
|
||||
// Let's keep the window position global so that we can access it in other process
|
||||
@@ -131,6 +133,10 @@ function createMainWindow() {
|
||||
// Decrease load on GPU (experimental)
|
||||
app.disableHardwareAcceleration();
|
||||
|
||||
// Temporary fix for Electron render colors differently
|
||||
// More info here - https://github.com/electron/electron/issues/10732
|
||||
app.commandLine.appendSwitch('force-color-profile', 'srgb');
|
||||
|
||||
// eslint-disable-next-line max-params
|
||||
app.on('certificate-error', (event, webContents, url, error, certificate, callback) => {
|
||||
event.preventDefault();
|
||||
@@ -149,6 +155,15 @@ app.on('ready', () => {
|
||||
});
|
||||
mainWindow = createMainWindow();
|
||||
|
||||
// Initialize sentry for main process
|
||||
sentryInit();
|
||||
|
||||
const isSystemProxy = ConfigUtil.getConfigItem('useSystemProxy');
|
||||
|
||||
if (isSystemProxy) {
|
||||
ProxyUtil.resolveSystemProxy(mainWindow);
|
||||
}
|
||||
|
||||
const page = mainWindow.webContents;
|
||||
|
||||
page.on('dom-ready', () => {
|
||||
@@ -161,8 +176,9 @@ app.on('ready', () => {
|
||||
|
||||
page.once('did-frame-finish-load', () => {
|
||||
// Initate auto-updates on MacOS and Windows
|
||||
appUpdater();
|
||||
crashHandler();
|
||||
if (ConfigUtil.getConfigItem('autoUpdate')) {
|
||||
appUpdater();
|
||||
}
|
||||
});
|
||||
|
||||
// Temporarily remove this event
|
||||
@@ -224,6 +240,17 @@ app.on('ready', () => {
|
||||
ipcMain.on('toggleAutoLauncher', (event, AutoLaunchValue) => {
|
||||
setAutoLaunch(AutoLaunchValue);
|
||||
});
|
||||
|
||||
ipcMain.on('downloadFile', (event, url, downloadPath) => {
|
||||
page.downloadURL(url);
|
||||
page.session.once('will-download', (event, item) => {
|
||||
const filePath = path.join(downloadPath, item.getFilename());
|
||||
item.setSavePath(filePath);
|
||||
item.once('done', () => {
|
||||
page.send('downloadFileCompleted', filePath, item.getFilename());
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
app.on('before-quit', () => {
|
||||
|
@@ -5,6 +5,12 @@ const request = require('request');
|
||||
const semver = require('semver');
|
||||
const ConfigUtil = require('../renderer/js/utils/config-util');
|
||||
const LinuxUpdateUtil = require('../renderer/js/utils/linux-update-util');
|
||||
const Logger = require('../renderer/js/utils/logger-util');
|
||||
|
||||
const logger = new Logger({
|
||||
file: 'linux-update-util.log',
|
||||
timestamp: true
|
||||
});
|
||||
|
||||
function linuxUpdateNotification() {
|
||||
let url = 'https://api.github.com/repos/zulip/zulip-electron/releases';
|
||||
@@ -17,7 +23,8 @@ function linuxUpdateNotification() {
|
||||
|
||||
request(options, (error, response, body) => {
|
||||
if (error) {
|
||||
console.log('Error:', error);
|
||||
logger.error('Linux update error.');
|
||||
logger.error(error);
|
||||
return;
|
||||
}
|
||||
if (response.statusCode < 400) {
|
||||
@@ -32,7 +39,7 @@ function linuxUpdateNotification() {
|
||||
}
|
||||
}
|
||||
} else {
|
||||
console.log('Status:', response.statusCode);
|
||||
logger.log('Linux update response status: ', response.statusCode);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
105
app/main/menu.js
105
app/main/menu.js
@@ -1,15 +1,23 @@
|
||||
'use strict';
|
||||
const os = require('os');
|
||||
const path = require('path');
|
||||
|
||||
const { app, shell, BrowserWindow, Menu } = require('electron');
|
||||
const { app, shell, BrowserWindow, Menu, dialog } = require('electron');
|
||||
|
||||
const fs = require('fs-extra');
|
||||
const AdmZip = require('adm-zip');
|
||||
const { appUpdater } = require('./autoupdater');
|
||||
|
||||
const ConfigUtil = require(__dirname + '/../renderer/js/utils/config-util.js');
|
||||
const DNDUtil = require(__dirname + '/../renderer/js/utils/dnd-util.js');
|
||||
const Logger = require(__dirname + '/../renderer/js/utils/logger-util.js');
|
||||
|
||||
const appName = app.getName();
|
||||
|
||||
const logger = new Logger({
|
||||
file: 'errors.log',
|
||||
timestamp: true
|
||||
});
|
||||
|
||||
class AppMenu {
|
||||
getHistorySubmenu() {
|
||||
return [{
|
||||
@@ -87,7 +95,7 @@ class AppMenu {
|
||||
}
|
||||
}, {
|
||||
label: 'Toggle Sidebar',
|
||||
accelerator: 'CommandOrControl+S',
|
||||
accelerator: 'CommandOrControl+Shift+S',
|
||||
click(item, focusedWindow) {
|
||||
if (focusedWindow) {
|
||||
const newValue = !ConfigUtil.getConfigItem('showSidebar');
|
||||
@@ -134,18 +142,29 @@ class AppMenu {
|
||||
}, {
|
||||
label: 'Show App Logs',
|
||||
click() {
|
||||
shell.openItem(app.getPath('userData'));
|
||||
const zip = new AdmZip();
|
||||
let date = new Date();
|
||||
date = date.toLocaleDateString().replace(/\//g, '-');
|
||||
|
||||
// Create a zip file of all the logs and config data
|
||||
zip.addLocalFolder(`${app.getPath('appData')}/${appName}/Logs`);
|
||||
zip.addLocalFolder(`${app.getPath('appData')}/${appName}/config`);
|
||||
|
||||
// Put the log file in downloads folder
|
||||
const logFilePath = `${app.getPath('downloads')}/Zulip-logs-${date}.zip`;
|
||||
zip.writeZip(logFilePath);
|
||||
|
||||
// Open and select the log file
|
||||
shell.showItemInFolder(logFilePath);
|
||||
}
|
||||
}, {
|
||||
label: 'Report an Issue...',
|
||||
click() {
|
||||
const body = `
|
||||
<!-- Please succinctly describe your issue and steps to reproduce it. -->
|
||||
-
|
||||
${app.getName()} ${app.getVersion()}
|
||||
Electron ${process.versions.electron}
|
||||
${process.platform} ${process.arch} ${os.release()}`;
|
||||
shell.openExternal(`https://github.com/zulip/zulip-electron/issues/new?body=${encodeURIComponent(body)}`);
|
||||
// the goal is to notify the main.html BrowserWindow
|
||||
// which may not be the focused window.
|
||||
BrowserWindow.getAllWindows().forEach(window => {
|
||||
window.webContents.send('open-feedback-modal');
|
||||
});
|
||||
}
|
||||
}];
|
||||
}
|
||||
@@ -197,6 +216,11 @@ class AppMenu {
|
||||
AppMenu.sendAction('open-about');
|
||||
}
|
||||
}
|
||||
}, {
|
||||
label: `Check for Update`,
|
||||
click() {
|
||||
AppMenu.checkForUpdate();
|
||||
}
|
||||
}, {
|
||||
type: 'separator'
|
||||
}, {
|
||||
@@ -217,6 +241,13 @@ class AppMenu {
|
||||
}
|
||||
}, {
|
||||
type: 'separator'
|
||||
}, {
|
||||
label: 'Toggle Do Not Disturb',
|
||||
accelerator: 'Command+Shift+M',
|
||||
click() {
|
||||
const dndUtil = DNDUtil.toggle();
|
||||
AppMenu.sendAction('toggle-dnd', dndUtil.dnd, dndUtil.newSettings);
|
||||
}
|
||||
}, {
|
||||
label: 'Reset App Settings',
|
||||
accelerator: 'Command+Shift+D',
|
||||
@@ -297,6 +328,11 @@ class AppMenu {
|
||||
AppMenu.sendAction('open-about');
|
||||
}
|
||||
}
|
||||
}, {
|
||||
label: `Check for Update`,
|
||||
click() {
|
||||
AppMenu.checkForUpdate();
|
||||
}
|
||||
}, {
|
||||
type: 'separator'
|
||||
}, {
|
||||
@@ -319,6 +355,13 @@ class AppMenu {
|
||||
}
|
||||
}, {
|
||||
type: 'separator'
|
||||
}, {
|
||||
label: 'Toggle Do Not Disturb',
|
||||
accelerator: 'Ctrl+Shift+M',
|
||||
click() {
|
||||
const dndUtil = DNDUtil.toggle();
|
||||
AppMenu.sendAction('toggle-dnd', dndUtil.dnd, dndUtil.newSettings);
|
||||
}
|
||||
}, {
|
||||
label: 'Reset App Settings',
|
||||
accelerator: 'Ctrl+Shift+D',
|
||||
@@ -387,21 +430,37 @@ class AppMenu {
|
||||
win.webContents.send(action, ...params);
|
||||
}
|
||||
|
||||
static checkForUpdate() {
|
||||
appUpdater(true);
|
||||
}
|
||||
static resetAppSettings() {
|
||||
// We save App's settings/configurations in following files
|
||||
const settingFiles = ['window-state.json', 'domain.json', 'settings.json'];
|
||||
const resetAppSettingsMessage = 'By proceeding you will be removing all connected organizations and preferences from Zulip.';
|
||||
|
||||
settingFiles.forEach(settingFileName => {
|
||||
const getSettingFilesPath = path.join(app.getPath('appData'), appName, settingFileName);
|
||||
fs.access(getSettingFilesPath, error => {
|
||||
if (error) {
|
||||
console.log(error);
|
||||
} else {
|
||||
fs.unlink(getSettingFilesPath, () => {
|
||||
AppMenu.sendAction('clear-app-data');
|
||||
// We save App's settings/configurations in following files
|
||||
const settingFiles = ['config/window-state.json', 'config/domain.json', 'config/settings.json', 'config/certificates.json'];
|
||||
|
||||
dialog.showMessageBox({
|
||||
type: 'warning',
|
||||
buttons: ['YES', 'NO'],
|
||||
defaultId: 0,
|
||||
message: 'Are you sure?',
|
||||
detail: resetAppSettingsMessage
|
||||
}, response => {
|
||||
if (response === 0) {
|
||||
settingFiles.forEach(settingFileName => {
|
||||
const getSettingFilesPath = path.join(app.getPath('appData'), appName, settingFileName);
|
||||
fs.access(getSettingFilesPath, error => {
|
||||
if (error) {
|
||||
logger.error('Error while resetting app settings.');
|
||||
logger.error(error);
|
||||
} else {
|
||||
fs.unlink(getSettingFilesPath, () => {
|
||||
AppMenu.sendAction('clear-app-data');
|
||||
});
|
||||
}
|
||||
});
|
||||
}
|
||||
});
|
||||
});
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
|
1168
app/package-lock.json
generated
1168
app/package-lock.json
generated
File diff suppressed because it is too large
Load Diff
@@ -1,7 +1,7 @@
|
||||
{
|
||||
"name": "zulip",
|
||||
"productName": "Zulip",
|
||||
"version": "1.8.2",
|
||||
"version": "2.3.3",
|
||||
"description": "Zulip Desktop App",
|
||||
"license": "Apache-2.0",
|
||||
"copyright": "Kandra Labs, Inc.",
|
||||
@@ -26,19 +26,23 @@
|
||||
"InstantMessaging"
|
||||
],
|
||||
"dependencies": {
|
||||
"auto-launch": "5.0.1",
|
||||
"@electron-elements/send-feedback": "1.0.7",
|
||||
"@sentry/electron": "0.5.5",
|
||||
"adm-zip": "0.4.11",
|
||||
"auto-launch": "5.0.5",
|
||||
"electron-is-dev": "0.3.0",
|
||||
"electron-log": "2.2.7",
|
||||
"electron-log": "2.2.14",
|
||||
"electron-spellchecker": "1.1.2",
|
||||
"electron-updater": "2.18.2",
|
||||
"electron-updater": "2.23.3",
|
||||
"electron-window-state": "4.1.1",
|
||||
"escape-html": "1.0.3",
|
||||
"is-online": "7.0.0",
|
||||
"node-json-db": "0.7.3",
|
||||
"request": "2.81.0",
|
||||
"request": "2.85.0",
|
||||
"semver": "5.4.1",
|
||||
"wurl": "2.5.0"
|
||||
},
|
||||
"optionalDependencies": {
|
||||
"node-mac-notifier": "0.0.13"
|
||||
"node-mac-notifier": "0.1.0"
|
||||
}
|
||||
}
|
||||
|
@@ -13,9 +13,6 @@ body {
|
||||
#content {
|
||||
display: flex;
|
||||
height: 100%;
|
||||
background: #fff url(../img/ic_loading.gif) no-repeat;
|
||||
background-size: 60px 60px;
|
||||
background-position: center;
|
||||
}
|
||||
|
||||
.toggle-sidebar {
|
||||
@@ -45,6 +42,28 @@ body {
|
||||
transition: all 0.6s ease-out;
|
||||
}
|
||||
|
||||
#view-controls-container {
|
||||
height: calc(100% - 208px);
|
||||
overflow-y: hidden;
|
||||
}
|
||||
|
||||
#view-controls-container:hover {
|
||||
overflow-y: overlay;
|
||||
}
|
||||
|
||||
#view-controls-container::-webkit-scrollbar {
|
||||
width: 4px;
|
||||
}
|
||||
|
||||
#view-controls-container::-webkit-scrollbar-track {
|
||||
box-shadow: inset 0 0 6px rgba(0,0,0,0.3);
|
||||
}
|
||||
|
||||
#view-controls-container::-webkit-scrollbar-thumb {
|
||||
background-color: darkgrey;
|
||||
outline: 1px solid slategrey;
|
||||
}
|
||||
|
||||
@font-face {
|
||||
font-family: 'Material Icons';
|
||||
font-style: normal;
|
||||
@@ -251,6 +270,25 @@ body {
|
||||
width: 100%;
|
||||
}
|
||||
|
||||
/*Pseudo element for loading indicator*/
|
||||
#webviews-container::before {
|
||||
content: "";
|
||||
position: absolute;
|
||||
z-index: 1;
|
||||
background: #fff url(../img/ic_loading.gif) no-repeat;
|
||||
background-size: 60px 60px;
|
||||
background-position: center;
|
||||
width: 100%;
|
||||
height: 100%;
|
||||
}
|
||||
|
||||
/*When the active webview is loaded*/
|
||||
#webviews-container.loaded::before {
|
||||
opacity: 0;
|
||||
z-index: -1;
|
||||
visibility: hidden;
|
||||
}
|
||||
|
||||
webview {
|
||||
/* transition: opacity 0.3s ease-in; */
|
||||
flex-grow: 1;
|
||||
@@ -282,6 +320,7 @@ webview.focus {
|
||||
|
||||
/* Tooltip styling */
|
||||
|
||||
#dnd-tooltip,
|
||||
#back-tooltip,
|
||||
#reload-tooltip,
|
||||
#setting-tooltip {
|
||||
@@ -299,6 +338,7 @@ webview.focus {
|
||||
font-size: 14px;
|
||||
}
|
||||
|
||||
#dnd-tooltip:after,
|
||||
#back-tooltip:after,
|
||||
#reload-tooltip:after,
|
||||
#setting-tooltip:after {
|
||||
@@ -403,3 +443,26 @@ webview.focus {
|
||||
opacity: 1;
|
||||
}
|
||||
}
|
||||
|
||||
send-feedback {
|
||||
width: 60%;
|
||||
height: 85%;
|
||||
}
|
||||
|
||||
#feedback-modal {
|
||||
display: none;
|
||||
position: absolute;
|
||||
top: 0;
|
||||
left: 0;
|
||||
width: 100%;
|
||||
height: 100%;
|
||||
background-color: rgba(68, 67, 67, 0.81);
|
||||
align-items: center;
|
||||
justify-content: center;
|
||||
z-index: 2;
|
||||
transition: all 1s ease-out;
|
||||
}
|
||||
|
||||
#feedback-modal.show {
|
||||
display: flex;
|
||||
}
|
||||
|
@@ -129,6 +129,7 @@ td:nth-child(odd) {
|
||||
content: '';
|
||||
}
|
||||
|
||||
|
||||
/* We don't want to show this in nav item since we have the + button for adding an Organization */
|
||||
|
||||
#nav-AddServer {
|
||||
@@ -198,7 +199,11 @@ img.server-info-icon {
|
||||
|
||||
.server-info-right {
|
||||
margin-top: 4px;
|
||||
min-width: 55%;
|
||||
width: 55%;
|
||||
display: flex;
|
||||
align-items: baseline;
|
||||
justify-content: space-between;
|
||||
flex-grow: 1;
|
||||
}
|
||||
|
||||
.server-info-row {
|
||||
@@ -214,7 +219,9 @@ img.server-info-icon {
|
||||
}
|
||||
|
||||
.server-url {
|
||||
min-width: 60%;
|
||||
overflow: hidden;
|
||||
white-space: nowrap;
|
||||
text-overflow: ellipsis;
|
||||
}
|
||||
|
||||
.server-info-alias {
|
||||
@@ -251,8 +258,8 @@ img.server-info-icon {
|
||||
border: #4EBFAC 2px solid;
|
||||
}
|
||||
|
||||
.setting-block {
|
||||
width: 100%;
|
||||
.manual-proxy-block {
|
||||
width: 96%;
|
||||
}
|
||||
|
||||
.actions-container {
|
||||
@@ -304,7 +311,6 @@ img.server-info-icon {
|
||||
}
|
||||
|
||||
.settings-card:hover {
|
||||
border-left: 8px solid #bcbcbc;
|
||||
box-shadow: 0 2px 5px 0 rgba(0, 0, 0, 0.16), 0 2px 0px 0px rgba(0, 0, 0, 0.12);
|
||||
}
|
||||
|
||||
@@ -319,9 +325,10 @@ img.server-info-icon {
|
||||
border: rgba(239, 83, 80, 0.5) solid 1px;
|
||||
}
|
||||
|
||||
.red:hover{
|
||||
.red:hover {
|
||||
color: #e63431;
|
||||
border: rgba(239, 83, 80, 0.7) solid 1px;;
|
||||
border: rgba(239, 83, 80, 0.7) solid 1px;
|
||||
;
|
||||
}
|
||||
|
||||
.blue {
|
||||
@@ -357,7 +364,8 @@ i.open-tab-button {
|
||||
}
|
||||
|
||||
.reset-data-button,
|
||||
.custom-css-button {
|
||||
.custom-css-button,
|
||||
.download-folder-button {
|
||||
display: inline-block;
|
||||
border: none;
|
||||
padding: 10px;
|
||||
@@ -377,7 +385,8 @@ i.open-tab-button {
|
||||
color: #fff;
|
||||
}
|
||||
|
||||
.selected-css-path {
|
||||
.selected-css-path,
|
||||
.download-folder-path {
|
||||
background: #eeeeee;
|
||||
padding: 10px;
|
||||
margin-top: 10px;
|
||||
@@ -477,6 +486,7 @@ input.toggle-round:checked+label:after {
|
||||
height: 100%;
|
||||
/* background: rgba(61, 64, 67, 15); */
|
||||
background: linear-gradient(35deg, #003b52, #45b59b);
|
||||
overflow: auto;
|
||||
}
|
||||
|
||||
|
||||
@@ -499,15 +509,14 @@ input.toggle-round:checked+label:after {
|
||||
|
||||
.divider {
|
||||
margin-bottom: 30px;
|
||||
margin-right: 10px;
|
||||
margin-top: 30px;
|
||||
color: #7d878a;
|
||||
}
|
||||
|
||||
.divider hr {
|
||||
margin-left: auto;
|
||||
margin-right: auto;
|
||||
width: 45%;
|
||||
margin-left: 8px;
|
||||
margin-right: 8px;
|
||||
width: 44%;
|
||||
}
|
||||
|
||||
.left {
|
||||
@@ -523,31 +532,80 @@ input.toggle-round:checked+label:after {
|
||||
text-align: center;
|
||||
align-items: center;
|
||||
padding-top: 13px;
|
||||
margin-left: -5px;
|
||||
}
|
||||
|
||||
.server-center span {
|
||||
.server-center button {
|
||||
font-weight: bold;
|
||||
font-size: 1.1rem;
|
||||
padding: 10px;
|
||||
margin: auto;
|
||||
align-items: center;
|
||||
text-align: center;
|
||||
}
|
||||
|
||||
.server-center .blue {
|
||||
color: #fff;
|
||||
background: #4EBFAC;
|
||||
border-color: none;
|
||||
border: none;
|
||||
width: 98%;
|
||||
height: 46px;
|
||||
border-radius: 3px;
|
||||
cursor: pointer;
|
||||
}
|
||||
|
||||
.server-center .blue:hover {
|
||||
border-right: 2px solid #309085;
|
||||
border-bottom: 2px solid #309085;
|
||||
.server-center button:hover {
|
||||
background: #329588;
|
||||
}
|
||||
|
||||
.server-center button:focus {
|
||||
background: #329588;
|
||||
}
|
||||
|
||||
.certificates-card {
|
||||
width:70%
|
||||
}
|
||||
|
||||
.certificate-input {
|
||||
width:100%;
|
||||
margin-top: 10px;
|
||||
display:inline-flex;
|
||||
}
|
||||
|
||||
.certificate-input div {
|
||||
align-self:center;
|
||||
}
|
||||
|
||||
.certificate-input .setting-input-value {
|
||||
margin-left:10px;
|
||||
max-width: 100%;
|
||||
}
|
||||
|
||||
#add-certificate-button {
|
||||
width:20%;
|
||||
margin-right:0px;
|
||||
height: 35px;
|
||||
}
|
||||
|
||||
.tip {
|
||||
background-color: hsl(46,63%,95%);
|
||||
border: 1px solid hsl(46,63%,84%);
|
||||
border-radius: 4px;
|
||||
}
|
||||
|
||||
.md-14 {
|
||||
font-size: 14px;
|
||||
vertical-align: middle;
|
||||
padding-right: 6px;
|
||||
}
|
||||
|
||||
#open-hotkeys-link {
|
||||
text-decoration: underline;
|
||||
cursor: pointer;
|
||||
}
|
||||
|
||||
/* responsive grid */
|
||||
|
||||
@media (max-width: 650px) {
|
||||
.selected-css-path {
|
||||
.selected-css-path,
|
||||
.download-folder-path {
|
||||
margin-right: 15px;
|
||||
}
|
||||
#css-delete-action {
|
||||
@@ -564,10 +622,46 @@ input.toggle-round:checked+label:after {
|
||||
padding: 40px;
|
||||
min-width: 300px;
|
||||
}
|
||||
.server-center .blue {
|
||||
margin-right: 1px;
|
||||
.server-center button {
|
||||
margin-right: -12px;
|
||||
width: 100%;
|
||||
}
|
||||
.divider {
|
||||
margin-right: -8px;
|
||||
}
|
||||
.divider hr {
|
||||
margin-left: 6px;
|
||||
margin-right: 6px;
|
||||
width: 43%;
|
||||
}
|
||||
#new-server-container {
|
||||
padding-left: 0px;
|
||||
}
|
||||
}
|
||||
|
||||
@media (max-width: 600px) {
|
||||
.divider {
|
||||
margin-left: 4%;
|
||||
}
|
||||
.divider hr {
|
||||
margin-left: 2px;
|
||||
margin-right: 2px;
|
||||
width: 40%;
|
||||
}
|
||||
}
|
||||
|
||||
@media (max-width: 900px) {
|
||||
.settings-card {
|
||||
flex-direction: column;
|
||||
align-items: center;
|
||||
}
|
||||
|
||||
.server-info-right {
|
||||
flex-direction: column;
|
||||
align-items: center;
|
||||
}
|
||||
|
||||
.action {
|
||||
margin-top: 10px;
|
||||
}
|
||||
}
|
||||
|
54
app/renderer/js/components/handle-external-link.js
Normal file
54
app/renderer/js/components/handle-external-link.js
Normal file
@@ -0,0 +1,54 @@
|
||||
const { ipcRenderer } = require('electron');
|
||||
const { shell, app } = require('electron').remote;
|
||||
const LinkUtil = require('../utils/link-util');
|
||||
const DomainUtil = require('../utils/domain-util');
|
||||
const ConfigUtil = require('../utils/config-util');
|
||||
|
||||
const dingSound = new Audio('../resources/sounds/ding.ogg');
|
||||
|
||||
function handleExternalLink(event) {
|
||||
const { url } = event;
|
||||
const domainPrefix = DomainUtil.getDomain(this.props.index).url;
|
||||
const downloadPath = ConfigUtil.getConfigItem('downloadsPath', `${app.getPath('downloads')}`);
|
||||
// Whitelist URLs which are allowed to be opened in the app
|
||||
const {
|
||||
isInternalUrl: isWhiteListURL,
|
||||
isUploadsUrl: isUploadsURL
|
||||
} = LinkUtil.isInternal(domainPrefix, url);
|
||||
|
||||
if (isWhiteListURL) {
|
||||
event.preventDefault();
|
||||
|
||||
// download txt, pdf, mp3, mp4 etc.. by using downloadURL in the
|
||||
// main process which allows the user to save the files to their desktop
|
||||
// and not trigger webview reload while image in webview will
|
||||
// do nothing and will not save it
|
||||
if (!LinkUtil.isImage(url) && isUploadsURL) {
|
||||
ipcRenderer.send('downloadFile', url, downloadPath);
|
||||
ipcRenderer.once('downloadFileCompleted', (event, filePath, fileName) => {
|
||||
const downloadNotification = new Notification('Download Complete', {
|
||||
body: `Click to open ${fileName}`,
|
||||
silent: true // We'll play our own sound - ding.ogg
|
||||
});
|
||||
|
||||
// Play sound to indicate download complete
|
||||
if (!ConfigUtil.getConfigItem('silent')) {
|
||||
dingSound.play();
|
||||
}
|
||||
|
||||
downloadNotification.onclick = () => {
|
||||
shell.openItem(filePath);
|
||||
};
|
||||
});
|
||||
return;
|
||||
}
|
||||
|
||||
// open internal urls inside the current webview.
|
||||
this.$el.loadURL(url);
|
||||
} else {
|
||||
event.preventDefault();
|
||||
shell.openExternal(url);
|
||||
}
|
||||
}
|
||||
|
||||
module.exports = handleExternalLink;
|
@@ -3,13 +3,12 @@
|
||||
const path = require('path');
|
||||
const fs = require('fs');
|
||||
|
||||
const DomainUtil = require(__dirname + '/../utils/domain-util.js');
|
||||
const ConfigUtil = require(__dirname + '/../utils/config-util.js');
|
||||
const SystemUtil = require(__dirname + '/../utils/system-util.js');
|
||||
const LinkUtil = require(__dirname + '/../utils/link-util.js');
|
||||
const { shell, app, dialog } = require('electron').remote;
|
||||
const { app, dialog } = require('electron').remote;
|
||||
|
||||
const BaseComponent = require(__dirname + '/../components/base.js');
|
||||
const handleExternalLink = require(__dirname + '/../components/handle-external-link.js');
|
||||
|
||||
const shouldSilentWebview = ConfigUtil.getConfigItem('silent');
|
||||
class WebView extends BaseComponent {
|
||||
@@ -19,9 +18,10 @@ class WebView extends BaseComponent {
|
||||
this.props = props;
|
||||
|
||||
this.zoomFactor = 1.0;
|
||||
this.loading = false;
|
||||
this.loading = true;
|
||||
this.badgeCount = 0;
|
||||
this.customCSS = ConfigUtil.getConfigItem('customCSS');
|
||||
this.$webviewsContainer = document.querySelector('#webviews-container').classList;
|
||||
}
|
||||
|
||||
template() {
|
||||
@@ -46,16 +46,7 @@ class WebView extends BaseComponent {
|
||||
|
||||
registerListeners() {
|
||||
this.$el.addEventListener('new-window', event => {
|
||||
const { url } = event;
|
||||
const domainPrefix = DomainUtil.getDomain(this.props.index).url;
|
||||
|
||||
if (LinkUtil.isInternal(domainPrefix, url) || url === (domainPrefix + '/')) {
|
||||
event.preventDefault();
|
||||
this.$el.loadURL(url);
|
||||
} else {
|
||||
event.preventDefault();
|
||||
shell.openExternal(url);
|
||||
}
|
||||
handleExternalLink.call(this, event);
|
||||
});
|
||||
|
||||
if (shouldSilentWebview) {
|
||||
@@ -84,11 +75,16 @@ class WebView extends BaseComponent {
|
||||
|
||||
this.$el.addEventListener('page-favicon-updated', event => {
|
||||
const { favicons } = event;
|
||||
|
||||
// This returns a string of favicons URL. If there is a PM counts in unread messages then the URL would be like
|
||||
// https://chat.zulip.org/static/images/favicon/favicon-pms.png
|
||||
if (favicons[0].indexOf('favicon-pms') > 0 && process.platform === 'darwin') {
|
||||
// This api is only supported on macOS
|
||||
app.dock.setBadge('●');
|
||||
// bounce the dock
|
||||
if (ConfigUtil.getConfigItem('dockBouncing')) {
|
||||
app.dock.bounce();
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
@@ -96,6 +92,7 @@ class WebView extends BaseComponent {
|
||||
if (this.props.role === 'server') {
|
||||
this.$el.classList.add('onload');
|
||||
}
|
||||
this.loading = false;
|
||||
this.show();
|
||||
});
|
||||
|
||||
@@ -129,6 +126,13 @@ class WebView extends BaseComponent {
|
||||
return;
|
||||
}
|
||||
|
||||
// To show or hide the loading indicator in the the active tab
|
||||
if (this.loading) {
|
||||
this.$webviewsContainer.remove('loaded');
|
||||
} else {
|
||||
this.$webviewsContainer.add('loaded');
|
||||
}
|
||||
|
||||
this.$el.classList.remove('disabled');
|
||||
this.$el.classList.add('active');
|
||||
setTimeout(() => {
|
||||
@@ -137,7 +141,6 @@ class WebView extends BaseComponent {
|
||||
}
|
||||
}, 1000);
|
||||
this.focus();
|
||||
this.loading = false;
|
||||
this.props.onTitleChange();
|
||||
// Injecting preload css in webview to override some css rules
|
||||
this.$el.insertCSS(fs.readFileSync(path.join(__dirname, '/../../css/preload.css'), 'utf8'));
|
||||
@@ -230,6 +233,9 @@ class WebView extends BaseComponent {
|
||||
|
||||
reload() {
|
||||
this.hide();
|
||||
// Shows the loading indicator till the webview is reloaded
|
||||
this.$webviewsContainer.remove('loaded');
|
||||
this.loading = true;
|
||||
this.$el.reload();
|
||||
}
|
||||
|
||||
|
62
app/renderer/js/feedback.js
Normal file
62
app/renderer/js/feedback.js
Normal file
@@ -0,0 +1,62 @@
|
||||
const { app } = require('electron').remote;
|
||||
const path = require('path');
|
||||
const fs = require('fs');
|
||||
const SendFeedback = require('@electron-elements/send-feedback');
|
||||
|
||||
// make the button color match zulip app's theme
|
||||
SendFeedback.customStyles = `
|
||||
button:hover, button:focus {
|
||||
border-color: #4EBFAC;
|
||||
color: #4EBFAC;
|
||||
}
|
||||
|
||||
button:active {
|
||||
background-color: #f1f1f1;
|
||||
color: #4EBFAC;
|
||||
}
|
||||
|
||||
button {
|
||||
background-color: #4EBFAC;
|
||||
border-color: #4EBFAC;
|
||||
}
|
||||
`;
|
||||
|
||||
customElements.define('send-feedback', SendFeedback);
|
||||
const sendFeedback = document.querySelector('send-feedback');
|
||||
const feedbackHolder = sendFeedback.parentElement;
|
||||
|
||||
// customize the fields of custom elements
|
||||
sendFeedback.title = 'Report Issue';
|
||||
sendFeedback.titleLabel = 'Issue title:';
|
||||
sendFeedback.titlePlaceholder = 'Enter issue title';
|
||||
sendFeedback.textareaLabel = 'Describe the issue:';
|
||||
sendFeedback.textareaPlaceholder = 'Succinctly describe your issue and steps to reproduce it...';
|
||||
sendFeedback.buttonLabel = 'Report Issue';
|
||||
sendFeedback.loaderSuccessText = '';
|
||||
|
||||
sendFeedback.useReporter('emailReporter', {
|
||||
email: 'akash@zulipchat.com'
|
||||
});
|
||||
|
||||
feedbackHolder.addEventListener('click', e => {
|
||||
// only remove the class if the grey out faded
|
||||
// part is clicked and not the feedback element itself
|
||||
if (e.target === e.currentTarget) {
|
||||
feedbackHolder.classList.remove('show');
|
||||
}
|
||||
});
|
||||
|
||||
sendFeedback.addEventListener('feedback-submitted', () => {
|
||||
setTimeout(() => {
|
||||
feedbackHolder.classList.remove('show');
|
||||
}, 1000);
|
||||
});
|
||||
|
||||
const dataDir = app.getPath('userData');
|
||||
const logsDir = path.join(dataDir, '/Logs');
|
||||
sendFeedback.logs.push(...fs.readdirSync(logsDir).map(file => path.join(logsDir, file)));
|
||||
|
||||
module.exports = {
|
||||
feedbackHolder,
|
||||
sendFeedback
|
||||
};
|
@@ -3,7 +3,7 @@
|
||||
const { ipcRenderer, remote } = require('electron');
|
||||
const isDev = require('electron-is-dev');
|
||||
|
||||
const { session } = remote;
|
||||
const { session, app } = remote;
|
||||
|
||||
require(__dirname + '/js/tray.js');
|
||||
const DomainUtil = require(__dirname + '/js/utils/domain-util.js');
|
||||
@@ -11,7 +11,17 @@ const WebView = require(__dirname + '/js/components/webview.js');
|
||||
const ServerTab = require(__dirname + '/js/components/server-tab.js');
|
||||
const FunctionalTab = require(__dirname + '/js/components/functional-tab.js');
|
||||
const ConfigUtil = require(__dirname + '/js/utils/config-util.js');
|
||||
const DNDUtil = require(__dirname + '/js/utils/dnd-util.js');
|
||||
const ReconnectUtil = require(__dirname + '/js/utils/reconnect-util.js');
|
||||
const Logger = require(__dirname + '/js/utils/logger-util.js');
|
||||
const { feedbackHolder } = require(__dirname + '/js/feedback.js');
|
||||
|
||||
const escape = require('escape-html');
|
||||
|
||||
const logger = new Logger({
|
||||
file: 'errors.log',
|
||||
timestamp: true
|
||||
});
|
||||
|
||||
class ServerManagerView {
|
||||
constructor() {
|
||||
@@ -23,12 +33,14 @@ class ServerManagerView {
|
||||
this.$settingsButton = $actionsContainer.querySelector('#settings-action');
|
||||
this.$webviewsContainer = document.getElementById('webviews-container');
|
||||
this.$backButton = $actionsContainer.querySelector('#back-action');
|
||||
this.$dndButton = $actionsContainer.querySelector('#dnd-action');
|
||||
|
||||
this.$addServerTooltip = document.getElementById('add-server-tooltip');
|
||||
this.$reloadTooltip = $actionsContainer.querySelector('#reload-tooltip');
|
||||
this.$settingsTooltip = $actionsContainer.querySelector('#setting-tooltip');
|
||||
this.$serverIconTooltip = document.getElementsByClassName('server-tooltip');
|
||||
this.$backTooltip = $actionsContainer.querySelector('#back-tooltip');
|
||||
this.$dndTooltip = $actionsContainer.querySelector('#dnd-tooltip');
|
||||
|
||||
this.$sidebar = document.getElementById('sidebar');
|
||||
|
||||
@@ -54,7 +66,17 @@ class ServerManagerView {
|
||||
|
||||
loadProxy() {
|
||||
return new Promise(resolve => {
|
||||
const proxyEnabled = ConfigUtil.getConfigItem('useProxy', false);
|
||||
// To change proxyEnable to useManualProxy in older versions
|
||||
const proxyEnabledOld = ConfigUtil.isConfigItemExists('useProxy');
|
||||
if (proxyEnabledOld) {
|
||||
const proxyEnableOldState = ConfigUtil.getConfigItem('useProxy');
|
||||
if (proxyEnableOldState) {
|
||||
ConfigUtil.setConfigItem('useManualProxy', true);
|
||||
}
|
||||
ConfigUtil.removeConfigItem('useProxy');
|
||||
}
|
||||
|
||||
const proxyEnabled = ConfigUtil.getConfigItem('useManualProxy') || ConfigUtil.getConfigItem('useSystemProxy');
|
||||
if (proxyEnabled) {
|
||||
session.fromPartition('persist:webviewsession').setProxy({
|
||||
pacScript: ConfigUtil.getConfigItem('proxyPAC', ''),
|
||||
@@ -78,16 +100,24 @@ class ServerManagerView {
|
||||
// Default settings which should be respected
|
||||
const settingOptions = {
|
||||
trayIcon: true,
|
||||
useProxy: false,
|
||||
useManualProxy: false,
|
||||
useSystemProxy: false,
|
||||
showSidebar: true,
|
||||
badgeOption: true,
|
||||
startAtLogin: false,
|
||||
startMinimized: false,
|
||||
enableSpellchecker: true,
|
||||
showNotification: true,
|
||||
autoUpdate: true,
|
||||
betaUpdate: false,
|
||||
silent: false,
|
||||
lastActiveTab: 0
|
||||
lastActiveTab: 0,
|
||||
dnd: false,
|
||||
dndPreviousSettings: {
|
||||
showNotification: true,
|
||||
silent: false
|
||||
},
|
||||
downloadsPath: `${app.getPath('downloads')}`
|
||||
};
|
||||
|
||||
// Platform specific settings
|
||||
@@ -95,6 +125,12 @@ class ServerManagerView {
|
||||
if (process.platform === 'win32') {
|
||||
// Only available on Windows
|
||||
settingOptions.flashTaskbarOnMessage = true;
|
||||
settingOptions.dndPreviousSettings.flashTaskbarOnMessage = true;
|
||||
}
|
||||
|
||||
if (process.platform === 'darwin') {
|
||||
// Only available on macOS
|
||||
settingOptions.dockBouncing = true;
|
||||
}
|
||||
|
||||
for (const i in settingOptions) {
|
||||
@@ -155,6 +191,11 @@ class ServerManagerView {
|
||||
}
|
||||
|
||||
initActions() {
|
||||
this.initDNDButton();
|
||||
this.$dndButton.addEventListener('click', () => {
|
||||
const dndUtil = DNDUtil.toggle();
|
||||
ipcRenderer.send('forward-message', 'toggle-dnd', dndUtil.dnd, dndUtil.newSettings);
|
||||
});
|
||||
this.$reloadButton.addEventListener('click', () => {
|
||||
this.tabs[this.activeTabIndex].webview.reload();
|
||||
});
|
||||
@@ -175,10 +216,16 @@ class ServerManagerView {
|
||||
});
|
||||
});
|
||||
|
||||
this.sidebarHoverEvent(this.$addServerButton, this.$addServerTooltip);
|
||||
this.sidebarHoverEvent(this.$addServerButton, this.$addServerTooltip, true);
|
||||
this.sidebarHoverEvent(this.$settingsButton, this.$settingsTooltip);
|
||||
this.sidebarHoverEvent(this.$reloadButton, this.$reloadTooltip);
|
||||
this.sidebarHoverEvent(this.$backButton, this.$backTooltip);
|
||||
this.sidebarHoverEvent(this.$dndButton, this.$dndTooltip);
|
||||
}
|
||||
|
||||
initDNDButton() {
|
||||
const dnd = ConfigUtil.getConfigItem('dnd', false);
|
||||
this.toggleDNDButton(dnd);
|
||||
}
|
||||
|
||||
getTabIndex() {
|
||||
@@ -187,9 +234,17 @@ class ServerManagerView {
|
||||
return currentIndex;
|
||||
}
|
||||
|
||||
sidebarHoverEvent(SidebarButton, SidebarTooltip) {
|
||||
sidebarHoverEvent(SidebarButton, SidebarTooltip, addServer = false) {
|
||||
SidebarButton.addEventListener('mouseover', () => {
|
||||
SidebarTooltip.removeAttribute('style');
|
||||
// To handle position of add server tooltip due to scrolling of list of organizations
|
||||
// This could not be handled using CSS, hence the top of the tooltip is made same
|
||||
// as that of its parent element.
|
||||
// This needs to handled only for the add server tooltip and not others.
|
||||
if (addServer) {
|
||||
const { top } = SidebarButton.getBoundingClientRect();
|
||||
SidebarTooltip.style.top = top + 'px';
|
||||
}
|
||||
});
|
||||
SidebarButton.addEventListener('mouseout', () => {
|
||||
SidebarTooltip.style.display = 'none';
|
||||
@@ -197,8 +252,13 @@ class ServerManagerView {
|
||||
}
|
||||
|
||||
onHover(index, serverName) {
|
||||
this.$serverIconTooltip[index].innerHTML = serverName;
|
||||
this.$serverIconTooltip[index].innerHTML = escape(serverName);
|
||||
this.$serverIconTooltip[index].removeAttribute('style');
|
||||
// To handle position of servers' tooltip due to scrolling of list of organizations
|
||||
// This could not be handled using CSS, hence the top of the tooltip is made same
|
||||
// as that of its parent element.
|
||||
const { top } = this.$serverIconTooltip[index].parentElement.getBoundingClientRect();
|
||||
this.$serverIconTooltip[index].style.top = top + 'px';
|
||||
}
|
||||
|
||||
onHoverOut(index) {
|
||||
@@ -238,6 +298,9 @@ class ServerManagerView {
|
||||
preload: false
|
||||
})
|
||||
}));
|
||||
// To show loading indicator the first time a functional tab is opened, indicator is
|
||||
// closed when the functional tab DOM is ready, handled in webview.js
|
||||
this.$webviewsContainer.classList.remove('loaded');
|
||||
this.activateTab(this.functionalTabs[tabProps.name]);
|
||||
}
|
||||
|
||||
@@ -324,6 +387,15 @@ class ServerManagerView {
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
ipcRenderer.on('toggle-dnd', (event, state, newSettings) => {
|
||||
this.toggleDNDButton(state);
|
||||
ipcRenderer.send('forward-message', 'toggle-silent', newSettings.silent);
|
||||
const selector = 'webview:not([class*=disabled])';
|
||||
const webview = document.querySelector(selector);
|
||||
const webContents = webview.getWebContents();
|
||||
webContents.send('toggle-dnd', state, newSettings);
|
||||
});
|
||||
}
|
||||
|
||||
destroyTab(name, index) {
|
||||
@@ -343,6 +415,9 @@ class ServerManagerView {
|
||||
}
|
||||
|
||||
destroyView() {
|
||||
// Show loading indicator
|
||||
this.$webviewsContainer.classList.remove('loaded');
|
||||
|
||||
// Clear global variables
|
||||
this.activeTabIndex = -1;
|
||||
this.tabs = [];
|
||||
@@ -390,6 +465,12 @@ class ServerManagerView {
|
||||
}
|
||||
}
|
||||
|
||||
// Toggles the dnd button icon.
|
||||
toggleDNDButton(alert) {
|
||||
this.$dndTooltip.textContent = (alert ? 'Turn Off' : 'Enable') + ' Do Not Disturb';
|
||||
this.$dndButton.querySelector('i').textContent = alert ? 'notifications_off' : 'notifications';
|
||||
}
|
||||
|
||||
registerIpcs() {
|
||||
const webviewListeners = {
|
||||
'webview-reload': 'reload',
|
||||
@@ -439,6 +520,7 @@ class ServerManagerView {
|
||||
this.loadProxy().then(() => {
|
||||
if (showAlert) {
|
||||
alert('Proxy settings saved!');
|
||||
ipcRenderer.send('reload-full-app');
|
||||
}
|
||||
});
|
||||
});
|
||||
@@ -496,6 +578,10 @@ class ServerManagerView {
|
||||
}
|
||||
ipcRenderer.send('update-taskbar-icon', createOverlayIcon(messageCount).toDataURL(), String(messageCount));
|
||||
});
|
||||
|
||||
ipcRenderer.on('open-feedback-modal', () => {
|
||||
feedbackHolder.classList.add('show');
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -509,7 +595,7 @@ window.onload = () => {
|
||||
|
||||
window.addEventListener('offline', () => {
|
||||
reconnectUtil.clearState();
|
||||
console.log('No internet connection, you are offline.');
|
||||
logger.log('No internet connection, you are offline.');
|
||||
});
|
||||
|
||||
// only start electron-connect (auto reload on change) when its ran
|
||||
|
@@ -1,4 +1,10 @@
|
||||
const { remote } = require('electron');
|
||||
const Logger = require('../utils/logger-util.js');
|
||||
|
||||
const logger = new Logger({
|
||||
file: 'errors.log',
|
||||
timestamp: true
|
||||
});
|
||||
|
||||
// Do not change this
|
||||
const appId = 'org.zulip.zulip-electron';
|
||||
@@ -28,8 +34,8 @@ function loadBots(sync = false) {
|
||||
botsListLoaded = true;
|
||||
})
|
||||
.fail(error => {
|
||||
console.log('Request failed: ', error.responseText);
|
||||
console.log('Request status: ', error.statusText);
|
||||
logger.log('Load bots request failed: ', error.responseText);
|
||||
logger.log('Load bots request status: ', error.statusText);
|
||||
});
|
||||
if (sync) {
|
||||
$.ajaxSetup({async: true});
|
||||
|
91
app/renderer/js/pages/preference/add-certificate.js
Normal file
91
app/renderer/js/pages/preference/add-certificate.js
Normal file
@@ -0,0 +1,91 @@
|
||||
'use-strict';
|
||||
|
||||
const { dialog } = require('electron').remote;
|
||||
|
||||
const BaseComponent = require(__dirname + '/../../components/base.js');
|
||||
const CertificateUtil = require(__dirname + '/../../utils/certificate-util.js');
|
||||
const DomainUtil = require(__dirname + '/../../utils/domain-util.js');
|
||||
|
||||
class AddCertificate extends BaseComponent {
|
||||
constructor(props) {
|
||||
super();
|
||||
this.props = props;
|
||||
this._certFile = '';
|
||||
}
|
||||
|
||||
template() {
|
||||
return `
|
||||
<div class="settings-card server-center certificates-card">
|
||||
<div class="certificate-input">
|
||||
<div>Organization URL :</div>
|
||||
<input class="setting-input-value" autofocus placeholder="your-organization.zulipchat.com or zulip.your-organization.com"/>
|
||||
</div>
|
||||
<div class="certificate-input">
|
||||
<div>Custom CA's certificate file :</div>
|
||||
<button id="add-certificate-button">Add</button>
|
||||
</div>
|
||||
</div>
|
||||
`;
|
||||
}
|
||||
|
||||
init() {
|
||||
this.$addCertificate = this.generateNodeFromTemplate(this.template());
|
||||
this.props.$root.appendChild(this.$addCertificate);
|
||||
this.addCertificateButton = this.$addCertificate.querySelector('#add-certificate-button');
|
||||
this.serverUrl = this.$addCertificate.querySelectorAll('input.setting-input-value')[0];
|
||||
this.initListeners();
|
||||
}
|
||||
|
||||
validateAndAdd() {
|
||||
const certificate = this._certFile;
|
||||
const serverUrl = this.serverUrl.value;
|
||||
if (certificate !== '' && serverUrl !== '') {
|
||||
const server = encodeURIComponent(DomainUtil.formatUrl(serverUrl));
|
||||
const fileName = certificate.substring(certificate.lastIndexOf('/') + 1);
|
||||
const copy = CertificateUtil.copyCertificate(server, certificate, fileName);
|
||||
if (!copy) {
|
||||
return;
|
||||
}
|
||||
CertificateUtil.setCertificate(server, fileName);
|
||||
dialog.showMessageBox({
|
||||
title: 'Success',
|
||||
message: `Certificate saved!`
|
||||
});
|
||||
this.serverUrl.value = '';
|
||||
} else {
|
||||
dialog.showErrorBox('Error', `Please, ${serverUrl === '' ?
|
||||
'Enter an Organization URL' : 'Choose certificate file'}`);
|
||||
}
|
||||
}
|
||||
|
||||
addHandler() {
|
||||
const showDialogOptions = {
|
||||
title: 'Select file',
|
||||
defaultId: 1,
|
||||
properties: ['openFile'],
|
||||
filters: [{ name: 'crt, pem', extensions: ['crt', 'pem'] }]
|
||||
};
|
||||
dialog.showOpenDialog(showDialogOptions, selectedFile => {
|
||||
if (selectedFile) {
|
||||
this._certFile = selectedFile[0] || '';
|
||||
this.validateAndAdd();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
initListeners() {
|
||||
this.addCertificateButton.addEventListener('click', () => {
|
||||
this.addHandler();
|
||||
});
|
||||
|
||||
this.serverUrl.addEventListener('keypress', event => {
|
||||
const EnterkeyCode = event.keyCode;
|
||||
|
||||
if (EnterkeyCode === 13) {
|
||||
this.addHandler();
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
module.exports = AddCertificate;
|
@@ -3,6 +3,7 @@
|
||||
const BaseSection = require(__dirname + '/base-section.js');
|
||||
const DomainUtil = require(__dirname + '/../../utils/domain-util.js');
|
||||
const ServerInfoForm = require(__dirname + '/server-info-form.js');
|
||||
const AddCertificate = require(__dirname + '/add-certificate.js');
|
||||
|
||||
class ConnectedOrgSection extends BaseSection {
|
||||
constructor(props) {
|
||||
@@ -16,6 +17,9 @@ class ConnectedOrgSection extends BaseSection {
|
||||
<div class="page-title">Connected organizations</div>
|
||||
<div class="title" id="existing-servers">All the connected orgnizations will appear here.</div>
|
||||
<div id="server-info-container"></div>
|
||||
|
||||
<div class="page-title">Add Custom Certificates</div>
|
||||
<div id="add-certificate-container"></div>
|
||||
</div>
|
||||
`;
|
||||
}
|
||||
@@ -44,6 +48,15 @@ class ConnectedOrgSection extends BaseSection {
|
||||
onChange: this.reloadApp
|
||||
}).init();
|
||||
}
|
||||
|
||||
this.$addCertificateContainer = document.getElementById('add-certificate-container');
|
||||
this.initAddCertificate();
|
||||
}
|
||||
|
||||
initAddCertificate() {
|
||||
new AddCertificate({
|
||||
$root: this.$addCertificateContainer
|
||||
}).init();
|
||||
}
|
||||
|
||||
}
|
||||
|
@@ -31,6 +31,10 @@ class GeneralSection extends BaseSection {
|
||||
<div class="setting-description">Show app unread badge</div>
|
||||
<div class="setting-control"></div>
|
||||
</div>
|
||||
<div class="setting-row" id="dock-bounce-option" style= "display:${process.platform === 'darwin' ? '' : 'none'}">
|
||||
<div class="setting-description">Bounce dock on new private message</div>
|
||||
<div class="setting-control"></div>
|
||||
</div>
|
||||
<div class="setting-row" id="flash-taskbar-option" style= "display:${process.platform === 'win32' ? '' : 'none'}">
|
||||
<div class="setting-description">Flash taskbar on new message</div>
|
||||
<div class="setting-control"></div>
|
||||
@@ -48,7 +52,11 @@ class GeneralSection extends BaseSection {
|
||||
</div>
|
||||
</div>
|
||||
<div class="title">App Updates</div>
|
||||
<div class="settings-card">
|
||||
<div class="settings-card">
|
||||
<div class="setting-row" id="autoupdate-option">
|
||||
<div class="setting-description">Enable auto updates</div>
|
||||
<div class="setting-control"></div>
|
||||
</div>
|
||||
<div class="setting-row" id="betaupdate-option">
|
||||
<div class="setting-description">Get beta updates</div>
|
||||
<div class="setting-control"></div>
|
||||
@@ -87,6 +95,20 @@ class GeneralSection extends BaseSection {
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="title">Advanced</div>
|
||||
<div class="settings-card">
|
||||
<div class="setting-row" id="download-folder">
|
||||
<div class="setting-description">
|
||||
Default download location
|
||||
</div>
|
||||
<button class="download-folder-button blue">Choose</button>
|
||||
</div>
|
||||
<div class="setting-row">
|
||||
<div class="setting-description">
|
||||
<div class="download-folder-path">${ConfigUtil.getConfigItem('downloadsPath')}</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="title">Reset Application Data</div>
|
||||
<div class="settings-card">
|
||||
<div class="setting-row" id="resetdata-option">
|
||||
@@ -104,7 +126,8 @@ class GeneralSection extends BaseSection {
|
||||
this.updateTrayOption();
|
||||
this.updateBadgeOption();
|
||||
this.updateSilentOption();
|
||||
this.updateUpdateOption();
|
||||
this.autoUpdateOption();
|
||||
this.betaUpdateOption();
|
||||
this.updateSidebarOption();
|
||||
this.updateStartAtLoginOption();
|
||||
this.updateResetDataOption();
|
||||
@@ -114,12 +137,18 @@ class GeneralSection extends BaseSection {
|
||||
this.addCustomCSS();
|
||||
this.showCustomCSSPath();
|
||||
this.removeCustomCSS();
|
||||
this.downloadFolder();
|
||||
|
||||
// Platform specific settings
|
||||
|
||||
// Flashing taskbar on Windows
|
||||
if (process.platform === 'win32') {
|
||||
this.updateFlashTaskbar();
|
||||
}
|
||||
// Dock bounce on macOS
|
||||
if (process.platform === 'darwin') {
|
||||
this.updateDockBouncing();
|
||||
}
|
||||
}
|
||||
|
||||
updateTrayOption() {
|
||||
@@ -148,6 +177,18 @@ class GeneralSection extends BaseSection {
|
||||
});
|
||||
}
|
||||
|
||||
updateDockBouncing() {
|
||||
this.generateSettingOption({
|
||||
$element: document.querySelector('#dock-bounce-option .setting-control'),
|
||||
value: ConfigUtil.getConfigItem('dockBouncing', true),
|
||||
clickHandler: () => {
|
||||
const newValue = !ConfigUtil.getConfigItem('dockBouncing');
|
||||
ConfigUtil.setConfigItem('dockBouncing', newValue);
|
||||
this.updateDockBouncing();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
updateFlashTaskbar() {
|
||||
this.generateSettingOption({
|
||||
$element: document.querySelector('#flash-taskbar-option .setting-control'),
|
||||
@@ -160,14 +201,26 @@ class GeneralSection extends BaseSection {
|
||||
});
|
||||
}
|
||||
|
||||
updateUpdateOption() {
|
||||
autoUpdateOption() {
|
||||
this.generateSettingOption({
|
||||
$element: document.querySelector('#autoupdate-option .setting-control'),
|
||||
value: ConfigUtil.getConfigItem('autoUpdate', true),
|
||||
clickHandler: () => {
|
||||
const newValue = !ConfigUtil.getConfigItem('autoUpdate');
|
||||
ConfigUtil.setConfigItem('autoUpdate', newValue);
|
||||
this.autoUpdateOption();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
betaUpdateOption() {
|
||||
this.generateSettingOption({
|
||||
$element: document.querySelector('#betaupdate-option .setting-control'),
|
||||
value: ConfigUtil.getConfigItem('betaUpdate', false),
|
||||
clickHandler: () => {
|
||||
const newValue = !ConfigUtil.getConfigItem('betaUpdate');
|
||||
ConfigUtil.setConfigItem('betaUpdate', newValue);
|
||||
this.updateUpdateOption();
|
||||
this.betaUpdateOption();
|
||||
}
|
||||
});
|
||||
}
|
||||
@@ -310,6 +363,28 @@ class GeneralSection extends BaseSection {
|
||||
});
|
||||
}
|
||||
|
||||
downloadFolderDialog() {
|
||||
const showDialogOptions = {
|
||||
title: 'Select Download Location',
|
||||
defaultId: 1,
|
||||
properties: ['openDirectory']
|
||||
};
|
||||
|
||||
dialog.showOpenDialog(showDialogOptions, selectedFolder => {
|
||||
if (selectedFolder) {
|
||||
ConfigUtil.setConfigItem('downloadsPath', selectedFolder[0]);
|
||||
const downloadFolderPath = document.querySelector('.download-folder-path');
|
||||
downloadFolderPath.innerText = selectedFolder[0];
|
||||
}
|
||||
});
|
||||
}
|
||||
downloadFolder() {
|
||||
const downloadFolder = document.querySelector('#download-folder .download-folder-button');
|
||||
downloadFolder.addEventListener('click', () => {
|
||||
this.downloadFolderDialog();
|
||||
});
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
module.exports = GeneralSection;
|
||||
|
@@ -16,11 +16,15 @@ class NetworkSection extends BaseSection {
|
||||
<div class="settings-pane">
|
||||
<div class="title">Proxy</div>
|
||||
<div id="appearance-option-settings" class="settings-card">
|
||||
<div class="setting-row" id="use-proxy-option">
|
||||
<div class="setting-description">Connect servers through a proxy</div>
|
||||
<div class="setting-row" id="use-system-settings">
|
||||
<div class="setting-description">Use system proxy settings (requires restart)</div>
|
||||
<div class="setting-control"></div>
|
||||
</div>
|
||||
<div class="setting-block">
|
||||
<div class="setting-row" id="use-manual-settings">
|
||||
<div class="setting-description">Manual proxy configuration</div>
|
||||
<div class="setting-control"></div>
|
||||
</div>
|
||||
<div class="manual-proxy-block">
|
||||
<div class="setting-row" id="proxy-pac-option">
|
||||
<span class="setting-input-key">PAC script</span>
|
||||
<input class="setting-input-value" placeholder="e.g. foobar.com/pacfile.js"/>
|
||||
@@ -51,7 +55,7 @@ class NetworkSection extends BaseSection {
|
||||
this.$proxyRules = document.querySelector('#proxy-rules-option .setting-input-value');
|
||||
this.$proxyBypass = document.querySelector('#proxy-bypass-option .setting-input-value');
|
||||
this.$proxySaveAction = document.getElementById('proxy-save-action');
|
||||
this.$settingBlock = this.props.$root.querySelector('.setting-block');
|
||||
this.$manualProxyBlock = this.props.$root.querySelector('.manual-proxy-block');
|
||||
this.initProxyOption();
|
||||
|
||||
this.$proxyPAC.value = ConfigUtil.getConfigItem('proxyPAC', '');
|
||||
@@ -68,31 +72,54 @@ class NetworkSection extends BaseSection {
|
||||
}
|
||||
|
||||
initProxyOption() {
|
||||
const proxyEnabled = ConfigUtil.getConfigItem('useProxy', false);
|
||||
this.toggleProxySettings(proxyEnabled);
|
||||
const manualProxyEnabled = ConfigUtil.getConfigItem('useManualProxy', false);
|
||||
this.toggleManualProxySettings(manualProxyEnabled);
|
||||
|
||||
this.updateProxyOption();
|
||||
}
|
||||
|
||||
toggleProxySettings(option) {
|
||||
toggleManualProxySettings(option) {
|
||||
if (option) {
|
||||
this.$settingBlock.classList.remove('hidden');
|
||||
this.$manualProxyBlock.classList.remove('hidden');
|
||||
} else {
|
||||
this.$settingBlock.classList.add('hidden');
|
||||
this.$manualProxyBlock.classList.add('hidden');
|
||||
}
|
||||
}
|
||||
|
||||
updateProxyOption() {
|
||||
this.generateSettingOption({
|
||||
$element: document.querySelector('#use-proxy-option .setting-control'),
|
||||
value: ConfigUtil.getConfigItem('useProxy', false),
|
||||
$element: document.querySelector('#use-system-settings .setting-control'),
|
||||
value: ConfigUtil.getConfigItem('useSystemProxy', false),
|
||||
clickHandler: () => {
|
||||
const newValue = !ConfigUtil.getConfigItem('useProxy');
|
||||
ConfigUtil.setConfigItem('useProxy', newValue);
|
||||
this.toggleProxySettings(newValue);
|
||||
if (newValue === false) {
|
||||
// Reload proxy if the proxy is turned off
|
||||
ipcRenderer.send('forward-message', 'reload-proxy', false);
|
||||
const newValue = !ConfigUtil.getConfigItem('useSystemProxy');
|
||||
const manualProxyValue = ConfigUtil.getConfigItem('useManualProxy');
|
||||
if (manualProxyValue && newValue) {
|
||||
ConfigUtil.setConfigItem('useManualProxy', !manualProxyValue);
|
||||
this.toggleManualProxySettings(!manualProxyValue);
|
||||
}
|
||||
if (newValue === false) {
|
||||
// Remove proxy system proxy settings
|
||||
ConfigUtil.setConfigItem('proxyRules', '');
|
||||
ipcRenderer.send('forward-message', 'reload-proxy', true);
|
||||
}
|
||||
ConfigUtil.setConfigItem('useSystemProxy', newValue);
|
||||
this.updateProxyOption();
|
||||
}
|
||||
});
|
||||
this.generateSettingOption({
|
||||
$element: document.querySelector('#use-manual-settings .setting-control'),
|
||||
value: ConfigUtil.getConfigItem('useManualProxy', false),
|
||||
clickHandler: () => {
|
||||
const newValue = !ConfigUtil.getConfigItem('useManualProxy');
|
||||
const systemProxyValue = ConfigUtil.getConfigItem('useSystemProxy');
|
||||
this.toggleManualProxySettings(newValue);
|
||||
if (systemProxyValue && newValue) {
|
||||
ConfigUtil.setConfigItem('useSystemProxy', !systemProxyValue);
|
||||
}
|
||||
ConfigUtil.setConfigItem('proxyRules', '');
|
||||
ConfigUtil.setConfigItem('useManualProxy', newValue);
|
||||
// Reload app only when turning manual proxy off, hence !newValue
|
||||
ipcRenderer.send('forward-message', 'reload-proxy', !newValue);
|
||||
this.updateProxyOption();
|
||||
}
|
||||
});
|
||||
|
@@ -15,11 +15,11 @@ class NewServerForm extends BaseComponent {
|
||||
<div class="server-input-container">
|
||||
<div class="title">Organization URL</div>
|
||||
<div class="add-server-info-row">
|
||||
<input class="setting-input-value" autofocus placeholder="your-organization.zulipchat.com or chat.your-organization.com"/>
|
||||
<input class="setting-input-value" autofocus placeholder="your-organization.zulipchat.com or zulip.your-organization.com"/>
|
||||
</div>
|
||||
<div class="server-center">
|
||||
<div class="action blue server-save-action">
|
||||
<span id="connect">Connect</span>
|
||||
<div class="server-save-action">
|
||||
<button id="connect">Connect</button>
|
||||
</div>
|
||||
</div>
|
||||
<div class="server-center">
|
||||
@@ -28,8 +28,8 @@ class NewServerForm extends BaseComponent {
|
||||
</div>
|
||||
</div>
|
||||
<div class="server-center">
|
||||
<div class="action blue server-save-action">
|
||||
<span id="open-create-org-link">Create a new organization</span>
|
||||
<div class="server-save-action">
|
||||
<button id="open-create-org-link">Create a new organization</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
@@ -44,7 +44,6 @@ class NewServerForm extends BaseComponent {
|
||||
initForm() {
|
||||
this.$newServerForm = this.generateNodeFromTemplate(this.template());
|
||||
this.$saveServerButton = this.$newServerForm.getElementsByClassName('server-save-action')[0];
|
||||
|
||||
this.props.$root.innerHTML = '';
|
||||
this.props.$root.appendChild(this.$newServerForm);
|
||||
|
||||
@@ -64,7 +63,7 @@ class NewServerForm extends BaseComponent {
|
||||
}
|
||||
|
||||
openCreateNewOrgExternalLink() {
|
||||
const link = 'https://zulipchat.com/beta/';
|
||||
const link = 'https://zulipchat.com/new/';
|
||||
const externalCreateNewOrgEl = document.getElementById('open-create-org-link');
|
||||
externalCreateNewOrgEl.addEventListener('click', () => {
|
||||
shell.openExternal(link);
|
||||
|
@@ -97,6 +97,15 @@ class PreferenceView extends BaseComponent {
|
||||
ipcRenderer.on('toggletray', (event, state) => {
|
||||
this.handleToggle('tray-option', state);
|
||||
});
|
||||
|
||||
ipcRenderer.on('toggle-dnd', (event, state, newSettings) => {
|
||||
this.handleToggle('show-notification-option', newSettings.showNotification);
|
||||
this.handleToggle('silent-option', newSettings.silent);
|
||||
|
||||
if (process.platform === 'win32') {
|
||||
this.handleToggle('flash-taskbar-option', newSettings.flashTaskbarOnMessage);
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
|
@@ -23,7 +23,7 @@ class ServerInfoForm extends BaseComponent {
|
||||
</div>
|
||||
<div class="server-info-right">
|
||||
<div class="server-info-row server-url">
|
||||
<span class="server-url-info">${this.props.server.url}</span>
|
||||
<span class="server-url-info" title="${this.props.server.url}">${this.props.server.url}</span>
|
||||
</div>
|
||||
<div class="server-info-row">
|
||||
<div class="action red server-delete-action">
|
||||
|
@@ -1,6 +1,7 @@
|
||||
'use strict';
|
||||
|
||||
const BaseSection = require(__dirname + '/base-section.js');
|
||||
const shell = require('electron').shell;
|
||||
|
||||
class ShortcutsSection extends BaseSection {
|
||||
constructor(props) {
|
||||
@@ -23,6 +24,10 @@ class ShortcutsSection extends BaseSection {
|
||||
<tr>
|
||||
<td><kbd>${userOSKey}</kbd><kbd>K</kbd></td>
|
||||
<td>Keyboard Shortcuts</td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td><kbd>${userOSKey}</kbd> + <kbd>Shift</kbd> + <kbd>M</kbd></td>
|
||||
<td>Toggle Do Not Disturb</td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td><kbd>Shift</kbd><kbd>${userOSKey}</kbd><kbd>D</kbd></td>
|
||||
@@ -78,14 +83,6 @@ class ShortcutsSection extends BaseSection {
|
||||
<td><kbd>${userOSKey}</kbd><kbd>A</kbd></td>
|
||||
<td>Select All</td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td><kbd>${userOSKey}</kbd><kbd>F</kbd></td>
|
||||
<td>Find</td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td><kbd>${userOSKey}</kbd><kbd>G</kbd></td>
|
||||
<td>Find Next</td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td><kbd>Control</kbd><kbd>${userOSKey}</kbd><kbd>Space</kbd></td>
|
||||
<td>Emoji & Symbols</td>
|
||||
@@ -121,7 +118,7 @@ class ShortcutsSection extends BaseSection {
|
||||
<td>Actual Size</td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td><kbd>${userOSKey}</kbd><kbd>S</kbd></td>
|
||||
<td><kbd>${userOSKey}</kbd> + <kbd>Shift</kbd> + <kbd>S</kbd></td>
|
||||
<td>Toggle Sidebar</td>
|
||||
</tr>
|
||||
<tr>
|
||||
@@ -163,6 +160,7 @@ class ShortcutsSection extends BaseSection {
|
||||
</table>
|
||||
<div class="setting-control"></div>
|
||||
</div>
|
||||
<div class="settings-card tip"><b><i class="material-icons md-14">settings</i>Tip: </b>These desktop app shortcuts extend the Zulip webapp's <span id="open-hotkeys-link">keyboard shortcuts</span>.</div>
|
||||
</div>
|
||||
`;
|
||||
}
|
||||
@@ -182,6 +180,10 @@ class ShortcutsSection extends BaseSection {
|
||||
<tr>
|
||||
<td><kbd>${userOSKey}</kbd> + <kbd>K</kbd></td>
|
||||
<td>Keyboard Shortcuts</td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td><kbd>${userOSKey}</kbd> + <kbd>Shift</kbd> + <kbd>M</kbd></td>
|
||||
<td>Toggle Do Not Disturb</td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td><kbd>${userOSKey}</kbd> + <kbd>L</kbd></td>
|
||||
@@ -256,7 +258,7 @@ class ShortcutsSection extends BaseSection {
|
||||
<td>Actual Size</td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td><kbd>${userOSKey}</kbd> + <kbd>S</kbd></td>
|
||||
<td><kbd>${userOSKey}</kbd> + <kbd>Shift</kbd> + <kbd>S</kbd></td>
|
||||
<td>Toggle Sidebar</td>
|
||||
</tr>
|
||||
<tr>
|
||||
@@ -298,13 +300,22 @@ class ShortcutsSection extends BaseSection {
|
||||
</table>
|
||||
<div class="setting-control"></div>
|
||||
</div>
|
||||
<div class="tip"><b><i class="material-icons md-14">lightbulb_outline</i>Tip: </b>These desktop app shortcuts extend the Zulip webapp's <span id="open-hotkeys-link">keyboard shortcuts</span>.</div>
|
||||
</div>
|
||||
`;
|
||||
}
|
||||
|
||||
openHotkeysExternalLink() {
|
||||
const link = 'https://zulipchat.com/help/keyboard-shortcuts';
|
||||
const externalCreateNewOrgEl = document.getElementById('open-hotkeys-link');
|
||||
externalCreateNewOrgEl.addEventListener('click', () => {
|
||||
shell.openExternal(link);
|
||||
});
|
||||
}
|
||||
init() {
|
||||
this.props.$root.innerHTML = (process.platform === 'darwin') ?
|
||||
this.templateMac() : this.templateWinLin();
|
||||
this.openHotkeysExternalLink();
|
||||
}
|
||||
}
|
||||
|
||||
|
@@ -1,9 +1,10 @@
|
||||
'use strict';
|
||||
|
||||
const { ipcRenderer } = require('electron');
|
||||
const { ipcRenderer, shell } = require('electron');
|
||||
const SetupSpellChecker = require('./spellchecker');
|
||||
|
||||
const ConfigUtil = require(__dirname + '/utils/config-util.js');
|
||||
const LinkUtil = require(__dirname + '/utils/link-util.js');
|
||||
|
||||
// eslint-disable-next-line import/no-unassigned-import
|
||||
require('./notification');
|
||||
@@ -23,7 +24,7 @@ const shortcut = () => {
|
||||
// Create the menu for the below
|
||||
const node = document.querySelector('a[data-overlay-trigger=keyboard-shortcuts]');
|
||||
// Additional check
|
||||
if (node.text.trim().toLowerCase() === 'keyboard shortcuts') {
|
||||
if (node.text.trim().toLowerCase() === 'keyboard shortcuts (?)') {
|
||||
node.click();
|
||||
} else {
|
||||
// Atleast click the dropdown
|
||||
@@ -55,6 +56,29 @@ document.addEventListener('DOMContentLoaded', () => {
|
||||
ipcRenderer.send('forward-message', 'reload-viewer');
|
||||
});
|
||||
}
|
||||
|
||||
// Open image attachment link in the lightbox instead of opening in the default browser
|
||||
const { $, lightbox } = window;
|
||||
|
||||
$('#main_div').on('click', '.message_content p a', function (e) {
|
||||
const url = $(this).attr('href');
|
||||
|
||||
if (LinkUtil.isImage(url)) {
|
||||
const $img = $(this).parent().siblings('.message_inline_image').find('img');
|
||||
|
||||
// prevent the image link from opening in a new page.
|
||||
e.preventDefault();
|
||||
// prevent the message compose dialog from happening.
|
||||
e.stopPropagation();
|
||||
|
||||
// Open image in the default browser if image preview is unavailable
|
||||
if (!$img[0]) {
|
||||
shell.openExternal(window.location.origin + url);
|
||||
}
|
||||
// Open image in lightbox
|
||||
lightbox.open($img);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
// Clean up spellchecker events after you navigate away from this page;
|
||||
@@ -63,3 +87,10 @@ window.addEventListener('beforeunload', () => {
|
||||
SetupSpellChecker.unsubscribeSpellChecker();
|
||||
});
|
||||
|
||||
// electron's globalShortcut can cause unexpected results
|
||||
// so adding the reload shortcut in the old-school way
|
||||
document.addEventListener('keydown', event => {
|
||||
if (event.code === 'F5') {
|
||||
ipcRenderer.send('forward-message', 'hard-reload');
|
||||
}
|
||||
});
|
||||
|
@@ -3,6 +3,12 @@
|
||||
const { SpellCheckHandler, ContextMenuListener, ContextMenuBuilder } = require('electron-spellchecker');
|
||||
|
||||
const ConfigUtil = require(__dirname + '/utils/config-util.js');
|
||||
const Logger = require(__dirname + '/utils/logger-util.js');
|
||||
|
||||
const logger = new Logger({
|
||||
file: 'errors.log',
|
||||
timestamp: true
|
||||
});
|
||||
|
||||
class SetupSpellChecker {
|
||||
init() {
|
||||
@@ -16,7 +22,7 @@ class SetupSpellChecker {
|
||||
try {
|
||||
this.SpellCheckHandler = new SpellCheckHandler();
|
||||
} catch (err) {
|
||||
console.log(err);
|
||||
logger.error(err);
|
||||
}
|
||||
}
|
||||
|
||||
|
@@ -98,7 +98,7 @@ const renderNativeImage = function (arg) {
|
||||
return Promise.resolve()
|
||||
.then(() => renderCanvas(arg))
|
||||
.then(canvas => {
|
||||
const pngData = nativeImage.createFromDataURL(canvas.toDataURL('image/png')).toPng();
|
||||
const pngData = nativeImage.createFromDataURL(canvas.toDataURL('image/png')).toPNG();
|
||||
return Promise.resolve(nativeImage.createFromBuffer(pngData, config.pixelRatio));
|
||||
});
|
||||
};
|
||||
|
86
app/renderer/js/utils/certificate-util.js
Normal file
86
app/renderer/js/utils/certificate-util.js
Normal file
@@ -0,0 +1,86 @@
|
||||
'use strict';
|
||||
|
||||
const { app, dialog } = require('electron').remote;
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
const JsonDB = require('node-json-db');
|
||||
const Logger = require('./logger-util');
|
||||
const { initSetUp } = require('./default-util');
|
||||
|
||||
initSetUp();
|
||||
|
||||
const logger = new Logger({
|
||||
file: `certificate-util.log`,
|
||||
timestamp: true
|
||||
});
|
||||
|
||||
let instance = null;
|
||||
const certificatesDir = `${app.getPath('userData')}/certificates`;
|
||||
|
||||
class CertificateUtil {
|
||||
constructor() {
|
||||
if (instance) {
|
||||
return instance;
|
||||
} else {
|
||||
instance = this;
|
||||
}
|
||||
|
||||
this.reloadDB();
|
||||
return instance;
|
||||
}
|
||||
getCertificate(server, defaultValue = null) {
|
||||
this.reloadDB();
|
||||
const value = this.db.getData('/')[server];
|
||||
if (value === undefined) {
|
||||
return defaultValue;
|
||||
} else {
|
||||
return value;
|
||||
}
|
||||
}
|
||||
// Function to copy the certificate to userData folder
|
||||
copyCertificate(server, location, fileName) {
|
||||
let copied = false;
|
||||
const filePath = `${certificatesDir}/${fileName}`;
|
||||
try {
|
||||
fs.copyFileSync(location, filePath);
|
||||
copied = true;
|
||||
} catch (err) {
|
||||
dialog.showErrorBox(
|
||||
'Error saving certificate',
|
||||
'We encountered error while saving the certificate.'
|
||||
);
|
||||
logger.error('Error while copying the certificate to certificates folder.');
|
||||
logger.error(err);
|
||||
}
|
||||
return copied;
|
||||
}
|
||||
setCertificate(server, fileName) {
|
||||
const filePath = `${certificatesDir}/${fileName}`;
|
||||
this.db.push(`/${server}`, filePath, true);
|
||||
this.reloadDB();
|
||||
}
|
||||
removeCertificate(server) {
|
||||
this.db.delete(`/${server}`);
|
||||
this.reloadDB();
|
||||
}
|
||||
reloadDB() {
|
||||
const settingsJsonPath = path.join(app.getPath('userData'), '/config/certificates.json');
|
||||
try {
|
||||
const file = fs.readFileSync(settingsJsonPath, 'utf8');
|
||||
JSON.parse(file);
|
||||
} catch (err) {
|
||||
if (fs.existsSync(settingsJsonPath)) {
|
||||
fs.unlinkSync(settingsJsonPath);
|
||||
dialog.showErrorBox(
|
||||
'Error saving settings',
|
||||
'We encountered error while saving the certificate.'
|
||||
);
|
||||
logger.error('Error while JSON parsing certificates.json: ');
|
||||
logger.error(err);
|
||||
}
|
||||
}
|
||||
this.db = new JsonDB(settingsJsonPath, true, true);
|
||||
}
|
||||
}
|
||||
|
||||
module.exports = new CertificateUtil();
|
@@ -48,6 +48,12 @@ class ConfigUtil {
|
||||
return value;
|
||||
}
|
||||
}
|
||||
// This function returns whether a key exists in the configuration file (settings.json)
|
||||
isConfigItemExists(key) {
|
||||
this.reloadDB();
|
||||
const value = this.db.getData('/')[key];
|
||||
return (value !== undefined);
|
||||
}
|
||||
|
||||
setConfigItem(key, value) {
|
||||
this.db.push(`/${key}`, value, true);
|
||||
@@ -60,7 +66,7 @@ class ConfigUtil {
|
||||
}
|
||||
|
||||
reloadDB() {
|
||||
const settingsJsonPath = path.join(app.getPath('userData'), '/settings.json');
|
||||
const settingsJsonPath = path.join(app.getPath('userData'), '/config/settings.json');
|
||||
try {
|
||||
const file = fs.readFileSync(settingsJsonPath, 'utf8');
|
||||
JSON.parse(file);
|
||||
@@ -69,10 +75,11 @@ class ConfigUtil {
|
||||
fs.unlinkSync(settingsJsonPath);
|
||||
dialog.showErrorBox(
|
||||
'Error saving settings',
|
||||
'We encountered error while saving current settings.'
|
||||
'We encountered an error while saving the settings.'
|
||||
);
|
||||
logger.error('Error while JSON parsing settings.json: ');
|
||||
logger.error(err);
|
||||
logger.reportSentry(err);
|
||||
}
|
||||
}
|
||||
this.db = new JsonDB(settingsJsonPath, true, true);
|
||||
|
@@ -10,6 +10,8 @@ if (process.type === 'renderer') {
|
||||
|
||||
const zulipDir = app.getPath('userData');
|
||||
const logDir = `${zulipDir}/Logs/`;
|
||||
const certificatesDir = `${zulipDir}/certificates/`;
|
||||
const configDir = `${zulipDir}/config/`;
|
||||
const initSetUp = () => {
|
||||
// if it is the first time the app is running
|
||||
// create zulip dir in userData folder to
|
||||
@@ -22,6 +24,51 @@ const initSetUp = () => {
|
||||
if (!fs.existsSync(logDir)) {
|
||||
fs.mkdirSync(logDir);
|
||||
}
|
||||
|
||||
if (!fs.existsSync(certificatesDir)) {
|
||||
fs.mkdirSync(certificatesDir);
|
||||
}
|
||||
|
||||
// Migrate config files from app data folder to config folder inside app
|
||||
// data folder. This will be done once when a user updates to the new version.
|
||||
if (!fs.existsSync(configDir)) {
|
||||
fs.mkdirSync(configDir);
|
||||
const domainJson = `${zulipDir}/domain.json`;
|
||||
const certificatesJson = `${zulipDir}/certificates.json`;
|
||||
const settingsJson = `${zulipDir}/settings.json`;
|
||||
const updatesJson = `${zulipDir}/updates.json`;
|
||||
const windowStateJson = `${zulipDir}/window-state.json`;
|
||||
const configData = [
|
||||
{
|
||||
path: domainJson,
|
||||
fileName: `domain.json`
|
||||
},
|
||||
{
|
||||
path: certificatesJson,
|
||||
fileName: `certificates.json`
|
||||
},
|
||||
{
|
||||
path: settingsJson,
|
||||
fileName: `settings.json`
|
||||
},
|
||||
{
|
||||
path: updatesJson,
|
||||
fileName: `updates.json`
|
||||
}
|
||||
];
|
||||
configData.forEach(data => {
|
||||
if (fs.existsSync(data.path)) {
|
||||
fs.copyFileSync(data.path, configDir + data.fileName);
|
||||
fs.unlinkSync(data.path);
|
||||
}
|
||||
});
|
||||
// window-state.json is only deleted not moved, as the electron-window-state
|
||||
// package will recreate the file in the config folder.
|
||||
if (fs.existsSync(windowStateJson)) {
|
||||
fs.unlinkSync(windowStateJson);
|
||||
}
|
||||
}
|
||||
|
||||
setupCompleted = true;
|
||||
}
|
||||
};
|
||||
|
41
app/renderer/js/utils/dnd-util.js
Normal file
41
app/renderer/js/utils/dnd-util.js
Normal file
@@ -0,0 +1,41 @@
|
||||
'use strict';
|
||||
|
||||
const ConfigUtil = require(__dirname + '/config-util.js');
|
||||
|
||||
function toggle() {
|
||||
const dnd = !ConfigUtil.getConfigItem('dnd', false);
|
||||
const dndSettingList = ['showNotification', 'silent'];
|
||||
if (process.platform === 'win32') {
|
||||
dndSettingList.push('flashTaskbarOnMessage');
|
||||
}
|
||||
|
||||
let newSettings;
|
||||
if (dnd) {
|
||||
const oldSettings = {};
|
||||
newSettings = {};
|
||||
|
||||
// Iterate through the dndSettingList.
|
||||
for (const settingName of dndSettingList) {
|
||||
// Store the current value of setting.
|
||||
oldSettings[settingName] = ConfigUtil.getConfigItem(settingName);
|
||||
// New value of setting.
|
||||
newSettings[settingName] = (settingName === 'silent');
|
||||
}
|
||||
|
||||
// Store old value in oldSettings.
|
||||
ConfigUtil.setConfigItem('dndPreviousSettings', oldSettings);
|
||||
} else {
|
||||
newSettings = ConfigUtil.getConfigItem('dndPreviousSettings');
|
||||
}
|
||||
|
||||
for (const settingName of dndSettingList) {
|
||||
ConfigUtil.setConfigItem(settingName, newSettings[settingName]);
|
||||
}
|
||||
|
||||
ConfigUtil.setConfigItem('dnd', dnd);
|
||||
return {dnd, newSettings};
|
||||
}
|
||||
|
||||
module.exports = {
|
||||
toggle
|
||||
};
|
@@ -5,8 +5,12 @@ const fs = require('fs');
|
||||
const path = require('path');
|
||||
const JsonDB = require('node-json-db');
|
||||
const request = require('request');
|
||||
const escape = require('escape-html');
|
||||
|
||||
const Logger = require('./logger-util');
|
||||
|
||||
const CertificateUtil = require(__dirname + '/certificate-util.js');
|
||||
|
||||
const logger = new Logger({
|
||||
file: `domain-util.log`,
|
||||
timestamp: true
|
||||
@@ -104,7 +108,19 @@ class DomainUtil {
|
||||
|
||||
domain = this.formatUrl(domain);
|
||||
|
||||
const checkDomain = domain + '/static/audio/zulip.ogg';
|
||||
const certificate = CertificateUtil.getCertificate(encodeURIComponent(domain));
|
||||
let certificateLocation = '';
|
||||
|
||||
if (certificate) {
|
||||
// To handle case where certificate has been moved from the location in certificates.json
|
||||
try {
|
||||
certificateLocation = fs.readFileSync(certificate);
|
||||
} catch (err) {
|
||||
logger.warn('Error while trying to get certificate: ' + err);
|
||||
}
|
||||
}
|
||||
// If certificate for the domain exists add it as a ca key in the request's parameter else consider only domain as the parameter for request
|
||||
const checkDomain = (certificateLocation) ? ({url: domain + '/static/audio/zulip.ogg', ca: certificateLocation}) : domain + '/static/audio/zulip.ogg';
|
||||
|
||||
const serverConf = {
|
||||
icon: defaultIconUrl,
|
||||
@@ -114,21 +130,16 @@ class DomainUtil {
|
||||
|
||||
return new Promise((resolve, reject) => {
|
||||
request(checkDomain, (error, response) => {
|
||||
const certsError =
|
||||
[
|
||||
'Error: self signed certificate',
|
||||
'Error: unable to verify the first certificate',
|
||||
'Error: unable to get local issuer certificate'
|
||||
];
|
||||
|
||||
// If the domain contains following strings we just bypass the server
|
||||
const whitelistDomains = [
|
||||
'zulipdev.org'
|
||||
];
|
||||
|
||||
// make sure that error is a error or string not undefined
|
||||
// make sure that error is an error or string not undefined
|
||||
// so validation does not throw error.
|
||||
error = error || '';
|
||||
|
||||
const certsError = error.toString().includes('certificate');
|
||||
if (!error && response.statusCode < 400) {
|
||||
// Correct
|
||||
this.getServerSettings(domain).then(serverSettings => {
|
||||
@@ -136,7 +147,7 @@ class DomainUtil {
|
||||
}, () => {
|
||||
resolve(serverConf);
|
||||
});
|
||||
} else if (domain.indexOf(whitelistDomains) >= 0 || certsError.indexOf(error.toString()) >= 0) {
|
||||
} else if (domain.indexOf(whitelistDomains) >= 0 || certsError) {
|
||||
if (silent) {
|
||||
this.getServerSettings(domain).then(serverSettings => {
|
||||
resolve(serverSettings);
|
||||
@@ -144,15 +155,19 @@ class DomainUtil {
|
||||
resolve(serverConf);
|
||||
});
|
||||
} else {
|
||||
// Report error to sentry to get idea of possible certificate errors
|
||||
// users get when adding the servers
|
||||
logger.reportSentry(new Error(error));
|
||||
const certErrorMessage = `Do you trust certificate from ${domain}? \n ${error}`;
|
||||
const certErrorDetail = `The server you're connecting to is either someone impersonating the Zulip server you entered, or the server you're trying to connect to is configured in an insecure way.
|
||||
\n Unless you have a good reason to believe otherwise, you should not proceed.
|
||||
\n You can click here if you'd like to proceed with the connection.`;
|
||||
const certErrorDetail = `The organization you're connecting to is either someone impersonating the Zulip server you entered, or the server you're trying to connect to is configured in an insecure way.
|
||||
\nIf you have a valid certificate please add it from Settings>Organizations and try to add the organization again.
|
||||
\nUnless you have a good reason to believe otherwise, you should not proceed.
|
||||
\nYou can click here if you'd like to proceed with the connection.`;
|
||||
|
||||
dialog.showMessageBox({
|
||||
type: 'warning',
|
||||
buttons: ['Yes', 'No'],
|
||||
defaultId: 0,
|
||||
defaultId: 1,
|
||||
message: certErrorMessage,
|
||||
detail: certErrorDetail
|
||||
}, response => {
|
||||
@@ -169,7 +184,8 @@ class DomainUtil {
|
||||
}
|
||||
} else {
|
||||
const invalidZulipServerError = `${domain} does not appear to be a valid Zulip server. Make sure that \
|
||||
\n(1) you can connect to that URL in a web browser and \n (2) if you need a proxy to connect to the Internet, that you've configured your proxy in the Network settings \n (3) its a zulip server`;
|
||||
\n (1) you can connect to that URL in a web browser and \n (2) if you need a proxy to connect to the Internet, that you've configured your proxy in the Network settings \n (3) its a zulip server \
|
||||
\n (4) the server has a valid certificate, you can add custom certificates in Settings>Organizations`;
|
||||
reject(invalidZulipServerError);
|
||||
}
|
||||
});
|
||||
@@ -188,7 +204,7 @@ class DomainUtil {
|
||||
// Following check handles both the cases
|
||||
icon: data.realm_icon.startsWith('/') ? data.realm_uri + data.realm_icon : data.realm_icon,
|
||||
url: data.realm_uri,
|
||||
alias: data.realm_name
|
||||
alias: escape(data.realm_name)
|
||||
});
|
||||
}
|
||||
} else {
|
||||
@@ -206,18 +222,24 @@ class DomainUtil {
|
||||
try {
|
||||
request(url).on('response', response => {
|
||||
response.on('error', err => {
|
||||
console.log(err);
|
||||
logger.log('Could not get server icon.');
|
||||
logger.log(err);
|
||||
logger.reportSentry(err);
|
||||
resolve(defaultIconUrl);
|
||||
});
|
||||
response.pipe(file).on('finish', () => {
|
||||
resolve(filePath);
|
||||
});
|
||||
}).on('error', err => {
|
||||
console.log(err);
|
||||
logger.log('Could not get server icon.');
|
||||
logger.log(err);
|
||||
logger.reportSentry(err);
|
||||
resolve(defaultIconUrl);
|
||||
});
|
||||
} catch (err) {
|
||||
console.log(err);
|
||||
logger.log('Could not get server icon.');
|
||||
logger.log(err);
|
||||
logger.reportSentry(err);
|
||||
resolve(defaultIconUrl);
|
||||
}
|
||||
});
|
||||
@@ -235,7 +257,7 @@ class DomainUtil {
|
||||
}
|
||||
|
||||
reloadDB() {
|
||||
const domainJsonPath = path.join(app.getPath('userData'), '/domain.json');
|
||||
const domainJsonPath = path.join(app.getPath('userData'), 'config/domain.json');
|
||||
try {
|
||||
const file = fs.readFileSync(domainJsonPath, 'utf8');
|
||||
JSON.parse(file);
|
||||
@@ -249,6 +271,7 @@ class DomainUtil {
|
||||
);
|
||||
logger.error('Error while JSON parsing domain.json: ');
|
||||
logger.error(err);
|
||||
logger.reportSentry(err);
|
||||
}
|
||||
}
|
||||
this.db = new JsonDB(domainJsonPath, true, true);
|
||||
|
@@ -19,7 +19,20 @@ class LinkUtil {
|
||||
const currentDomain = wurl('hostname', currentUrl);
|
||||
const newDomain = wurl('hostname', newUrl);
|
||||
|
||||
return (currentDomain === newDomain) && newUrl.includes('/#narrow');
|
||||
const sameDomainUrl = (currentDomain === newDomain || newUrl === currentUrl + '/');
|
||||
const isUploadsUrl = newUrl.includes(currentUrl + '/user_uploads/');
|
||||
const isInternalUrl = newUrl.includes('/#narrow') || isUploadsUrl;
|
||||
|
||||
return {
|
||||
isInternalUrl: sameDomainUrl && isInternalUrl,
|
||||
isUploadsUrl
|
||||
};
|
||||
}
|
||||
|
||||
isImage(url) {
|
||||
// test for images extension as well as urls like .png?s=100
|
||||
const isImageUrl = /\.(bmp|gif|jpg|jpeg|png|webp)\?*.*$/i;
|
||||
return isImageUrl.test(url);
|
||||
}
|
||||
}
|
||||
|
||||
|
@@ -52,7 +52,7 @@ class LinuxUpdateUtil {
|
||||
}
|
||||
|
||||
reloadDB() {
|
||||
const linuxUpdateJsonPath = path.join(app.getPath('userData'), '/updates.json');
|
||||
const linuxUpdateJsonPath = path.join(app.getPath('userData'), '/config/updates.json');
|
||||
try {
|
||||
const file = fs.readFileSync(linuxUpdateJsonPath, 'utf8');
|
||||
JSON.parse(file);
|
||||
@@ -61,7 +61,7 @@ class LinuxUpdateUtil {
|
||||
fs.unlinkSync(linuxUpdateJsonPath);
|
||||
dialog.showErrorBox(
|
||||
'Error saving update notifications.',
|
||||
'We encountered error while saving update notifications.'
|
||||
'We encountered an error while saving the update notifications.'
|
||||
);
|
||||
logger.error('Error while JSON parsing updates.json: ');
|
||||
logger.error(err);
|
||||
|
@@ -2,8 +2,10 @@ const NodeConsole = require('console').Console;
|
||||
const fs = require('fs');
|
||||
const isDev = require('electron-is-dev');
|
||||
const { initSetUp } = require('./default-util');
|
||||
const { sentryInit, captureException } = require('./sentry-util');
|
||||
|
||||
initSetUp();
|
||||
sentryInit();
|
||||
let app = null;
|
||||
if (process.type === 'renderer') {
|
||||
app = require('electron').remote.app;
|
||||
@@ -82,6 +84,10 @@ class Logger {
|
||||
`${date.getMinutes()}:${date.getSeconds()}`;
|
||||
return timestamp;
|
||||
}
|
||||
|
||||
reportSentry(err) {
|
||||
captureException(err);
|
||||
}
|
||||
}
|
||||
|
||||
module.exports = Logger;
|
||||
|
96
app/renderer/js/utils/proxy-util.js
Normal file
96
app/renderer/js/utils/proxy-util.js
Normal file
@@ -0,0 +1,96 @@
|
||||
'use strict';
|
||||
|
||||
const ConfigUtil = require('./config-util.js');
|
||||
|
||||
let instance = null;
|
||||
|
||||
class ProxyUtil {
|
||||
constructor() {
|
||||
if (instance) {
|
||||
return instance;
|
||||
} else {
|
||||
instance = this;
|
||||
}
|
||||
|
||||
return instance;
|
||||
}
|
||||
|
||||
resolveSystemProxy(mainWindow) {
|
||||
const page = mainWindow.webContents;
|
||||
const ses = page.session;
|
||||
const resolveProxyUrl = 'www.google.com';
|
||||
|
||||
// Check HTTP Proxy
|
||||
const httpProxy = new Promise(resolve => {
|
||||
ses.resolveProxy('http://' + resolveProxyUrl, proxy => {
|
||||
let httpString = '';
|
||||
if (proxy !== 'DIRECT') {
|
||||
// in case of proxy HTTPS url:port, windows gives first word as HTTPS while linux gives PROXY
|
||||
// for all other HTTP or direct url:port both uses PROXY
|
||||
if (proxy.includes('PROXY') || proxy.includes('HTTPS')) {
|
||||
httpString = 'http=' + proxy.split('PROXY')[1] + ';';
|
||||
}
|
||||
}
|
||||
resolve(httpString);
|
||||
});
|
||||
});
|
||||
// Check HTTPS Proxy
|
||||
const httpsProxy = new Promise(resolve => {
|
||||
ses.resolveProxy('https://' + resolveProxyUrl, proxy => {
|
||||
let httpsString = '';
|
||||
if (proxy !== 'DIRECT' || proxy.includes('HTTPS')) {
|
||||
// in case of proxy HTTPS url:port, windows gives first word as HTTPS while linux gives PROXY
|
||||
// for all other HTTP or direct url:port both uses PROXY
|
||||
if (proxy.includes('PROXY' || proxy.includes('HTTPS'))) {
|
||||
httpsString += 'https=' + proxy.split('PROXY')[1] + ';';
|
||||
}
|
||||
}
|
||||
resolve(httpsString);
|
||||
});
|
||||
});
|
||||
|
||||
// Check FTP Proxy
|
||||
const ftpProxy = new Promise(resolve => {
|
||||
ses.resolveProxy('ftp://' + resolveProxyUrl, proxy => {
|
||||
let ftpString = '';
|
||||
if (proxy !== 'DIRECT') {
|
||||
if (proxy.includes('PROXY')) {
|
||||
ftpString += 'ftp=' + proxy.split('PROXY')[1] + ';';
|
||||
}
|
||||
}
|
||||
resolve(ftpString);
|
||||
});
|
||||
});
|
||||
|
||||
// Check SOCKS Proxy
|
||||
const socksProxy = new Promise(resolve => {
|
||||
ses.resolveProxy('socks4://' + resolveProxyUrl, proxy => {
|
||||
let socksString = '';
|
||||
if (proxy !== 'DIRECT') {
|
||||
if (proxy.includes('SOCKS5')) {
|
||||
socksString += 'socks=' + proxy.split('SOCKS5')[1] + ';';
|
||||
} else if (proxy.includes('SOCKS4')) {
|
||||
socksString += 'socks=' + proxy.split('SOCKS4')[1] + ';';
|
||||
} else if (proxy.includes('PROXY')) {
|
||||
socksString += 'socks=' + proxy.split('PROXY')[1] + ';';
|
||||
}
|
||||
}
|
||||
resolve(socksString);
|
||||
});
|
||||
});
|
||||
|
||||
Promise.all([httpProxy, httpsProxy, ftpProxy, socksProxy]).then(values => {
|
||||
let proxyString = '';
|
||||
values.forEach(proxy => {
|
||||
proxyString += proxy;
|
||||
});
|
||||
ConfigUtil.setConfigItem('systemProxyRules', proxyString);
|
||||
const useSystemProxy = ConfigUtil.getConfigItem('useSystemProxy');
|
||||
if (useSystemProxy) {
|
||||
ConfigUtil.setConfigItem('proxyRules', proxyString);
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
module.exports = new ProxyUtil();
|
@@ -1,4 +1,10 @@
|
||||
const isOnline = require('is-online');
|
||||
const Logger = require('./logger-util');
|
||||
|
||||
const logger = new Logger({
|
||||
file: `domain-util.log`,
|
||||
timestamp: true
|
||||
});
|
||||
|
||||
class ReconnectUtil {
|
||||
constructor(serverManagerView) {
|
||||
@@ -13,12 +19,12 @@ class ReconnectUtil {
|
||||
pollInternetAndReload() {
|
||||
const pollInterval = setInterval(() => {
|
||||
this._checkAndReload()
|
||||
.then(status => {
|
||||
if (status) {
|
||||
this.alreadyReloaded = true;
|
||||
clearInterval(pollInterval);
|
||||
}
|
||||
});
|
||||
.then(status => {
|
||||
if (status) {
|
||||
this.alreadyReloaded = true;
|
||||
clearInterval(pollInterval);
|
||||
}
|
||||
});
|
||||
}, 1500);
|
||||
}
|
||||
|
||||
@@ -26,22 +32,24 @@ class ReconnectUtil {
|
||||
return new Promise(resolve => {
|
||||
if (!this.alreadyReloaded) { // eslint-disable-line no-negated-condition
|
||||
isOnline()
|
||||
.then(online => {
|
||||
if (online) {
|
||||
if (!this.alreadyReloaded) {
|
||||
this.serverManagerView.reloadView();
|
||||
.then(online => {
|
||||
if (online) {
|
||||
if (!this.alreadyReloaded) {
|
||||
this.serverManagerView.reloadView();
|
||||
}
|
||||
logger.log('You\'re back online.');
|
||||
return resolve(true);
|
||||
}
|
||||
console.log('You\'re back online.');
|
||||
return resolve(true);
|
||||
}
|
||||
|
||||
console.log('There is no internet connection, try checking network cables, modem and router.');
|
||||
const errMsgHolder = document.querySelector('#description');
|
||||
errMsgHolder.innerHTML = `
|
||||
logger.log('There is no internet connection, try checking network cables, modem and router.');
|
||||
const errMsgHolder = document.querySelector('#description');
|
||||
if (errMsgHolder) {
|
||||
errMsgHolder.innerHTML = `
|
||||
<div>You internet connection does't seem to work properly!</div>
|
||||
</div>Verify that it works and then click try again.</div>`;
|
||||
return resolve(false);
|
||||
});
|
||||
}
|
||||
return resolve(false);
|
||||
});
|
||||
} else {
|
||||
return resolve(true);
|
||||
}
|
||||
|
16
app/renderer/js/utils/sentry-util.js
Normal file
16
app/renderer/js/utils/sentry-util.js
Normal file
@@ -0,0 +1,16 @@
|
||||
const { init, captureException } = require('@sentry/electron');
|
||||
const isDev = require('electron-is-dev');
|
||||
|
||||
const sentryInit = () => {
|
||||
if (!isDev) {
|
||||
init({
|
||||
dsn: 'SENTRY_DSN',
|
||||
sendTimeout: 30 // wait 30 seconds before considering the sending capture to have failed, default is 1 second
|
||||
});
|
||||
}
|
||||
};
|
||||
|
||||
module.exports = {
|
||||
sentryInit,
|
||||
captureException
|
||||
};
|
@@ -24,6 +24,10 @@
|
||||
</div>
|
||||
</div>
|
||||
<div id="actions-container">
|
||||
<div class="action-button" id="dnd-action">
|
||||
<i class="material-icons md-48">notifications</i>
|
||||
<span id="dnd-tooltip" style="display:none">Do Not Disturb</span>
|
||||
</div>
|
||||
<div class="action-button" id="reload-action">
|
||||
<i class="material-icons md-48">refresh</i>
|
||||
<span id="reload-tooltip" style="display:none">Reload</span>
|
||||
@@ -42,7 +46,11 @@
|
||||
<div id="webviews-container"></div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div id="feedback-modal">
|
||||
<send-feedback></send-feedback>
|
||||
</div>
|
||||
</body>
|
||||
<script src="js/main.js"></script>
|
||||
<script>require('./js/shared/preventdrag.js')</script>
|
||||
</html>
|
||||
</html>
|
||||
|
BIN
app/resources/sounds/ding.ogg
Normal file
BIN
app/resources/sounds/ding.ogg
Normal file
Binary file not shown.
@@ -6,9 +6,9 @@ os: Previous Visual Studio 2015
|
||||
|
||||
cache:
|
||||
- node_modules
|
||||
|
||||
|
||||
install:
|
||||
- ps: Install-Product node 6 x64
|
||||
- ps: Install-Product node 8 x64
|
||||
- git reset --hard HEAD
|
||||
- npm install npm -g
|
||||
- node --version
|
||||
@@ -21,4 +21,4 @@ build: off
|
||||
|
||||
test_script:
|
||||
- npm run test
|
||||
- npm run test-e2e
|
||||
# - npm run test-e2e
|
||||
|
BIN
build/appdmg.png
BIN
build/appdmg.png
Binary file not shown.
Before Width: | Height: | Size: 6.2 KiB After Width: | Height: | Size: 12 KiB |
665
changelog.md
Normal file
665
changelog.md
Normal file
@@ -0,0 +1,665 @@
|
||||
# Version History
|
||||
|
||||
|
||||
|
||||
All notable changes to the Zulip desktop app are documented in this file.
|
||||
|
||||
|
||||
|
||||
### v2.3.2 --2018-05-28
|
||||
|
||||
|
||||
This is a quick release since we recently updated the certificate for code signing the app and we want to make sure the previous versions of the app get auto-updates without any conflicts.
|
||||
|
||||
<hr>
|
||||
|
||||
### v2.3.1 --2018-05-23
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Add a new setting to disable auto-updates
|
||||
|
||||
* Add a menu item to check for updates manually
|
||||
|
||||
* Other minor improvements
|
||||
|
||||
**Fixes**:
|
||||
|
||||
* Fix app not rendering colors properly
|
||||
|
||||
* **Security fix** - Do proper HTML escaping for server data to avoid XSS attacks
|
||||
|
||||
* Fix loading indicator when server is loaded
|
||||
* Other minor fixes
|
||||
|
||||
|
||||
|
||||
|
||||
**Updated dependencies**:
|
||||
|
||||
electron - `v2.0.1`
|
||||
|
||||
electron-builder - `v20.13.4`
|
||||
|
||||
electron-updater - `v2.21.10`
|
||||
|
||||
<hr>
|
||||
|
||||
|
||||
### v2.2.0-beta --2018-05-08
|
||||
|
||||
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Added do not disturb feature
|
||||
|
||||
* New DMG installer image
|
||||
|
||||
* Minor improvements
|
||||
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
* Fix download functionality of file attachment links
|
||||
|
||||
* Fix tray icon not showing unread counts
|
||||
|
||||
|
||||
|
||||
|
||||
**Updated dependencies**:
|
||||
|
||||
electron - `v2.0.0`
|
||||
|
||||
electron-builder - `v2.21.10`
|
||||
|
||||
electron-updater - `v2.21.8`
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v2.0.0 -- 2018-04-20
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* [Snap](https://snapcraft.io/zulip) support for Linux
|
||||
|
||||
* Add an option to download the file attachments instead of opening it in the browser
|
||||
|
||||
* Open image link in webapp lightbox
|
||||
|
||||
* Add scrollbar for list of organizations on overflow
|
||||
|
||||
* Better report issue UX
|
||||
|
||||
* Add F5 shortcut for reloading the app
|
||||
|
||||
* Responsive UI for connected orgs in smaller window sizes
|
||||
|
||||
* Minor improvements
|
||||
|
||||
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
|
||||
|
||||
* Remove unused shortcuts
|
||||
|
||||
* Update toggle sidebar shortcut to CMD/CTRL+SHIFT+S
|
||||
|
||||
* Warning dialog box for Reset App Settings
|
||||
|
||||
* Fix reinstall script for working across all platforms
|
||||
|
||||
* Other minor fixes
|
||||
|
||||
|
||||
|
||||
**Updated dependencies**:
|
||||
|
||||
* Update electron-builder to `v20.8.1`
|
||||
<hr>
|
||||
|
||||
|
||||
|
||||
### v1.9.0 --2018-03-23
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Major UI changes in the add new server and setting page
|
||||
|
||||
* Some users wanted to change the look of the Zulip. Now you have the power. Feel free to add your own CSS using the all-new setting option **Add Custom CSS**
|
||||
|
||||
* Added i18n locale helper script. Internalization is coming in the next release
|
||||
|
||||
* Added **What's new** in `help` submenu so that you can see all the latest changes in the app
|
||||
|
||||
* Other small improvements
|
||||
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
* Add Zulip binary link to the bin. It was a regression we missed somehow. You can now start the app using `zulip` from a terminal [Linux]
|
||||
|
||||
* Fix app settings overriding issue. This bug was unnoticed from `v1.4.0`. The bug was overriding the app settings which was pretty bad. Don't worry this works as expected now
|
||||
|
||||
|
||||
|
||||
* Prevent drag and drop events to avoid few security risks
|
||||
|
||||
* Do not allow running insecure contents in the app
|
||||
|
||||
* The ugly white flickering in the webview is now fixed
|
||||
|
||||
* Fix position of left-sidebar on toggle
|
||||
|
||||
* Fix actions tooltip not visible on hover
|
||||
|
||||
* Other small fixes
|
||||
|
||||
|
||||
|
||||
|
||||
**Updated dependencies**:
|
||||
|
||||
* electron - `v1.8.4`
|
||||
|
||||
* Spectron - `v3.8.0`
|
||||
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v1.8.2 --2018-02-27
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Add bots mention support to reply option
|
||||
|
||||
* Show a notification when a new update available [Linux]
|
||||
|
||||
* Add back button in left-sidebar
|
||||
|
||||
* Add a Loading indication for new server button
|
||||
|
||||
* Improve help menu
|
||||
|
||||
* Add menu-item to reveal app logs in file manager
|
||||
|
||||
* Setting page and left-sidebar UI improvements
|
||||
|
||||
* Other minor improvments
|
||||
|
||||
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
* Fix broken last active tab
|
||||
|
||||
* Fix Zoom In shortcut
|
||||
|
||||
* Check whether the internet is working before reloading
|
||||
|
||||
* New organization link overlapping existing servers
|
||||
|
||||
* Disable electron-connect when it's run from npm start
|
||||
|
||||
* Do not auto-reload app when the system comes back from sleep
|
||||
|
||||
* Only toggle the setting state if the element is present
|
||||
|
||||
* Other minor fixes
|
||||
|
||||
|
||||
|
||||
**Updated dependencies**:
|
||||
|
||||
* electron - `v1.8.2`
|
||||
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v1.8.1 --2018-01-19
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Reply from notifications [macOS]
|
||||
|
||||
* Add a setting option to start the app in the background
|
||||
|
||||
* 32-bit Debian installer
|
||||
|
||||
* 32-bit AppImage installer
|
||||
|
||||
* Automatically add apt-repo and GPG public keys on installing Debian file [Linux]
|
||||
|
||||
* Remove app data, config files etc on uninstalling Debian installer [Linux]
|
||||
|
||||
* Add logger utility for debugging that makes easier to sharing the apps
|
||||
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
* Handle corrupted config files
|
||||
|
||||
* Reload full app on system hibernation
|
||||
* Load default icon if organization icon is not available
|
||||
|
||||
* Focus app when a notification is triggered
|
||||
|
||||
* Reflect changes in the preference page (#362)
|
||||
|
||||
* Set the default value of flash taskbar setting [Windows]
|
||||
|
||||
* Rename Zoom In keyboard shortcut
|
||||
|
||||
* Fix checkDomain, so it checks all error codes
|
||||
|
||||
* Disable hardware acceleration to decrease the load on GPU
|
||||
|
||||
* Minor bug fixes
|
||||
|
||||
|
||||
|
||||
**Updated dependencies**:
|
||||
|
||||
* electron - `v1.7.10`
|
||||
|
||||
* electron-builder - `v19.53.6`
|
||||
|
||||
* electron-updater - `v2.18.2`
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
|
||||
|
||||
### v1.7.0 --2017-11-24
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Updated to Electron `v1.6.15`, electron-builder `v19.46.4`
|
||||
|
||||
* Improved setting page for new users
|
||||
|
||||
* On the developer side, we have added few tests to make sure app doesn't fail
|
||||
|
||||
* Minor improvements
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
|
||||
### 1.6.0-beta --2017-11-16
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Added setting option to enable/disable spellcheck
|
||||
|
||||
* Added setting option to control Windows taskbar flashing [Windows]
|
||||
|
||||
* Auto-updates for Linux [AppImage]
|
||||
|
||||
* Better tray icons for retina display
|
||||
|
||||
* Reset app settings from Menu item
|
||||
|
||||
* Show detailed error message on invalid Zulip server
|
||||
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
* Fixed a bug which was caused by app's shortcuts. From now on our shortcuts won't hijack other apps shortcuts
|
||||
|
||||
* Removed [electron-localshortcut](https://github.com/parro-it/electron-localshortcut) completely. Now we only depends on menu accelerators for keyboard shortcuts
|
||||
|
||||
* Handle certificate issue properly
|
||||
|
||||
* Other minor fixes
|
||||
|
||||
<hr>
|
||||
|
||||
|
||||
### v1.5.0 --2017-10-11
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Added an option to clear app data
|
||||
|
||||
* Added an option to show/hide desktop notifications
|
||||
|
||||
* Redesigned setting page
|
||||
|
||||
* Red dot over dock icon for PM [macOS]
|
||||
|
||||
* Show server-info on hovering the server icon
|
||||
|
||||
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
* Fetch correct organization icon from server_settings API
|
||||
|
||||
* Minor improvements
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v1.4.0 --2017-09-04
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Added proxy support
|
||||
|
||||
* Added setting option for badges
|
||||
|
||||
* Start app at login setting option
|
||||
|
||||
* Added app category for Linux
|
||||
|
||||
* Minor improvements in settings page
|
||||
|
||||
* apt-repo on bintray for linux - [here](https://bintray.com/zulip/debian/zulip-elec)
|
||||
|
||||
|
||||
|
||||
**Fixes**
|
||||
|
||||
* Fixed auto-updates
|
||||
|
||||
* Better warning message on certificate error
|
||||
|
||||
* Don't allow duplicate servers
|
||||
|
||||
<hr>
|
||||
|
||||
|
||||
### 1.3.0-beta -- 2017-08-09
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Added back/forward option under `History` submenu
|
||||
|
||||
* Added taskbar overlay icon [Windows]
|
||||
|
||||
* Added `Window` submenu by which users can switch to other servers
|
||||
|
||||
* Added flashing taskbar icon on incoming message [Windows]
|
||||
|
||||
* Option to hide the left sidebar
|
||||
|
||||
* Staged rollouts
|
||||
|
||||
* Minor style improvements
|
||||
|
||||
|
||||
|
||||
|
||||
**Fixes**
|
||||
|
||||
* Handle focus event properly
|
||||
|
||||
* Open external links in default browser
|
||||
|
||||
* Allow user to change installation directory
|
||||
|
||||
* Fixed server-icon path error [Windows]
|
||||
|
||||
* Fixed server validation error
|
||||
|
||||
* Fetch server details from Zulip api
|
||||
|
||||
* Added tooltip in left sidebar
|
||||
|
||||
* Added publisher name in windows installer
|
||||
|
||||
|
||||
|
||||
**Updated dependencies**:
|
||||
|
||||
* electron - `v1.6.11`
|
||||
|
||||
* spellchecker - `v1.2.0`
|
||||
|
||||
* electron-builder - `v19.9.1`
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v1.2.0-beta -- 2017-07-12
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
|
||||
|
||||
* Added new setting page
|
||||
|
||||
* Setting for beta-updates. You can opt in for beta updates via selecting it from setting page
|
||||
|
||||
* Added Keyboard shortcuts to switch between multiple servers
|
||||
|
||||
* Desktop notifications support on Windows
|
||||
|
||||
|
||||
|
||||
**Fixes**
|
||||
|
||||
* Unregister keyboard shortcuts on windows close
|
||||
|
||||
* Show warning dialog while deleting server
|
||||
|
||||
* Allow server which is signed by root cert
|
||||
|
||||
* Other minor bug fixes
|
||||
|
||||
<hr>
|
||||
|
||||
|
||||
### v1.1.0-beta --2017-06-23
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* New network error page. App will auto-reload once the network comes back
|
||||
* Quit shortcut - CTRL+Q [Windows]
|
||||
* Improved preferences
|
||||
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
* Fixed power-monitor module error
|
||||
* Fixed code signing error [macOS]
|
||||
|
||||
<hr>
|
||||
|
||||
|
||||
|
||||
### v1.0.0-beta --2017-06-21
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Sign in to multiple teams
|
||||
* Windows 7 desktop notification support
|
||||
* Show badge count for each Zulip server
|
||||
* Toggle window on clicking tray icon [Windows]
|
||||
|
||||
* Windows installer is properly code signed using [DigiCert](https://www.digicert.com/) certificate. You may get a warning regarding the certificate, please make it false positive
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
* Close/hide app properly
|
||||
* Keep app running in background on clicking X
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v0.5.10 --2017-05-12
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Added self-signed server support
|
||||
* Unread message counts in tray icon
|
||||
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v0.5.9 --2017-04-12
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
* Properly signed app for macOS
|
||||
* Toggle tray icon
|
||||
* Better error handling when no internet connenction
|
||||
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
* Fixed permission issue on windows
|
||||
* Fixed wrong keyboard shortcuts
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v0.5.8 --2017-02-13
|
||||
|
||||
**Enhacements**:
|
||||
Smaller Windows installer size
|
||||
|
||||
<hr>
|
||||
|
||||
### v0.5.7 --2017-02-08
|
||||
|
||||
Minor improvements
|
||||
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v0.5.6 --2017-02-07
|
||||
|
||||
|
||||
**Enhacements**:
|
||||
|
||||
- Using NSIS instead of [Squirrel.Windows](https://github.com/Squirrel/Squirrel.Windows) on Windows
|
||||
|
||||
- Autoupdates: now using [electron-updater](https://www.npmjs.com/package/electron-updater)
|
||||
|
||||
- Removed nuts dependency
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
- Windows installer error
|
||||
- Compile and build error in native node modules + spellchecker [Windows]
|
||||
- Missing icon on installing [Windows]
|
||||
|
||||
<hr>
|
||||
|
||||
|
||||
### v0.5.4 --2017-01-09
|
||||
|
||||
**Fixes**:
|
||||
- Fixed :
|
||||
- Auto-updates
|
||||
- Spellchecker
|
||||
- Zooming functionality
|
||||
|
||||
- Removed unused node modules
|
||||
- Using stable version for node modules
|
||||
- Added icon for AppImage
|
||||
|
||||
<hr>
|
||||
|
||||
|
||||
### v0.5.3 --2016-12-24
|
||||
**Enhancements**:
|
||||
- 🎉 Added automatic update support on Windows
|
||||
|
||||
**Fixes**:
|
||||
|
||||
- Fixed javascript error when electron has been left running and try to right-click
|
||||
|
||||
- Fixed error - Unregister Spellchecker while window is closed
|
||||
|
||||
- Fixed - Keyboard shortcuts not getting unregistered
|
||||
|
||||
- Minor UI Changes
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v0.5.2 --2016-12-13
|
||||
|
||||
**Enhancements**:
|
||||
|
||||
- ⚡️ Added automatic app updates for macOS
|
||||
- Added windows installer for 32 bit machine
|
||||
|
||||
- Better tray icons
|
||||
|
||||
**Fixes**:
|
||||
- Blurry Unity icon fixed
|
||||
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v0.5.1 --2016-11-23
|
||||
|
||||
**Enhacements**:
|
||||
|
||||
- Added Spellchecker support with correct spell suggestions
|
||||
|
||||
- Added Code-Signing on MAC
|
||||
|
||||
- Added Win/linux/Mac installers
|
||||
|
||||
- Added Continuous Integration on travis and appveyor
|
||||
|
||||
- Open internal links in app only and external in default browser
|
||||
|
||||
- Better icons
|
||||
|
||||
- Electron version updated to `v1.4.7`
|
||||
|
||||
- Using two package.json structure
|
||||
|
||||
- Node integration disabled in main window due to jquery error
|
||||
|
||||
- Now using electron-builder for packaging instead of electron-packager
|
||||
|
||||
- Removed electron-context-menu and simple-spellchecker dependency
|
||||
|
||||
|
||||
|
||||
**Fixes**:
|
||||
|
||||
- Better error handling when user enters wrong zulip server
|
||||
|
||||
- Fixed close Zulip window JavaScript error
|
||||
|
||||
- Fixed opening image in default browser
|
||||
|
||||
- Fixed native notifications issue on linux
|
||||
|
||||
|
||||
<hr>
|
||||
|
||||
### v0.0.1-alpha -- 2016-08-31
|
||||
|
||||
**Enhacements**:
|
||||
|
||||
* Added DMG installer for macOS
|
@@ -15,6 +15,7 @@ To build and run the app from source, you'll need the following:
|
||||
* [Python](https://www.python.org/downloads/release/python-2713/)
|
||||
(v2.7.x recommended)
|
||||
* A C++ compiler compatible with C++11
|
||||
* Linux users also need [Snapcraft](https://snapcraft.io/)
|
||||
* Development headers for the libXext, libXtst, and libxkbfile libraries
|
||||
|
||||
### Debian/Ubuntu and friends
|
||||
@@ -25,7 +26,7 @@ manager (see [here][nodesource-install] for more on the first command):
|
||||
|
||||
```sh
|
||||
$ curl -sL https://deb.nodesource.com/setup_6.x | sudo -E bash -
|
||||
$ sudo apt install git nodejs python build-essential libxext-dev libxtst-dev libxkbfile-dev libgconf-2-4
|
||||
$ sudo apt install git nodejs python build-essential snapcraft libxext-dev libxtst-dev libxkbfile-dev libgconf-2-4
|
||||
```
|
||||
|
||||
[nodesource-install]: https://nodejs.org/en/download/package-manager/#debian-and-ubuntu-based-linux-distributions
|
||||
@@ -76,7 +77,7 @@ This command will produce distributable packages or installers for the
|
||||
operating system you're running on:
|
||||
* on Windows, a Windows installer file
|
||||
* on macOS, a `.dmg` file
|
||||
* on Linux, a plain `.zip` file as well as a `.deb` file and an
|
||||
* on Linux, a plain `.zip` file as well as a `.deb` file, `.snap` file and an
|
||||
`AppImage` file.
|
||||
To generate all three types, you will need all three operating
|
||||
systems.
|
||||
|
8608
package-lock.json
generated
8608
package-lock.json
generated
File diff suppressed because it is too large
Load Diff
36
package.json
36
package.json
@@ -1,7 +1,7 @@
|
||||
{
|
||||
"name": "zulip",
|
||||
"productName": "Zulip",
|
||||
"version": "1.8.2",
|
||||
"version": "2.3.3",
|
||||
"main": "./app/main",
|
||||
"description": "Zulip Desktop App",
|
||||
"license": "Apache-2.0",
|
||||
@@ -22,7 +22,7 @@
|
||||
},
|
||||
"scripts": {
|
||||
"start": "electron app --disable-http-cache --no-electron-connect",
|
||||
"reinstall": "./tools/reinstall-node-modules",
|
||||
"reinstall": "node ./tools/reinstall-node-modules.js",
|
||||
"postinstall": "electron-builder install-app-deps",
|
||||
"test": "xo",
|
||||
"test-e2e": "gulp test-e2e",
|
||||
@@ -46,7 +46,8 @@
|
||||
],
|
||||
"copyright": "©2017 Kandra Labs, Inc.",
|
||||
"mac": {
|
||||
"category": "public.app-category.productivity"
|
||||
"category": "public.app-category.productivity",
|
||||
"artifactName": "${productName}-${version}-${arch}.${ext}"
|
||||
},
|
||||
"linux": {
|
||||
"category": "Chat;GNOME;GTK;Network;InstantMessaging",
|
||||
@@ -55,32 +56,41 @@
|
||||
"target": [
|
||||
"deb",
|
||||
"zip",
|
||||
"AppImage"
|
||||
"AppImage",
|
||||
"snap"
|
||||
],
|
||||
"maintainer": "Akash Nimare <svnitakash@gmail.com>"
|
||||
"maintainer": "Akash Nimare <svnitakash@gmail.com>",
|
||||
"artifactName": "${productName}-${version}-${arch}.${ext}"
|
||||
},
|
||||
"deb": {
|
||||
"synopsis": "Zulip Desktop App",
|
||||
"afterInstall": "./scripts/debian-add-repo.sh",
|
||||
"afterRemove": "./scripts/debian-uninstaller.sh"
|
||||
},
|
||||
"snap": {
|
||||
"synopsis": "Zulip Desktop App"
|
||||
},
|
||||
"dmg": {
|
||||
"background": "build/appdmg.png",
|
||||
"icon": "build/icon.icns",
|
||||
"iconSize": 128,
|
||||
"iconSize": 100,
|
||||
"contents": [
|
||||
{
|
||||
"x": 380,
|
||||
"y": 240,
|
||||
"y": 280,
|
||||
"type": "link",
|
||||
"path": "/Applications"
|
||||
},
|
||||
{
|
||||
"x": 122,
|
||||
"y": 240,
|
||||
"x": 110,
|
||||
"y": 280,
|
||||
"type": "file"
|
||||
}
|
||||
]
|
||||
],
|
||||
"window": {
|
||||
"width": 500,
|
||||
"height": 500
|
||||
}
|
||||
},
|
||||
"win": {
|
||||
"target": [
|
||||
@@ -113,12 +123,12 @@
|
||||
"assert": "1.4.1",
|
||||
"cp-file": "^5.0.0",
|
||||
"devtron": "1.4.0",
|
||||
"electron": "1.8.4",
|
||||
"electron-builder": "19.53.6",
|
||||
"electron": "2.0.1",
|
||||
"electron-builder": "20.20.4",
|
||||
"electron-connect": "0.6.2",
|
||||
"electron-debug": "1.4.0",
|
||||
"google-translate-api": "2.3.0",
|
||||
"gulp": "3.9.1",
|
||||
"gulp": "^4.0.0",
|
||||
"gulp-tape": "0.0.9",
|
||||
"is-ci": "^1.0.10",
|
||||
"nodemon": "^1.14.11",
|
||||
|
@@ -15,6 +15,6 @@ fi
|
||||
|
||||
npm run test
|
||||
|
||||
if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
|
||||
npm run test-e2e
|
||||
fi
|
||||
# if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
|
||||
# npm run test-e2e
|
||||
# fi
|
||||
|
BIN
snap/gui/icon.png
Normal file
BIN
snap/gui/icon.png
Normal file
Binary file not shown.
After Width: | Height: | Size: 2.6 KiB |
37
snap/snapcraft.yaml
Normal file
37
snap/snapcraft.yaml
Normal file
@@ -0,0 +1,37 @@
|
||||
name: zulip
|
||||
version: 2.0.0
|
||||
summary: Zulip Desktop Client for Linux
|
||||
description: Zulip combines the immediacy of Slack with an email threading model. With Zulip, you can catch up on important conversations while ignoring irrelevant ones.
|
||||
confinement: strict
|
||||
grade: stable
|
||||
icon: snap/gui/icon.png
|
||||
apps:
|
||||
zulip:
|
||||
command: env TMPDIR=$XDG_RUNTIME_DIR desktop-launch $SNAP/zulip
|
||||
plugs:
|
||||
- desktop
|
||||
- desktop-legacy
|
||||
- home
|
||||
- x11
|
||||
- unity7
|
||||
- browser-support
|
||||
- network
|
||||
- gsettings
|
||||
- pulseaudio
|
||||
- opengl
|
||||
parts:
|
||||
app:
|
||||
plugin: dump
|
||||
stage-packages:
|
||||
- libasound2
|
||||
- libgconf2-4
|
||||
- libnotify4
|
||||
- libnspr4
|
||||
- libnss3
|
||||
- libpcre3
|
||||
- libpulse0
|
||||
- libxss1
|
||||
- libxtst6
|
||||
source: dist/linux-unpacked
|
||||
after:
|
||||
- desktop-gtk2
|
17
tests/test-new-organization.js
Normal file
17
tests/test-new-organization.js
Normal file
@@ -0,0 +1,17 @@
|
||||
const test = require('tape')
|
||||
const setup = require('./setup')
|
||||
|
||||
// Create new org link should open in the default browser [WIP]
|
||||
|
||||
test('new-org-link', function (t) {
|
||||
t.timeoutAfter(50e3)
|
||||
setup.resetTestDataDir()
|
||||
const app = setup.createApp()
|
||||
setup.waitForLoad(app, t)
|
||||
.then(() => app.client.windowByIndex(1)) // focus on webview
|
||||
.then(() => app.client.click('#open-create-org-link')) // Click on new org link button
|
||||
.then(() => setup.wait(5000))
|
||||
.then(() => setup.endTest(app, t),
|
||||
(err) => setup.endTest(app, t, err || 'error'))
|
||||
})
|
||||
|
81
tools/push-to-pull-request
Executable file
81
tools/push-to-pull-request
Executable file
@@ -0,0 +1,81 @@
|
||||
#!/bin/bash
|
||||
set -e
|
||||
|
||||
usage () {
|
||||
cat >&2 <<EOF
|
||||
usage: $0 PULL_REQUEST_ID [REMOTE]
|
||||
|
||||
Force-push our HEAD to the given GitHub pull request branch.
|
||||
|
||||
Useful for a maintainer to run just before pushing to master,
|
||||
after tweaking the branch and/or rebasing to latest. This causes
|
||||
GitHub to see the subsequent push to master as representing a
|
||||
merge of the PR, rather than requiring the PR to be manually
|
||||
(and to the casual observer misleadingly) closed instead.
|
||||
|
||||
REMOTE defaults to the value of the Git config variable
|
||||
\`zulip.zulipRemote\` if set, else to \`upstream\`.
|
||||
|
||||
See also \`reset-to-pull-request\`.
|
||||
EOF
|
||||
exit 1
|
||||
}
|
||||
|
||||
remote_default="$(git config zulip.zulipRemote || echo upstream)"
|
||||
|
||||
pr_id="$1"
|
||||
remote="${2:-"$remote_default"}"
|
||||
|
||||
if [ -z "$pr_id" ]; then
|
||||
usage
|
||||
fi
|
||||
|
||||
remote_url="$(git config remote."$remote".url)"
|
||||
repo_fq="$(echo "$remote_url" | perl -lne 'print $1 if (
|
||||
m, ^ git\@github\.com:
|
||||
([^/]+ / [^/]+?)
|
||||
(?:\.git)?
|
||||
$ ,x )')"
|
||||
|
||||
if [ -z "$repo_fq" ]; then
|
||||
# We're pretty specific about what we expect the URL to look like;
|
||||
# there are probably more cases we could legitimately cover, which
|
||||
# we can add if/when they come up for someone.
|
||||
echo "error: couldn't parse remote URL as GitHub repo" >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# See https://developer.github.com/v3/pulls/#get-a-single-pull-request .
|
||||
# This is the old REST API; the new GraphQL API does look neat, but it
|
||||
# seems to require authentication even for simple lookups of public data,
|
||||
# and that'd be a pain for a simple script like this.
|
||||
pr_url=https://api.github.com/repos/"${repo_fq}"/pulls/"${pr_id}"
|
||||
pr_details="$(curl -s "$pr_url")"
|
||||
|
||||
pr_jq () {
|
||||
echo "$pr_details" | jq "$@"
|
||||
}
|
||||
|
||||
if [ "$(pr_jq -r .message)" = "Not Found" ]; then
|
||||
echo "Invalid PR URL: $pr_url"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
if [ "$(pr_jq .maintainer_can_modify)" != "true" ]; then
|
||||
# This happens when the PR has already been merged or closed, or
|
||||
# if the contributor has turned off the (default) setting to allow
|
||||
# maintainers of the target repo to push to their PR branch.
|
||||
#
|
||||
# The latter seems to be rare (in Greg's experience doing the
|
||||
# manual equivalent of this script for many different
|
||||
# contributors, none have ever chosen this setting), but give a
|
||||
# decent error message if it does happen.
|
||||
echo "error: PR already closed, or contributor has disallowed pushing to branch" >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
pr_head_repo_fq="$(pr_jq -r .head.repo.full_name)"
|
||||
pr_head_refname="$(pr_jq -r .head.ref)"
|
||||
|
||||
set -x
|
||||
exec git push git@github.com:"$pr_head_repo_fq" +@:"$pr_head_refname"
|
18
tools/reinstall-node-modules.js
Normal file
18
tools/reinstall-node-modules.js
Normal file
@@ -0,0 +1,18 @@
|
||||
#!/usr/bin/env node
|
||||
const {exec} = require('child_process');
|
||||
const path = require('path');
|
||||
|
||||
const isWindows = process.platform === 'win32';
|
||||
const command = path.join(__dirname, `reinstall-node-modules${isWindows ? '.cmd' : ''}`);
|
||||
|
||||
const proc = exec(command, error => {
|
||||
if (error) {
|
||||
console.error(error);
|
||||
}
|
||||
});
|
||||
|
||||
proc.stdout.on('data', data => console.log(data.toString()));
|
||||
proc.stderr.on('data', data => console.error(data.toString()));
|
||||
proc.on('exit', code => {
|
||||
process.exit(code);
|
||||
});
|
19
tools/reset-to-pull-request
Executable file
19
tools/reset-to-pull-request
Executable file
@@ -0,0 +1,19 @@
|
||||
#!/bin/bash
|
||||
set -e
|
||||
|
||||
if ! git diff-index --quiet HEAD; then
|
||||
set +x
|
||||
echo "There are uncommitted changes:"
|
||||
git status --short
|
||||
echo "Doing nothing to avoid losing your work."
|
||||
exit 1
|
||||
fi
|
||||
|
||||
remote_default="$(git config zulip.zulipRemote || echo upstream)"
|
||||
|
||||
request_id="$1"
|
||||
remote=${2:-"$remote_default"}
|
||||
|
||||
set -x
|
||||
git fetch "$remote" "pull/$request_id/head"
|
||||
git reset --hard FETCH_HEAD
|
Reference in New Issue
Block a user