paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-22 20:42:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

slack_import: Don't use a tag for form submission.

Browse Source 
This can mislead user into thinking this is a link they can
open in a new tab, which we don't want to allow.
This commit is contained in:
Aman Agrawal
2025-08-21 16:16:23 +05:30
committed by Tim Abbott
parent 203e8be1df
commit 04fa43e1df
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
templates/zerver/slack_import.html
View File

@@ -100,7 +100,7 @@
</form>
<div class="bottom-text">
{% trans %}
Or <a href="#" id="cancel-slack-import">create organization</a> without importing data.
Or <span id="cancel-slack-import" tabindex="0">create organization</span> without importing data.
{% endtrans %}
</div>
{% endif %}

12
web/styles/portico/portico_signin.css
View File

@@ -1556,3 +1556,15 @@ button#register_auth_button_gitlab {
overflow: hidden;
white-space: nowrap;
}
#cancel-slack-import {
color: hsl(200deg 100% 40%);
text-decoration: none;
&:hover,
&:focus {
cursor: pointer;
color: hsl(200.16deg 100% 25.1%);
text-decoration: underline;
}
}