paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

buddy_list: Don't recalculate total_human_subscribers_count for tippy.

Browse Source 
This is still accessible if we make an accessor function in the tooltip
function's scope before the event handler that changes the `this` reference.
This commit is contained in:
evykassirer
2025-03-03 17:42:36 -08:00
committed by Tim Abbott
parent 52fe67e698
commit 064533ba37
1 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
web/src/buddy_list.ts
View File

@@ -167,6 +167,9 @@ export class BuddyList extends BuddyListConf {
current_filter: Filter | undefined | "unset" = "unset";
initialize_tooltips(): void {
const total_human_subscribers_count = (): number =>
this.render_data.total_human_subscribers_count;
$("#right-sidebar").on(
"mouseenter",
".buddy-list-heading",
@@ -198,12 +201,6 @@ export class BuddyList extends BuddyListConf {
showOnCreate: true,
onShow(instance) {
let tooltip_text;
const current_sub = narrow_state.stream_sub();
const pm_ids_set = narrow_state.pm_ids_set();
const total_human_subscribers_count = get_total_human_subscriber_count(
current_sub,
pm_ids_set,
);
const participant_count = Number.parseInt(
$("#buddy-list-participants-section-heading").attr("data-user-count")!,
10,
@@ -224,15 +221,15 @@ export class BuddyList extends BuddyListConf {
defaultMessage:
"{N, plural, one {# other subscriber} other {# other subscribers}}",
},
{N: total_human_subscribers_count - participant_count},
{N: total_human_subscribers_count() - participant_count},
);
} else if (current_sub) {
} else if (narrow_state.stream_sub()) {
tooltip_text = $t(
{
defaultMessage:
"{N, plural, one {# subscriber} other {# subscribers}}",
},
{N: total_human_subscribers_count},
{N: total_human_subscribers_count()},
);
} else {
tooltip_text = $t(
@@ -240,12 +237,12 @@ export class BuddyList extends BuddyListConf {
defaultMessage:
"{N, plural, one {# participant} other {# participants}}",
},
{N: total_human_subscribers_count},
{N: total_human_subscribers_count()},
);
}
} else {
const other_users_count =
people.get_active_human_count() - total_human_subscribers_count;
people.get_active_human_count() - total_human_subscribers_count();
tooltip_text = $t(
{
defaultMessage: