paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

streams: Grant authorization to guest users to subscribe.

Browse Source 
Modifies filter_stream_authorization so that web-public streams are
added in the list of authorized streams that a guest user can
subscribe.

This commit is part of PR #14638 that aims to allow guest users
to browse and subscribe to web-public streams.
This commit is contained in:
Clara Dantas
2020-07-24 00:30:58 -03:00
committed by Tim Abbott
parent e22e12fe60
commit 0994b029d6
2 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/lib/streams.py
View File

@@ -408,6 +408,10 @@ def filter_stream_authorization(user_profile: UserProfile,
if stream.id in streams_subscribed:
continue
# Web public streams are accessible even to guests
if stream.is_web_public:
continue
# Members and administrators are authorized for public streams
if not stream.invite_only and not user_profile.is_guest:
continue

15
zerver/tests/test_subs.py
View File

@@ -2871,6 +2871,21 @@ class SubscriptionAPITest(ZulipTestCase):
self.assertEqual(filter_stream_authorization(guest_user, [stream]),
([], [stream]))
web_public_stream = self.make_stream('web_public_stream', is_web_public=True)
public_stream = self.make_stream('public_stream', invite_only=False)
private_stream = self.make_stream('private_stream2', invite_only=True)
# This test should be added as soon as the subscription endpoint allows
# guest users to subscribe to web public streams. Although they are already
# authorized, the decorator in "add_subscriptions_backend" still needs to be
# deleted.
#
# result = self.common_subscribe_to_streams(guest_user, ['web_public_stream'],
# is_web_public=True, allow_fail=True)
# self.assert_json_success(result)
streams_to_sub = [web_public_stream, public_stream, private_stream]
self.assertEqual(filter_stream_authorization(guest_user, streams_to_sub),
([web_public_stream], [public_stream, private_stream]))
def test_users_getting_add_peer_event(self) -> None:
"""
Check users getting add_peer_event is correct