paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change HTTP verb for create_user_backend to PUT (#1326)

Browse Source
This commit is contained in:
acrefoot
2016-07-20 12:57:47 -07:00
committed by GitHub
parent 2484d870b4
commit 0dfb76fc5e
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
zerver/tests/tests.py
View File

@@ -247,20 +247,20 @@ class AdminCreateUserTest(AuthedTestCase):
admin = get_user_profile_by_email(admin_email)
do_change_is_admin(admin, True)
result = self.client.post("/json/users", dict(
result = self.client_put("/json/users", dict(
user_profile=admin,
)
)
self.assert_json_error(result, "Missing 'email' argument")
result = self.client.post("/json/users", dict(
result = self.client_put("/json/users", dict(
user_profile=admin,
email='romeo@not-zulip.com',
)
)
self.assert_json_error(result, "Missing 'password' argument")
result = self.client.post("/json/users", dict(
result = self.client_put("/json/users", dict(
user_profile=admin,
email='romeo@not-zulip.com',
password='xxxx',
@@ -268,7 +268,7 @@ class AdminCreateUserTest(AuthedTestCase):
)
self.assert_json_error(result, "Missing 'full_name' argument")
result = self.client.post("/json/users", dict(
result = self.client_put("/json/users", dict(
user_profile=admin,
email='romeo@not-zulip.com',
password='xxxx',
@@ -277,7 +277,7 @@ class AdminCreateUserTest(AuthedTestCase):
)
self.assert_json_error(result, "Missing 'short_name' argument")
result = self.client.post("/json/users", dict(
result = self.client_put("/json/users", dict(
user_profile=admin,
email='broken',
password='xxxx',
@@ -287,7 +287,7 @@ class AdminCreateUserTest(AuthedTestCase):
)
self.assert_json_error(result, "Bad name or username")
result = self.client.post("/json/users", dict(
result = self.client_put("/json/users", dict(
user_profile=admin,
email='romeo@not-zulip.com',
password='xxxx',
@@ -306,7 +306,7 @@ class AdminCreateUserTest(AuthedTestCase):
full_name='Romeo Montague',
short_name='Romeo',
)
result = self.client.post("/json/users", valid_params)
result = self.client_put("/json/users", valid_params)
self.assert_json_success(result)
new_user = get_user_profile_by_email('romeo@zulip.com')
@@ -315,7 +315,7 @@ class AdminCreateUserTest(AuthedTestCase):
# One more error condition to test--we can't create
# the same user twice.
result = self.client.post("/json/users", valid_params)
result = self.client_put("/json/users", valid_params)
self.assert_json_error(result,
"Email 'romeo@zulip.com' already in use")

2
zproject/urls.py
View File

@@ -136,7 +136,7 @@ v1_api_and_json_patterns = [
# users -> zerver.views.users
url(r'^users$', 'zerver.lib.rest.rest_dispatch',
{'GET': 'zerver.views.users.get_members_backend',
'POST': 'zerver.views.users.create_user_backend'}),
'PUT': 'zerver.views.users.create_user_backend'}),
url(r'^users/(?P<email>(?!me)[^/]*)/reactivate$', 'zerver.lib.rest.rest_dispatch',
{'POST': 'zerver.views.users.reactivate_user_backend'}),
url(r'^users/(?P<email>(?!me)[^/]*)$', 'zerver.lib.rest.rest_dispatch',