paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose and feed: Improve label for DMs to yourself.

Browse Source
This commit is contained in:
Alya Abbott
2025-09-26 09:23:17 -07:00
committed by Tim Abbott
parent 8b8d23cc5f
commit 0ea04f31bc
5 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/compose_ui.ts
View File

@@ -460,7 +460,7 @@ export function compute_placeholder_text(opts: ComposePlaceholderOptions): strin
} else if (opts.direct_message_user_ids.length > 0) { } else if (opts.direct_message_user_ids.length > 0) {
const user_ids = opts.direct_message_user_ids; const user_ids = opts.direct_message_user_ids;
if (people.is_direct_message_conversation_with_self(user_ids)) { if (people.is_direct_message_conversation_with_self(user_ids)) {
return $t({defaultMessage: "Message yourself"}); return $t({defaultMessage: "Write yourself a note"});
} }
const users = people.get_users_from_ids(user_ids); const users = people.get_users_from_ids(user_ids);
const recipient_parts = users.map((user) => { const recipient_parts = users.map((user) => {

3
web/src/narrow_banner.ts
View File

@@ -373,8 +373,7 @@ export function pick_empty_narrow_banner(current_filter: Filter): NarrowBannerDa
if (people.is_my_user_id(recipient_user.user_id)) { if (people.is_my_user_id(recipient_user.user_id)) {
return { return {
title: $t({ title: $t({
defaultMessage: defaultMessage: "You haven't sent yourself any notes yet!",
"You have not sent any direct messages to yourself yet!",
}), }),
html: $t_html({ html: $t_html({
defaultMessage: defaultMessage:

2
web/templates/reply_recipient_label.hbs
View File

@@ -1,6 +1,6 @@
{{#if is_dm_with_self}} {{#if is_dm_with_self}}
{{#tr}} {{#tr}}
Message yourself Write yourself a note
{{/tr}} {{/tr}}
{{else}} {{else}}
{{#tr}} {{#tr}}

2
web/tests/compose_closed_ui.test.cjs
View File

@@ -222,7 +222,7 @@ run_test("test_non_message_list_input", () => {
user_ids: [current_user.user_id], user_ids: [current_user.user_id],
}); });
let label = $("#left_bar_compose_reply_button_big").html(); let label = $("#left_bar_compose_reply_button_big").html();
assert.equal(label, "Message yourself"); assert.equal(label, "Write yourself a note");
// Invalid data for a the reply button text. // Invalid data for a the reply button text.
compose_closed_ui.update_recipient_text_for_reply_button({ compose_closed_ui.update_recipient_text_for_reply_button({

2
web/tests/message_view.test.cjs
View File

@@ -472,7 +472,7 @@ run_test("show_empty_narrow_message", ({mock_template, override}) => {
assert.equal( assert.equal(
$(".empty_feed_notice_main").html(), $(".empty_feed_notice_main").html(),
empty_narrow_html( empty_narrow_html(
"translated: You have not sent any direct messages to yourself yet!", "translated: You haven't sent yourself any notes yet!",
"translated HTML: Use this space for personal notes, or to test out Zulip features.", "translated HTML: Use this space for personal notes, or to test out Zulip features.",
), ),
); );