paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_settings: Flush cache after commiting changes to DB.

Browse Source 
We should flush the cache after commiting changes to DB to
make sure that the cache does not contain stale data when
updating multiple settings in a single request.
This commit is contained in:
Sahil Batra
2024-07-17 12:53:34 +05:30
committed by Tim Abbott
parent e1f3c54a1d
commit 0ea5daece8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/actions/user_settings.py
View File

@@ -472,6 +472,8 @@ def do_change_user_setting(
assert isinstance(setting_value, str)
event["language_name"] = get_language_name(setting_value)
transaction.on_commit(lambda: flush_user_profile(sender=UserProfile, instance=user_profile))
send_event_on_commit(user_profile.realm, event, [user_profile.id])
if setting_name in {"web_font_size_px", "web_line_height_percent"}:
@@ -545,8 +547,6 @@ def do_change_user_setting(
user_profile.email = get_display_email_address(user_profile)
user_profile.save(update_fields=["email"])
transaction.on_commit(lambda: flush_user_profile(sender=UserProfile, instance=user_profile))
send_user_email_update_event(user_profile)
notify_avatar_url_change(user_profile)