paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

zjsunit: Rename module argument to obj.

Browse Source 
Due to recent changes, `with_overrides` is no longer
constrained to overriding module methods.  You can
override methods on any type of object.
This commit is contained in:
Steve Howell
2021-02-12 14:47:26 +00:00
committed by Steve Howell
parent 21cb0d1547
commit 1598344fa7
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
frontend_tests/zjsunit/namespace.js
View File

@@ -98,16 +98,22 @@ exports.with_overrides = function (test_function) {
const unused_funcs = new Map();
const funcs = new Map();
const override = function (module, func_name, f) {
const override = function (obj, func_name, f) {
// Given an object `obj` (which is usually a module object),
// we re-map `obj[func_name]` to the `f` passed in by the caller.
// Then the outer function here (`with_overrides`) automatically
// restores the original value of `obj[func_name]` as its last
// step. Generally our code calls `run_test`, which wraps
// `with_overrides`.
if (typeof f !== "function") {
throw new TypeError("You can only override with a function.");
}
if (!funcs.has(module)) {
funcs.set(module, new Map());
if (!funcs.has(obj)) {
funcs.set(obj, new Map());
}
if (funcs.get(module).has(func_name)) {
if (funcs.get(obj).has(func_name)) {
// Prevent overriding the same function twice, so that
// it's super easy to reason about our logic to restore
// the original function. Usually if somebody sees this
@@ -117,22 +123,22 @@ exports.with_overrides = function (test_function) {
);
}
funcs.get(module).set(func_name, true);
funcs.get(obj).set(func_name, true);
if (!unused_funcs.has(module)) {
unused_funcs.set(module, new Map());
if (!unused_funcs.has(obj)) {
unused_funcs.set(obj, new Map());
}
unused_funcs.get(module).set(func_name, true);
unused_funcs.get(obj).set(func_name, true);
const old_f = module[func_name];
module[func_name] = function (...args) {
unused_funcs.get(module).delete(func_name);
const old_f = obj[func_name];
obj[func_name] = function (...args) {
unused_funcs.get(obj).delete(func_name);
return f.apply(this, args);
};
restore_callbacks.push(() => {
module[func_name] = old_f;
obj[func_name] = old_f;
});
};