jotform: Strengthen types using WildValue.

This commit is contained in:
Hari Prashant Bhimaraju
2022-10-08 22:50:18 +05:30
committed by Tim Abbott
parent 537632d58c
commit 1ac9573a67

View File

@@ -1,11 +1,11 @@
# Webhooks for external integrations. # Webhooks for external integrations.
from typing import Any, Dict
from django.http import HttpRequest, HttpResponse from django.http import HttpRequest, HttpResponse
from zerver.decorator import webhook_view from zerver.decorator import webhook_view
from zerver.lib.request import REQ, has_request_variables from zerver.lib.request import REQ, has_request_variables
from zerver.lib.response import json_success from zerver.lib.response import json_success
from zerver.lib.validator import WildValue, check_string, to_wild_value
from zerver.lib.webhooks.common import check_send_webhook_message from zerver.lib.webhooks.common import check_send_webhook_message
from zerver.models import UserProfile from zerver.models import UserProfile
@@ -15,11 +15,11 @@ from zerver.models import UserProfile
def api_jotform_webhook( def api_jotform_webhook(
request: HttpRequest, request: HttpRequest,
user_profile: UserProfile, user_profile: UserProfile,
payload: Dict[str, Any] = REQ(argument_type="body"), payload: WildValue = REQ(argument_type="body", converter=to_wild_value),
) -> HttpResponse: ) -> HttpResponse:
topic = payload["formTitle"] topic = payload["formTitle"].tame(check_string)
submission_id = payload["submissionID"] submission_id = payload["submissionID"].tame(check_string)
fields_dict = list(payload["pretty"].split(", ")) fields_dict = list(payload["pretty"].tame(check_string).split(", "))
form_response = f"A new submission (ID {submission_id}) was received:\n" form_response = f"A new submission (ID {submission_id}) was received:\n"
for field in fields_dict: for field in fields_dict: