paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-26 17:43:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

portico: Make the realm icon an img element.

Browse Source 
The realm avatar icon on the login and registration pages was
being set as a background image, which could vanish in high
contrast mode in many browsers.  Converted it to an img tag and
verified that it is still styled correctly.  I think the empty
alt attribute (to remove it from the audio description) is
appropriate in this context, since the realm name and description
are already provided immediately afterwards in the page content.

Fixes #4889.
This commit is contained in:
Jeremy Bowman
2017-05-25 17:27:59 -07:00
committed by Tim Abbott
parent bf2bc8d44b
commit 2137aadda0
3 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/styles/portico-signin.css
View File

@@ -492,8 +492,6 @@ html {
width: 100px;
height: 100px;
background-size: 100% auto;
}
.split-view .org-header .info-box {

2
templates/zerver/accounts_home.html
View File

@@ -21,7 +21,7 @@ $(function () {
{% if realm_name %}
<div class="left-side">
<div class="org-header">
<div class="avatar" style="background-image: url('{{ realm_icon }}')"></div>
<img class="avatar" src="{{ realm_icon }}" alt="" />
<div class="info-box">
<div class="organization-name">{{ realm_name }}</div>
<div class="organization-path">{{ realm_uri }}</div>

2
templates/zerver/login.html
View File

@@ -60,7 +60,7 @@ autofocus('#id_username');
{% if realm_name %}
<div class="left-side">
<div class="org-header">
<div class="avatar" style="background-image: url('{{ realm_icon }}')"></div>
<img class="avatar" src="{{ realm_icon }}" alt="" />
<div class="info-box">
<div class="organization-name">{{ realm_name }}</div>
<div class="organization-path">{{ realm_uri }}</div>