paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Extract people.get_users_from_ids.

Browse Source
This commit is contained in:
Steve Howell
2021-12-15 15:49:15 +00:00
committed by Tim Abbott
parent 6c9427340a
commit 2194a51b97
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/people.js
View File

@@ -55,6 +55,10 @@ function split_to_ints(lst) {
return lst.split(",").map((s) => Number.parseInt(s, 10));
}
export function get_users_from_ids(user_ids) {
return user_ids.map((user_id) => get_by_user_id(user_id));
}
export function get_by_user_id(user_id, ignore_missing) {
if (!people_by_user_id_dict.has(user_id) && !ignore_missing) {
blueslip.error("Unknown user_id in get_by_user_id: " + user_id);

6
static/js/stream_edit.js
View File

@@ -73,10 +73,6 @@ export function is_sub_settings_active(sub) {
return false;
}
export function get_users_from_subscribers(subscribers) {
return subscribers.map((user_id) => people.get_by_user_id(user_id));
}
export function get_retention_policy_text_for_subscription_type(sub) {
let message_retention_days = sub.message_retention_days;
// If both this stream and the organization-level policy are to retain forever,
@@ -401,7 +397,7 @@ function enable_subscriber_management({sub, parent_container}) {
list.empty();
const user_ids = peer_data.get_subscribers(stream_id);
const users = get_users_from_subscribers(user_ids);
const users = people.get_users_from_ids(user_ids);
people.sort_but_pin_current_user_on_top(users);
function get_users_for_subscriber_typeahead() {

4
static/js/stream_ui_updates.js
View File

@@ -178,8 +178,8 @@ export function update_subscribers_list(sub) {
if (!stream_data.can_view_subscribers(sub)) {
$(".subscriber_list_settings_container").hide();
} else {
const subscribers = peer_data.get_subscribers(sub.stream_id);
const users = stream_edit.get_users_from_subscribers(subscribers);
const subscriber_ids = peer_data.get_subscribers(sub.stream_id);
const users = people.get_users_from_ids(subscriber_ids);
/*
We try to find a subscribers list that is already in the