paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

banners: Fix asymmetric margin on banners.

Browse Source 
This commit fixes the asymmetric margin on banners by conditionally
rendering the action buttons only if buttons are present. Otherwise,
empty action buttons were being rendered in the DOM, applying the gap
property between the banner label and the empty action buttons.

Fixes: https://chat.zulip.org/#narrow/channel/9-issues/topic/asymmetric.20margin.20on.20banner.
This commit is contained in:
Maneesh Shukla
2025-08-09 23:15:34 +05:30
committed by Tim Abbott
parent 00f0b58ee4
commit 224fd3df6b
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
web/templates/components/banner.hbs
View File

@@ -7,15 +7,17 @@
{{> @partial-block .}}
{{/if}}
</span>
<span class="banner-action-buttons">
{{#each buttons}}
{{#if this.intent}}
{{> action_button .}}
{{else}}
{{> action_button . intent=../intent}}
{{/if}}
{{/each}}
</span>
{{#if buttons}}
<span class="banner-action-buttons">
{{#each buttons}}
{{#if this.intent}}
{{> action_button .}}
{{else}}
{{> action_button . intent=../intent}}
{{/if}}
{{/each}}
</span>
{{/if}}
</span>
{{#if close_button}}
{{> icon_button custom_classes="banner-close-action banner-close-button" icon="close" intent=intent}}