paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hide "Announce stream" if realm has no "announce" stream.

Browse Source 
When you create a stream, there was always an "Announce stream"
option that would be enabled for public streams.

We are about to make it so that we never send PMs to announce
new streams to folks, so the only mechanism will be sending a message
to the realm's notification stream.  If a realm has no notifications
stream, the decision is moot, so we hide the option.
This commit is contained in:
Steve Howell
2017-05-16 09:34:36 -07:00
committed by Tim Abbott
parent c549dea9ac
commit 22c1231222
1 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
static/js/stream_create.js
View File

@@ -109,6 +109,13 @@ function ajaxSubscribeForCreation(stream, description, principals, invite_only,
// Within the new stream modal...
function update_announce_stream_state() {
// If there is no notifications_stream, we simply hide the widget.
if (!page_params.notifications_stream) {
$('#announce-new-stream').hide();
return;
}
// If the stream is invite only, or everyone's added, disable
// the "Announce stream" option. Otherwise enable it.
var announce_stream_checkbox = $('#announce-new-stream input');
@@ -124,6 +131,7 @@ function update_announce_stream_state() {
}
announce_stream_checkbox.prop('disabled', disable_it);
$('#announce-new-stream').show();
}
exports.new_stream_clicked = function (stream) {
@@ -170,8 +178,14 @@ exports.show_new_stream_modal = function () {
// Make the options default to the same each time:
// public, "announce stream" on.
$('#make-invite-only input:radio[value=public]').prop('checked', true);
$('#announce-new-stream input').prop('disabled', false);
$('#announce-new-stream input').prop('checked', true);
if (page_params.notifications_stream) {
$('#announce-new-stream').show();
$('#announce-new-stream input').prop('disabled', false);
$('#announce-new-stream input').prop('checked', true);
} else {
$('#announce-new-stream').hide();
}
stream_name_error.clear_errors();
@@ -289,11 +303,14 @@ $(function () {
created_stream = stream;
var announce = (!!page_params.notifications_stream &&
$('#announce-new-stream input').prop('checked'));
ajaxSubscribeForCreation(stream,
description,
principals,
$('#stream_creation_form input[name=privacy]:checked').val() === "invite-only",
$('#announce-new-stream input').prop('checked')
announce
);
});