paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

slack import: Merge and dedupe same-base emoji reactions and userlists.

Browse Source 
The naive solution #23465 creates situations where the same user can have
multiple reactions as the base emojis are not unique, e.g. +1::skin2
and +1::skin4 would both reduce to +1 but the userlists are separate.
This solution handles the reduction, merges the same-base reactions,
and deduplicates the userlist.

Co-authored-by: Alex Vandiver <alexmv@zulip.com>
Co-authored-by: rht <rhtbot@protonmail.com>
This commit is contained in:
M@
2022-11-16 14:11:43 -05:00
committed by GitHub
parent 6f1a341d2d
commit 280523ad48
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
zerver/data_import/slack.py
View File

@@ -1120,14 +1120,22 @@ def build_reactions(
for realm_emoji in zerver_realmemoji:
realmemoji[realm_emoji["name"]] = realm_emoji["id"]
# Slack's data exports use encode skin tone variants on emoji
# reactions like this: `clap::skin-tone-2`. For now, we only
# use the name of the base emoji, since Zulip's emoji
# reactions system doesn't yet support skin tone modifiers.
# We need to merge and dedup reactions, as someone may have
# reacted to `clap::skin-tone-1` and `clap::skin-tone-2`, etc.
merged_reactions = defaultdict(set)
for slack_reaction in reactions:
emoji_name = slack_reaction["name"].split("::", maxsplit=1)[0]
merged_reactions[emoji_name].update(slack_reaction["users"])
reactions = [{"name": k, "users": v, "count": len(v)} for k, v in merged_reactions.items()]
# For the Unicode emoji codes, we use equivalent of
# function 'emoji_name_to_emoji_code' in 'zerver/lib/emoji' here
for slack_reaction in reactions:
# Slack's data exports use encode skin tone variants on emoji
# reactions like this: `clap::skin-tone-2`. For now, we only
# use the name of the base emoji, since Zulip's emoji
# reactions system doesn't yet support skin tone modifiers.
emoji_name = slack_reaction["name"].split("::", maxsplit=1)[0]
emoji_name = slack_reaction["name"]
if emoji_name in slack_emoji_name_to_codepoint:
emoji_code = slack_emoji_name_to_codepoint[emoji_name]
try: