paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 12:33:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

dropdown_list_widget: Add 'type' attribute to template.

Browse Source 
Previously, when the user presses 'Enter' within a input
field while keyboard focus in is in the topic edit textbox
it incorrectly opened the dropdown list widget.

This is because the dropdown button had the default type attribute of
'submit' which triggers the click event binded to it.  Fix it by
explicitly defining it's type attribute to be a button.

Fixes #18415
This commit is contained in:
aryanshridhar
2021-05-14 00:44:40 +05:30
committed by Tim Abbott
parent 352acdcc36
commit 2e334bec89
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/templates/settings/dropdown_list_widget.hbs
View File

@@ -5,7 +5,7 @@
{{ label }}
</label>
{{/if}}
<button class="button small rounded dropdown-toggle" data-toggle="dropdown">
<button class="button small rounded dropdown-toggle" type="button" data-toggle="dropdown">
<span id="{{widget_name}}_name"></span>
<i class="fa fa-pencil"></i>
</button>