scim: Make "id" a string in our responses.

In SCIM, this is always a string, even if numerical. While SCIM clients
seem to handle our prior behavior, this was a bug nonetheless.

zerver/lib/scim.py

@@ -102,7 +102,7 @@ class ZulipSCIMUser(SCIMUser):
 
         return {
             "schemas": [scim_constants.SchemaURI.USER],
-            "id": self.obj.id,
+            "id": str(self.obj.id),
             "userName": self.obj.delivery_email,
             "name": name,
             "displayName": self.display_name,

zerver/tests/test_scim.py

@@ -34,7 +34,7 @@ class SCIMTestCase(ZulipTestCase):
     def generate_user_schema(self, user_profile: UserProfile) -> dict[str, Any]:
         return {
             "schemas": ["urn:ietf:params:scim:schemas:core:2.0:User"],
-            "id": user_profile.id,
+            "id": str(user_profile.id),
             "userName": user_profile.delivery_email,
             "name": {"formatted": user_profile.full_name},
             "displayName": user_profile.full_name,