paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-22 20:42:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

custom_profile_fields: Refactor code for handling date type fields.

Browse Source 
The currrent behavior is to auto-save field immediately on changing
the value only in "Profile" settings panel but not in "Manage user"
modal where we save the changes only after clicking "Save changes"
button.

To enable this behavior we checked if the date type field is being
changed for user's own account or for other user. But now we will
show "Manage user" modal in user's own profile as well so to enable
the above mentioned behavior we now use for_profile_settings_panel
boolean field.
This commit is contained in:
whilstsomebody
2025-08-11 23:49:22 +05:30
committed by Tim Abbott
parent feaaf9ff03
commit 30c6b35b95
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web/src/custom_profile_fields_ui.ts
View File

@@ -209,7 +209,11 @@ export function format_date(date: Date | undefined, format: string): string {
return flatpickr.formatDate(date, format);
}
export function initialize_custom_date_type_fields(element_id: string, user_id: number): void {
export function initialize_custom_date_type_fields(
element_id: string,
user_id: number,
for_profile_settings_panel = false,
): void {
const $date_picker_elements = $(element_id).find(".custom_user_field .datepicker");
if ($date_picker_elements.length === 0) {
return;
@@ -224,7 +228,7 @@ export function initialize_custom_date_type_fields(element_id: string, user_id:
// our case it is a valid value when user does not want
// to set any value for the custom profile field.
if ($input_elem.parent().find(".date-field-alt-input").val() === "") {
if (user_id !== people.my_current_user_id()) {
if (!for_profile_settings_panel) {
// For "Manage user" modal, API request is made after
// clicking on "Save changes" button.
return;
@@ -246,7 +250,7 @@ export function initialize_custom_date_type_fields(element_id: string, user_id:
);
const original_value = people.get_custom_profile_data(user_id, field_id)?.value ?? "";
instance.setDate(original_value);
if (user_id !== people.my_current_user_id()) {
if (!for_profile_settings_panel) {
// Trigger "input" event so that save button state can
// be toggled in "Manage user" modal.
$input_elem
@@ -257,7 +261,7 @@ export function initialize_custom_date_type_fields(element_id: string, user_id:
return;
}
if (user_id !== people.my_current_user_id()) {
if (!for_profile_settings_panel) {
// For "Manage user" modal, API request is made after
// clicking on "Save changes" button.
return;

1
web/src/settings_account.ts
View File

@@ -236,6 +236,7 @@ export function add_custom_profile_fields_to_settings(): void {
custom_profile_fields_ui.initialize_custom_date_type_fields(
element_id,
people.my_current_user_id(),
true,
);
custom_profile_fields_ui.initialize_custom_pronouns_type_fields(element_id);
}