mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-03 21:43:21 +00:00 
			
		
		
		
	Fix AsyncDjangoHandler view exception code path.
The recent Tornado memory leak fix
(1396eb7022) didn't use the correct
variable name for the current handler ID, causing this cleanup code to
fail in the event that a view raised an exception.
			
			
This commit is contained in:
		@@ -245,7 +245,7 @@ class AsyncDjangoHandler(tornado.web.RequestHandler, base.BaseHandler):
 | 
			
		||||
                            async_request_stop(request)
 | 
			
		||||
                            return None
 | 
			
		||||
                    except Exception as e:
 | 
			
		||||
                        clear_handler_by_id(self.current_handler_id)
 | 
			
		||||
                        clear_handler_by_id(self.handler_id)
 | 
			
		||||
                        # If the view raised an exception, run it through exception
 | 
			
		||||
                        # middleware, and if the exception middleware returns a
 | 
			
		||||
                        # response, use that. Otherwise, reraise the exception.
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user