paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

notify_local_mixes: Reorder for better readability.

Browse Source 
No functional changes, just simpler conditionals.
This commit is contained in:
Tim Abbott
2025-07-29 12:48:59 -07:00
parent e5ca153673
commit 3c6c2c1d5a
1 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
web/src/compose_notifications.ts
View File

@@ -268,21 +268,8 @@ export function notify_local_mixes(
continue;
}
const jump_to_sent_message_conversation = should_jump_to_sent_message_conversation(message);
const show_narrow_to_recipient_banner = should_show_narrow_to_recipient_banner(message);
const link_msg_id = message.id;
if (!jump_to_sent_message_conversation && !show_narrow_to_recipient_banner) {
if (need_user_to_scroll) {
show_scroll_to_view_banner(link_msg_id);
}
// This is the HAPPY PATH--for most messages we do nothing
// other than maybe sending the above message.
continue;
}
const show_narrow_to_recipient_banner = should_show_narrow_to_recipient_banner(message);
if (show_narrow_to_recipient_banner) {
const banner_text = $t({
defaultMessage: "Sent! Your message is outside your current view.",
@@ -298,6 +285,17 @@ export function notify_local_mixes(
continue;
}
const jump_to_sent_message_conversation = should_jump_to_sent_message_conversation(message);
if (!jump_to_sent_message_conversation) {
if (need_user_to_scroll) {
show_scroll_to_view_banner(link_msg_id);
}
// This is the HAPPY PATH--for most messages we do nothing
// other than maybe showing the above banner.
continue;
}
narrow_to_recipient(link_msg_id);
if (onboarding_steps.ONE_TIME_NOTICES_TO_DISPLAY.has("jump_to_conversation_banner")) {