refactor: Extract send_peer_add_events.

This commit is contained in:
Steve Howell
2020-10-12 20:34:32 +00:00
committed by Tim Abbott
parent 5d6f3eef29
commit 3ff9ce78ea

View File

@@ -2946,6 +2946,25 @@ def bulk_add_subscriptions(streams: Iterable[Stream],
notify_subscriptions_added(user_profile, sub_pairs, fetch_stream_subscriber_user_ids,
recent_traffic)
send_peer_add_events(
realm=realm,
users=users,
new_streams=new_streams,
streams=streams,
all_subscribers_by_stream=all_subscribers_by_stream,
)
return ([(user_profile, stream) for (user_profile, recipient_id, stream) in new_subs] +
[(sub.user_profile, stream) for (sub, stream) in subs_to_activate],
already_subscribed)
def send_peer_add_events(
realm: Realm,
users: List[UserProfile],
streams: Iterable[Stream],
new_streams: Set[Tuple[int, int]],
all_subscribers_by_stream: Dict[int, List[int]],
) -> None:
# The second batch is events for other users who are tracking the
# subscribers lists of streams in their browser; everyone for
# public streams and only existing subscribers for private streams.
@@ -2969,10 +2988,6 @@ def bulk_add_subscriptions(streams: Iterable[Stream],
user_id=new_user_id)
send_event(realm, event, peer_user_ids)
return ([(user_profile, stream) for (user_profile, recipient_id, stream) in new_subs] +
[(sub.user_profile, stream) for (sub, stream) in subs_to_activate],
already_subscribed)
def get_available_notification_sounds() -> List[str]:
notification_sounds_path = static_path('audio/notification_sounds')
available_notification_sounds = []