paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

puppeteer_tests: Correct {visible: false} to {hidden: true}.

Browse Source 
{visible: false} just redundantly specifies the default behavior,
which is to wait for the selector to be present regardless of
visibility.  We want to wait for these selectors to be hidden.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-03-11 13:48:43 -08:00
committed by Tim Abbott
parent 20fd9b1dec
commit 4256567b4a
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
frontend_tests/puppeteer_tests/08-admin.ts
View File

@@ -300,7 +300,7 @@ async function test_upload_realm_icon_image(page: Page): Promise<void> {
visible: true,
});
await page.waitForSelector("#realm-icon-upload-widget .upload-spinner-background", {
visible: false,
hidden: true,
});
await page.waitForSelector(
'#realm-icon-upload-widget .image-block[src^="/user_avatars/2/realm/icon.png?version=2"]',
@@ -312,7 +312,7 @@ async function delete_realm_icon(page: Page): Promise<void> {
await page.click("li[data-section='organization-profile']");
await page.click("#realm-icon-upload-widget .image-delete-button");
await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {visible: false});
await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {hidden: true});
}
async function test_organization_profile(page: Page): Promise<void> {
@@ -320,13 +320,13 @@ async function test_organization_profile(page: Page): Promise<void> {
const gravatar_selctor =
'#realm-icon-upload-widget .image-block[src^="https://secure.gravatar.com/avatar/"]';
await page.waitForSelector(gravatar_selctor, {visible: true});
await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {visible: false});
await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {hidden: true});
await test_upload_realm_icon_image(page);
await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {visible: true});
await delete_realm_icon(page);
await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {visible: false});
await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {hidden: true});
await page.waitForSelector(gravatar_selctor, {visible: true});
}
@@ -337,7 +337,7 @@ async function submit_default_user_settings(page: Page): Promise<void> {
);
await page.click("#org-submit-user-defaults");
const saved_status = '#org-submit-user-defaults[data-status="saved"]';
await page.waitForSelector(saved_status, {visible: false});
await page.waitForSelector(saved_status, {hidden: true});
}
async function test_change_organization_default_language(page: Page): Promise<void> {