message_flags: Clarify name for toggle_starred_and_update_server.

This makes it clear that the function sends the update to the server,
not just toggling the UI or local data structures.

frontend_tests/node_tests/message_flags.js

@@ -23,7 +23,7 @@ run_test('starred', () => {
         posted_data = opts.data;
     };
 
-    message_flags.toggle_starred(message);
+    message_flags.toggle_starred_and_update_server(message);
 
     assert(ui_updated);
 
@@ -40,7 +40,7 @@ run_test('starred', () => {
 
     ui_updated = false;
 
-    message_flags.toggle_starred(message);
+    message_flags.toggle_starred_and_update_server(message);
 
     assert(ui_updated);
 

static/js/click_handlers.js

@@ -181,7 +181,7 @@ exports.initialize = function () {
 
         var message_id = rows.id($(this).closest(".message_row"));
         var message = message_store.get(message_id);
-        message_flags.toggle_starred(message);
+        message_flags.toggle_starred_and_update_server(message);
     });
 
     $("#main_div").on("click", ".message_reaction", function (e) {

static/js/hotkey.js

@@ -707,7 +707,7 @@ exports.process_hotkey = function (e, hotkey) {
     case 'message_actions':
         return popovers.open_message_menu(msg);
     case 'star_message':
-        message_flags.toggle_starred(msg);
+        message_flags.toggle_starred_and_update_server(msg);
         return true;
     case 'narrow_by_recipient':
         return do_narrow_action(narrow.by_recipient);

static/js/message_flags.js

@@ -83,7 +83,7 @@ exports.update_starred_flag = function (message_id, new_value) {
     ui.update_starred_view(message_id, new_value);
 };
 
-exports.toggle_starred = function (message) {
+exports.toggle_starred_and_update_server = function (message) {
     if (message.locally_echoed) {
         // This is defensive code for when you hit the "*" key
         // before we get a server ack.  It's rare that somebody