paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_flags: Clarify name for toggle_starred_and_update_server.

Browse Source 
This makes it clear that the function sends the update to the server,
not just toggling the UI or local data structures.
This commit is contained in:
Tim Abbott
2018-08-01 11:09:12 -07:00
parent 2fcc54ac14
commit 4b4d420a5f
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend_tests/node_tests/message_flags.js
View File

@@ -23,7 +23,7 @@ run_test('starred', () => {
posted_data = opts.data;
};
message_flags.toggle_starred(message);
message_flags.toggle_starred_and_update_server(message);
assert(ui_updated);
@@ -40,7 +40,7 @@ run_test('starred', () => {
ui_updated = false;
message_flags.toggle_starred(message);
message_flags.toggle_starred_and_update_server(message);
assert(ui_updated);

2
static/js/click_handlers.js
View File

@@ -181,7 +181,7 @@ exports.initialize = function () {
var message_id = rows.id($(this).closest(".message_row"));
var message = message_store.get(message_id);
message_flags.toggle_starred(message);
message_flags.toggle_starred_and_update_server(message);
});
$("#main_div").on("click", ".message_reaction", function (e) {

2
static/js/hotkey.js
View File

@@ -707,7 +707,7 @@ exports.process_hotkey = function (e, hotkey) {
case 'message_actions':
return popovers.open_message_menu(msg);
case 'star_message':
message_flags.toggle_starred(msg);
message_flags.toggle_starred_and_update_server(msg);
return true;
case 'narrow_by_recipient':
return do_narrow_action(narrow.by_recipient);

2
static/js/message_flags.js
View File

@@ -83,7 +83,7 @@ exports.update_starred_flag = function (message_id, new_value) {
ui.update_starred_view(message_id, new_value);
};
exports.toggle_starred = function (message) {
exports.toggle_starred_and_update_server = function (message) {
if (message.locally_echoed) {
// This is defensive code for when you hit the "*" key
// before we get a server ack. It's rare that somebody