paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_ui_updates: Refactor update-stream-privacy-type function.

Browse Source
This commit is contained in:
Yashashvi Dave
2019-05-02 23:09:23 +05:30
committed by Tim Abbott
parent d86ee6b4f0
commit 4cd33f23bc
2 changed files with 26 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
static/js/stream_edit.js
View File

@@ -352,8 +352,11 @@ function change_stream_privacy(e) {
sub.invite_only = invite_only;
sub.is_announcement_only = is_announcement_only;
sub.history_public_to_subscribers = history_public_to_subscribers;
stream_data.update_calculated_fields(sub);
stream_ui_updates.update_stream_privacy(sub);
stream_ui_updates.update_stream_privacy_type_icon(sub);
stream_ui_updates.update_stream_privacy_type_text(sub);
stream_list.redraw_stream_privacy(sub);
$("#stream_privacy_modal").remove();
// For auto update, without rendering whole template

41
static/js/stream_ui_updates.js
View File

@@ -70,30 +70,33 @@ exports.update_stream_row_in_settings_tab = function (sub) {
}
};
exports.update_stream_privacy = function (sub) {
exports.update_stream_privacy_type_icon = function (sub) {
var stream_settings = stream_edit.settings_for_sub(sub);
var sub_row = subs.row_for_stream_id(sub.stream_id);
var html;
var html = templates.render('subscription_setting_icon', sub);
stream_data.update_calculated_fields(sub);
html = templates.render('subscription_setting_icon', sub);
sub_row.find('.icon').expectOne().replaceWith($(html));
html = templates.render('subscription_type', sub);
stream_settings.find('.subscription-type-text').expectOne().html(html);
if (sub.invite_only) {
stream_settings.find(".large-icon")
.removeClass("hash").addClass("lock")
.html("<i class='fa fa-lock' aria-hidden='true'></i>");
} else {
stream_settings.find(".large-icon")
.addClass("hash").removeClass("lock")
.html("");
if (overlays.streams_open()) {
sub_row.find('.icon').expectOne().replaceWith($(html));
}
if (stream_edit.is_sub_settings_active(sub)) {
var large_icon = stream_settings.find('.large-icon').expectOne();
if (sub.invite_only) {
large_icon.removeClass("hash").addClass("lock")
.html("<i class='fa fa-lock' aria-hidden='true'></i>");
} else {
large_icon.addClass("hash").removeClass("lock").html("");
}
}
};
stream_list.redraw_stream_privacy(sub);
exports.update_stream_privacy_type_text = function (sub) {
var stream_settings = stream_edit.settings_for_sub(sub);
var html = templates.render('subscription_type', sub);
if (stream_edit.is_sub_settings_active(sub)) {
stream_settings.find('.subscription-type-text').expectOne().html(html);
}
};
return exports;