paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Do not initialize save_organization_settings in build_page.

Browse Source 
We directly declare the save_organization_settings function instead
of first declaring a variable and then setting it in the build_page
function. This is a prep commit for using save/discard widget in
realm-level defaults section.
This commit is contained in:
Sahil Batra
2021-09-28 19:26:47 +05:30
committed by Tim Abbott
parent 7dc29f170d
commit 4e901d56ae
1 changed files with 20 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
static/js/settings_org.js
View File

@@ -24,7 +24,6 @@ import * as stream_settings_data from "./stream_settings_data";
import * as ui_report from "./ui_report";
export let parse_time_limit;
export let save_organization_settings;
const meta = {
loaded: false,
@@ -561,6 +560,26 @@ export function change_save_button_state($element, state) {
show_hide_element($element, is_show, 800);
}
export function save_organization_settings(data, save_button) {
const subsection_parent = save_button.closest(".org-subsection-parent");
const save_btn_container = subsection_parent.find(".save-button-controls");
const failed_alert_elem = subsection_parent.find(".subsection-failed-status p");
change_save_button_state(save_btn_container, "saving");
channel.patch({
url: "/json/realm",
data,
success() {
failed_alert_elem.hide();
change_save_button_state(save_btn_container, "succeeded");
},
error(xhr) {
change_save_button_state(save_btn_container, "failed");
save_button.hide();
ui_report.error($t_html({defaultMessage: "Save failed"}), xhr, failed_alert_elem);
},
});
}
function get_input_type(input_elem, input_type) {
if (["boolean", "string", "number"].includes(input_type)) {
return input_type;
@@ -758,26 +777,6 @@ export function build_page() {
change_save_button_state(save_btn_controls, "discarded");
});
save_organization_settings = function (data, save_button) {
const subsection_parent = save_button.closest(".org-subsection-parent");
const save_btn_container = subsection_parent.find(".save-button-controls");
const failed_alert_elem = subsection_parent.find(".subsection-failed-status p");
change_save_button_state(save_btn_container, "saving");
channel.patch({
url: "/json/realm",
data,
success() {
failed_alert_elem.hide();
change_save_button_state(save_btn_container, "succeeded");
},
error(xhr) {
change_save_button_state(save_btn_container, "failed");
save_button.hide();
ui_report.error($t_html({defaultMessage: "Save failed"}), xhr, failed_alert_elem);
},
});
};
parse_time_limit = function parse_time_limit(elem) {
return Math.floor(Number.parseFloat(elem.val(), 10).toFixed(1) * 60);
};