paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose_actions: Clean up unnecessary rewire.

Browse Source 
We organically create a user group so that the
pertinent code paths are accessed.

Fixes part of #32326.
This commit is contained in:
Kislay Verma
2025-07-10 21:47:19 +05:30
committed by Tim Abbott
parent c134cc398f
commit 56faf6b22a
2 changed files with 25 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/stream_data.ts
View File

@@ -855,12 +855,6 @@ export let can_post_messages_in_stream = function (
);
};
export function rewire_can_post_messages_in_stream(
value: typeof can_post_messages_in_stream,
): void {
can_post_messages_in_stream = value;
}
export function user_can_move_messages_out_of_channel(stream: StreamSubscription): boolean {
if (page_params.is_spectator) {
return false;

28
web/tests/compose_actions.test.cjs
View File

@@ -98,6 +98,19 @@ const {set_realm} = zrequire("state_data");
const realm = {
realm_topics_policy: "disable_empty_topic",
server_supported_permission_settings: {
stream: {
can_send_message_group: {
require_system_group: false,
allow_internet_group: false,
allow_nobody_group: true,
allow_everyone_group: false,
default_group_name: "group_creator",
default_for_system_groups: "role:nobody",
allowed_system_groups: [],
},
},
},
};
set_realm(realm);
@@ -171,7 +184,6 @@ test("start", ({override, override_rewire, mock_template}) => {
override_rewire(compose_recipient, "on_compose_select_recipient_update", noop);
override_rewire(compose_recipient, "check_posting_policy_for_compose_box", noop);
override_rewire(compose_recipient, "update_recipient_row_attention_level", noop);
override_rewire(stream_data, "can_post_messages_in_stream", () => true);
mock_template("inline_decorated_channel_name.hbs", false, noop);
let compose_defaults;
@@ -205,11 +217,23 @@ test("start", ({override, override_rewire, mock_template}) => {
assert.equal(compose_state.get_message_type(), "stream");
assert.ok(compose_state.composing());
const me = make_user();
set_current_user(me);
const user_group = make_user_group({
id: 1,
members: [me.user_id],
creator_id: me.creator_id,
});
user_groups.add(user_group);
// Autofill stream field for single subscription
const denmark = make_stream({
color: "blue",
name: "Denmark",
stream_id: 1,
can_send_message_group: 1,
});
stream_data.add_sub(denmark);
@@ -254,8 +278,6 @@ test("start", ({override, override_rewire, mock_template}) => {
const user1 = make_user();
people._add_user(user1);
const me = make_user();
set_current_user(me);
// Start direct message
compose_defaults = {