mirror of
https://github.com/zulip/zulip.git
synced 2025-10-24 08:33:43 +00:00
realm_creation: Disable open realm creation if no password backend.
This commit is contained in:
committed by
Tim Abbott
parent
de37ab28a8
commit
57d77e0a55
@@ -1472,6 +1472,21 @@ class RealmCreationTest(ZulipTestCase):
|
||||
self.assertEqual(result.status_code, 200)
|
||||
self.assert_in_response("Organization creation link required", result)
|
||||
|
||||
@override_settings(OPEN_REALM_CREATION=True)
|
||||
def test_create_realm_without_password_backend_enabled(self) -> None:
|
||||
email = "user@example.com"
|
||||
with self.settings(
|
||||
AUTHENTICATION_BACKENDS=(
|
||||
"zproject.backends.SAMLAuthBackend",
|
||||
"zproject.backends.ZulipDummyBackend",
|
||||
)
|
||||
):
|
||||
result = self.submit_realm_creation_form(
|
||||
email, realm_subdomain="custom-test", realm_name="Zulip test"
|
||||
)
|
||||
self.assertEqual(result.status_code, 200)
|
||||
self.assert_in_response("Organization creation link required", result)
|
||||
|
||||
@override_settings(OPEN_REALM_CREATION=True)
|
||||
def test_create_realm_with_subdomain(self) -> None:
|
||||
password = "test"
|
||||
|
||||
@@ -891,11 +891,17 @@ def create_realm(request: HttpRequest, creation_key: str | None = None) -> HttpR
|
||||
request,
|
||||
"zerver/portico_error_pages/realm_creation_link_invalid.html",
|
||||
)
|
||||
if not settings.OPEN_REALM_CREATION and key_record is None:
|
||||
return TemplateResponse(
|
||||
request,
|
||||
"zerver/portico_error_pages/realm_creation_disabled.html",
|
||||
)
|
||||
if key_record is None:
|
||||
if not settings.OPEN_REALM_CREATION:
|
||||
return TemplateResponse(
|
||||
request,
|
||||
"zerver/portico_error_pages/realm_creation_disabled.html",
|
||||
)
|
||||
if not password_auth_enabled():
|
||||
return TemplateResponse(
|
||||
request,
|
||||
"zerver/portico_error_pages/realm_creation_disabled.html",
|
||||
)
|
||||
|
||||
# When settings.OPEN_REALM_CREATION is enabled, anyone can create a new realm,
|
||||
# with a few restrictions on their email address.
|
||||
|
||||
Reference in New Issue
Block a user