paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 04:23:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui_report: Add ui_report.client_error.

Browse Source
This commit is contained in:
Ganesh Pawar
2021-01-26 14:34:26 +05:30
committed by Tim Abbott
parent e243af531b
commit 5802bbfb98
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/ui_report.js
View File

@@ -43,6 +43,10 @@ exports.error = function (response, xhr, status_box, remove_after) {
exports.message(response, status_box, "alert-error", remove_after);
};
exports.client_error = function (response, status_box, remove_after) {
exports.message(response, status_box, "alert-error", remove_after);
};
exports.success = function (response, status_box, remove_after) {
exports.message(response, status_box, "alert-success", remove_after);
};

7
tools/linter_lib/custom_check.py
View File

@@ -139,7 +139,7 @@ js_rules = RuleList(
{'pattern': r'ui.report_success\(',
'description': 'Deprecated function, use ui_report.success.'},
{'pattern': r'''report.success\(["']''',
'description': 'Argument to report_success should be a literal string enclosed '
'description': 'Argument to ui_report.success should be a literal string enclosed '
'by i18n.t()'},
{'pattern': r'ui.report_error\(',
'description': 'Deprecated function, use ui_report.error.'},
@@ -148,6 +148,11 @@ js_rules = RuleList(
'by i18n.t()',
'good_lines': ['ui_report.error("")', 'ui_report.error(_("text"))'],
'bad_lines': ['ui_report.error("test")']},
{'pattern': r'''report.client_error\(["'][^'"]''',
'description': 'Argument to ui_report.client_error should be a literal string enclosed '
'by i18n.t()',
'good_lines': ['ui_report.client_error("")', 'ui_report.client_error(_("text"))'],
'bad_lines': ['ui_report.client_error("test")']},
{'pattern': r'\$\(document\)\.ready\(',
'description': "`Use $(f) rather than `$(document).ready(f)`",
'good_lines': ['$(function () {foo();}'],