confirm_dialog: Make Bootstrap fade class optional.

It would be better to load non-setting modals instantly.

This was previously reverted in
7bfa607d0a due to a rebase conflict.

static/js/avatar.js

@@ -105,6 +105,7 @@ export function build_user_avatar_widget(upload_function) {
             html_body,
             html_yes_button: $t_html({defaultMessage: "Confirm"}),
             on_click: delete_user_avatar,
+            fade: true,
         });
     });
 

static/js/confirm_dialog.js

@@ -32,7 +32,7 @@ import * as overlays from "./overlays";
 */
 
 export function launch(conf) {
-    const html = render_confirm_dialog();
+    const html = render_confirm_dialog({fade: conf.fade});
     const confirm_dialog = $(html);
 
     const conf_fields = [
@@ -47,7 +47,7 @@ export function launch(conf) {
     ];
 
     for (const f of conf_fields) {
-        if (!conf[f]) {
+        if (conf[f] === undefined) {
             blueslip.error("programmer omitted " + f);
         }
     }

static/js/settings_emoji.js

@@ -251,6 +251,7 @@ export function set_up() {
                     html_body,
                     html_yes_button: $t_html({defaultMessage: "Yes"}),
                     on_click: submit_custom_emoji_request,
+                    fade: true,
                 });
             } else {
                 submit_custom_emoji_request();

static/js/settings_invites.js

@@ -208,6 +208,7 @@ export function on_load_success(invites_data, initialize_event_handlers) {
             html_body,
             html_yes_button: $t_html({defaultMessage: "Confirm"}),
             on_click: do_revoke_invite,
+            fade: true,
         });
 
         $(".confirm_dialog_yes_button").attr("data-invite-id", meta.invite_id);
@@ -233,6 +234,7 @@ export function on_load_success(invites_data, initialize_event_handlers) {
             html_body,
             html_yes_button: $t_html({defaultMessage: "Confirm"}),
             on_click: do_resend_invite,
+            fade: true,
         });
 
         $(".confirm_dialog_yes_button").attr("data-invite-id", meta.invite_id);

static/js/settings_org.js

@@ -1168,6 +1168,7 @@ export function build_page() {
             html_body,
             html_yes_button: $t_html({defaultMessage: "Confirm"}),
             on_click: do_deactivate_realm,
+            fade: true,
         });
     });
 }

static/js/settings_user_groups.js

@@ -368,6 +368,7 @@ export function set_up() {
             html_body,
             html_yes_button: $t_html({defaultMessage: "Confirm"}),
             on_click: delete_user_group,
+            fade: true,
         });
     });
 

static/js/settings_users.js

@@ -519,6 +519,7 @@ function confirm_deactivation(row, user_id, status_field) {
         html_body,
         html_yes_button: $t_html({defaultMessage: "Confirm"}),
         on_click: handle_confirm,
+        fade: true,
     });
 }
 

static/js/stream_edit.js

@@ -872,6 +872,7 @@ export function initialize() {
                 html_body,
                 html_yes_button: $t_html({defaultMessage: "Confirm"}),
                 on_click: remove_user_from_private_stream,
+                fade: true,
             });
             return;
         }
@@ -940,6 +941,7 @@ export function initialize() {
             html_body,
             html_yes_button: $t_html({defaultMessage: "Confirm"}),
             on_click: do_archive_stream,
+            fade: true,
         });
 
         $(".confirm_dialog_yes_button").attr("data-stream-id", stream_id);

static/js/subs.js

@@ -971,6 +971,7 @@ export function unsubscribe_from_private_stream(sub, from_stream_popover) {
         html_body,
         html_yes_button: $t_html({defaultMessage: "Confirm"}),
         on_click: unsubscribe_from_stream,
+        fade: true,
     });
 }
 

static/templates/confirm_dialog.hbs

@@ -1,4 +1,4 @@
-<div class="modal modal-bg new-style hide fade" id="confirm_dialog_modal" tabindex="-1" role="dialog" aria-labelledby="confirm_dialog_modal" aria-hidden="true">
+<div class="modal modal-bg new-style hide {{#if fade}}fade{{/if}}" id="confirm_dialog_modal" tabindex="-1" role="dialog" aria-labelledby="confirm_dialog_modal" aria-hidden="true">
     <div class="modal-header">
         <button type="button" class="close close-modal-btn" data-dismiss="modal" aria-label="{{t 'Close' }}"><span aria-hidden="true">&times;</span></button>
         <div class="confirm_dialog_heading"></div>